From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D85ACC52D7F for ; Thu, 15 Aug 2024 21:16:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EDF86B025B; Thu, 15 Aug 2024 17:16:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2757D6B025C; Thu, 15 Aug 2024 17:16:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 116576B025E; Thu, 15 Aug 2024 17:16:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E05BD6B025B for ; Thu, 15 Aug 2024 17:16:39 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 87788C189C for ; Thu, 15 Aug 2024 21:16:39 +0000 (UTC) X-FDA: 82455738918.14.D80BBAA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id DCC0016002B for ; Thu, 15 Aug 2024 21:16:36 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FHqBFdpM; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723756538; a=rsa-sha256; cv=none; b=mZhtSz/uT26P+QBTN+COQaGP/KN3eiMRb2klAaaTfuRV9bi0iWBORle1LkOHZgNm5aV/uP BcpZIbjKS8QYZipNPfUT52mTcXvMbVqY8w9q2J4RGXG5I8tBlQQIMjwwMFrm0MY/E/Fj5F 3kfoORFca7cWoAJEK+0YWtMR6BAWyRo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FHqBFdpM; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723756538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wVrshdgc5r4mBDt3sLx4Vu72sbLxT+zdRw8VaO2LgwU=; b=hEevX2bw/yziMYlswOVRb0dSq8XWh03/7C2UqSEoc2GM2c/FuiFQ4iyPQjm1/hA5/8uu8f XMXnU/NAPvNL9jnSeX5Hr72wKUqqyWL1rbhTdN3FSZimbstrsTwEIzZsq6b3BczT64kRrK Za9qYF85nzyW4Z5urY8dlx/jIPvDkfw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wVrshdgc5r4mBDt3sLx4Vu72sbLxT+zdRw8VaO2LgwU=; b=FHqBFdpMR0fSUdDqEFPZ1ujvqt ZjOVAXoZcKmsBhvKFP2Bkm7pHlUIJ/Sa1yrQ0UKruvR7CPWMoALIhwtH8a1II/uiFHALHJasonaSP 15JC13KaliZ75mxBzCnAaPa6i5Bh5sN9i/haxtz9I1dSodd5wXWX3N4hvKkpZf1KNwMdS25f5HGhO LzqDd1wy8fNskrB7q7ViaVJSO8A0WpVzfUE8qWqjxtwaRCxib2gv7g3lKnCJKsYM5WH9SVxSkRsBP IH5sJlXLQliZZsfnk1JTlOfgcWz1Vjol/gXnpSfnAz/JgcvxlOewEYav8qt91ydmucqj4hGa07Kal zuXLdElA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sehpb-00000002b12-2mPQ; Thu, 15 Aug 2024 21:16:27 +0000 Date: Thu, 15 Aug 2024 22:16:27 +0100 From: Matthew Wilcox To: Roman Gushchin Cc: Shakeel Butt , Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , "T . J . Mercier" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org, Michal Hocko Subject: Re: [PATCH v2] memcg: replace memcg ID idr with xarray Message-ID: References: <20240815155402.3630804-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DCC0016002B X-Stat-Signature: okr7y8gj13zynafkgzs9t8anpdojfu88 X-Rspam-User: X-HE-Tag: 1723756596-318235 X-HE-Meta: U2FsdGVkX1+MzcOEyDc8I7hdyHgJZ7LBdCi1p7PBcA6OYoBWaWltdBItN6xfDEsidLf0pPaSSMN46QH3kkILngQDbwmjAhGpgzKpICAnOGICmOnm5fbVFO5TwR7xv0hGaWqD+71vb1KLZ+/tiIbaX3cxC+/q2ZW7wXNqm4W5t+15imG1zF6bFFL7PU4Ylb4in3ZCUpMk+pb2jdHjv9dtEk+AdXbZyh0M4cVdNmvH//sxmMIq+JQtCukjWnAxxMiy+08j74w/ItR/KddLLs0cgRbFPblH4wNalM4lHau4bYq4XJutV/0W2vE/ZrdYwPqDATWHrrrQfPJeviVqqBTnbcD1wIrkyskNuFnzcWj1PbZ2hncNDujtHzSTEgaIULKM5aq72EIHtzBUUwXcBX0ryVgXg62xXxMF7bFunoNCB6ouEh/jsdQ6HFYdIN+gVcNXDzlnbHnJUCphinVAjhZ5q3WUU5oj1XPEPl61Bf4RSfwkKjNKfe51ih+ecK3Yk9CU4XaiVXydEs1FpFwRDTn21ZytQEuSpfjXK+Gg/j4eGIr/s36d4Lg3qfugeIbM7XAVn5axirJp/B8nB6gWUC4PR5L63UlhTSFe+Oqr9+pfpsIIKhsMTlQaCtN85R6kK4JlkTfx5Nrl9pRAUi2KPOHYBGV2r+hKaRLSl28nO5/z2M5ItQKs09Fni+lTzvtDlIAXs9g1N6jeuwyj0sepR3wkqFJGCDrCaD3PMC+wGFyQWOOBAWA1vgWO6qXjhfiFHKiiyTcSLq8OWRmboXxkIjSyiaoE2KHef8xNlRJCDaIUo0CJoV+CkX3KgF9ARHH2pF0kUqrmgBJhC1qntFouSMeI2sA4daqIibPgTXt5RvQ7tmFol/4r6noxlyjKvw3B/BBxZai3jVCWSmEH5BQLY4+7EJ/gWQM3CsypWIAev/5Lp1RaZ7RkccKgZEKhqchn70UmTPEeF31iQyxc9zdvAHg 5mARTsE0 epxvuYTz/JGxeEeM4ueMGKPF7AjwLRX/DDHgCuB2mPWt1JmoNQqQCNJJbjCnPiMU415x3dPTf1gP5JUCowtgZVHAUq6MBBeGK5nAdCr2zTMXY05HAAyTkDaSJ6uGmabgblmvLcr2EUzeq3wCv4OTQRnG+Yg+ulH9yukBTRzggsxrxL89CuOjYJqN9Jx0Sp07FkCPaweqcfw6zHYs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 15, 2024 at 07:31:43PM +0000, Roman Gushchin wrote: > There is another subtle change here: xa_alloc() returns -EBUSY in the case > of the address space exhaustion, while the old code returned -ENOSPC. > It's unlikely a big practical problem. I decided that EBUSY was the right errno for this situation; #define EBUSY 16 /* Device or resource busy */ #define ENOSPC 28 /* No space left on device */ ENOSPC seemed wrong; the device isn't out of space.