From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42824C3DA7F for ; Thu, 15 Aug 2024 15:46:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B71E16B0154; Thu, 15 Aug 2024 11:46:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B206C6B0155; Thu, 15 Aug 2024 11:46:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0EFC6B0156; Thu, 15 Aug 2024 11:46:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 810806B0154 for ; Thu, 15 Aug 2024 11:46:03 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D8B0DA79C8 for ; Thu, 15 Aug 2024 15:46:02 +0000 (UTC) X-FDA: 82454905764.20.C463536 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 3B336C002E for ; Thu, 15 Aug 2024 15:46:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723736724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zJYnt9EyeWygvGK7AEK0TpLWJuxPs4jnIdeIRweW6Wc=; b=SrOCPAqLmJSFguD3dpB2iFBykMZcRBird5fujwrBItB2OK9ivkJ28DJA4CVnHsZ5blWdqj MAVX7JH9MNKX+P63OhrCW/NqrhprT4e0oIivtD1yHAs+wtJr6F9drIc2q9Y/2g9E8v/zVw mmIHpa/4F87B4sdw+U/BTGbX1QBfEnI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723736724; a=rsa-sha256; cv=none; b=OJkEB8pTqyA16UR+T14b5syddJ5lPyJHXI/4AnGf8lVcYlBBNA/x/v1RYLYsNsKbKALPHg 0WFDSyQkYBttf1gdkQMwkQ0Kppat8976VzNYNfmw3ZDJxx0BdOm1oRs/VVRHeC12nhSlvk CbdtDeEknxnZOiz4Wi5IN1lxSsVpO1Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 45AB661E65; Thu, 15 Aug 2024 15:45:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74432C4AF09; Thu, 15 Aug 2024 15:45:53 +0000 (UTC) Date: Thu, 15 Aug 2024 16:45:51 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v10 03/40] mman: Add map_shadow_stack() flags Message-ID: References: <20240801-arm64-gcs-v10-0-699e2bd2190b@kernel.org> <20240801-arm64-gcs-v10-3-699e2bd2190b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240801-arm64-gcs-v10-3-699e2bd2190b@kernel.org> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 3B336C002E X-Stat-Signature: 4g581zboa6kqpah9dgmhakm9ojsxoycx X-HE-Tag: 1723736760-933548 X-HE-Meta: U2FsdGVkX1+Nls9U5WWLNe0fD4rg+rWjg4+QRg/FG2F7nYBPafW/jmXzmqvgaCAEEuROj723XdG+tlGNcnb+tfDuR5yyvcXFyN/P+nqq5tcUipxCcPKwxyzk3t5LFJo09LFwCTpoRSYAz0iGOaG6qslfs3n3Gql9OQdwxrqO+E53ko3mzzrA13zeb4AoSEmWZbQga+YomE8Y7GTE2Y6AJt42Y7vXM5qYj/JpJgSxnH0L7m7aCCVCpdWCFPu/bD25eKjIoyuZF765VkJeZEvKLE3Iplr/DQy8RKc0feRAQzYmOXvLf9daZSh6B6lIjX+VG0YjQvI6j5ccsdv1r+TlCFr/uh9PnHQn4qLI4sglwZ5NPVc5WERmP7RTZGfCaOStDi8/ToYIft2GAyIWVWeig9ROdELjO0RDSYN74zWTI0h1YEq1xk5GOr6BjTRg+Qn/v3+KyWaa5CwAeZKxK89aZaWmqk8BQ380Ig56+San2dY1wNix43xkUgVmPqISVnWFpbwWlc5AMhOqwxBUCxJLXVV1NPlN7OKkzWTYgI0IDdpgkiqDVEf15QOsUaB0HRq4bq763lABPFj+g65ndOF9A+Ti6HXLoXLMGEJOzUjVPmpO+lcNwNxYNSooI1AvylmsAsfaK+dZKMLXwBHcm2++a4AVP+OMdxInYGnfwgf03p7poGfcxHIm6LPDyaaExouwL8rF5bbozjjsNFVHVjmcbeZwIkNo3xvd7uEstrVoyFcXKGO0ulayfR7IRLoks3/1k6wM+8TmLmGHV/Ni+nMjX+JgiHCqif0VXSjItBOoLiSnoHYUFdaJKrqrBzmR+SM6KjCoqA8nUwErUzkdiaWDB/93qjZcEbmXYFCRiIHARCT7ZzOhgthwKFpj5HCrso0V1jJIMcbCmoowL9aG1OXd0xsTy3CxilzkqmOPTRVxFbMLPzQMJLLxnOE7HZ97rPtclH9qXJwr1Czx+sVomC/ RHSiu4nE GoRscxBW87hOFAl3FGp0betDvW0JkzVUdh6oDwLpZLBSc/FquuZyVKltWkZVD7z9QhTEqSSMvIUlgldNgLNrDWQ+t2Y3AqRlMkUgbSMn+GhwGRhn0vCeO2cB0W43PBqQTEoeT7U/UsmsHiscijJ2QXjdyLNzZEcpwa1PnKnn3gcXcoGo6eufpWhAwD6AYnHIi6RzSksdaISnzOcqMfNwU00+dIZod+ILuxug3jlkn/vP2264KtfP8uaqKR+m4TFJjNfAaHwpM4fBdhAiMW1dfsUi+uLr0t9twBAb78wcntYXIIMOk4rXBpbopZBxaxFglja3kwF18+yRgK2dL3QW5JppCVU7RB49fgHIunFk3K6TnmXV/67DTug1TtwPUrDJN+RjUmd8mknkjzXk4Ii/5A12AXb8aUDvc6tPIpTiClMnvrNR4fefw1GTzabNOem/uoU0uAnYBib6RDGDt0Oli2yPxizWW90r5J9ZCb683CsYeZngYuSPkzhZSjflCtdvpky5NtE1LSazufGg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 01, 2024 at 01:06:30PM +0100, Mark Brown wrote: > In preparation for adding arm64 GCS support make the map_shadow_stack() > SHADOW_STACK_SET_TOKEN flag generic and add _SET_MARKER. The existing > flag indicats that a token usable for stack switch should be added to Nit: indicates > diff --git a/include/uapi/asm-generic/mman.h b/include/uapi/asm-generic/mman.h > index 57e8195d0b53..d6a282687af5 100644 > --- a/include/uapi/asm-generic/mman.h > +++ b/include/uapi/asm-generic/mman.h > @@ -19,4 +19,8 @@ > #define MCL_FUTURE 2 /* lock all future mappings */ > #define MCL_ONFAULT 4 /* lock all pages that are faulted in */ > > +#define SHADOW_STACK_SET_TOKEN (1ULL << 0) /* Set up a restore token in the shadow stack */ > +#define SHADOW_STACK_SET_MARKER (1ULL << 1) /* Set up a top of stack merker in the shadow stack */ s/merker/marker/ Otherwise: Reviewed-by: Catalin Marinas