From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41446C52D7C for ; Thu, 15 Aug 2024 17:20:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA1976B00F6; Thu, 15 Aug 2024 13:20:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2AE26B00F8; Thu, 15 Aug 2024 13:20:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA3EA6B0184; Thu, 15 Aug 2024 13:20:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 89F5F6B00F6 for ; Thu, 15 Aug 2024 13:20:39 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 39A89C134C for ; Thu, 15 Aug 2024 17:20:39 +0000 (UTC) X-FDA: 82455144198.16.EF4A482 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf13.hostedemail.com (Postfix) with ESMTP id 090162000D for ; Thu, 15 Aug 2024 17:20:36 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=doGnIbTb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723742424; a=rsa-sha256; cv=none; b=RhTfWV4U4xEHBBFBIUQjYH1o/tnjPnjqn89HI7Q0N+q9LkaSo7gDDg8bGWbvxju8hQMXCX sF8fOf46Rwtd9TwIyjKd1la2vFNwfLWUi+iGfnWj1dDPSOO8agYXmUo1qFd+71OMBMrj0n jWrzNaqVjNqg2PMnp3+oaw4R1Mc1G2w= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=doGnIbTb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723742424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1JEMit7NXWy1oM7PwyAX/lr16pflfyaQomIcHR1s8G0=; b=GVqgB06ez0J3ABaq9w13ivjaGawQlSsIkd6f1gAPb12JS55yuHZSPbXmvkiPuSPIbH2zCk S8KO3o4zHN6AxnQv0ig7aTrFwfheyK4zuDAPALG1djaD4S9X2PtphnkP7Y5Y93uY4fvoTE MmMZhPJjHpEzTsPWyodV6hsFlx2guaE= Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6b7a0ef0e75so7178286d6.1 for ; Thu, 15 Aug 2024 10:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723742436; x=1724347236; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=1JEMit7NXWy1oM7PwyAX/lr16pflfyaQomIcHR1s8G0=; b=doGnIbTbpW5BwF9BI3EpeObKqCAcoER1ToLvDTcB5B0dCYHMBO7rCCI7WARvkWuHQa eEE5ebV3nGMXf+x2gJowh9esqtYCHnluptKUZR/ni20B36VcGjBgY+2ctpcNYc1V/VTm zUyWJz+2bEp2Z44Z56MpZtZ29GiIF4j3aOfp6o4cKe39PWwZaNV6aMQWDdyOvUlG5pS4 z5fOw7TtFR0kU8IhILoqG+t8SbJyFsNXja1SlRL/TY+7KPXUnzmE4qohX5Pj8BjynbZO 3M6hjrNBZ+JC9xef3qVgBMcyTqwImYrVeKLy4gTtcq3zLjWu8Ybr6UqFgdBTxgriOQYH OVZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723742436; x=1724347236; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1JEMit7NXWy1oM7PwyAX/lr16pflfyaQomIcHR1s8G0=; b=Gcie5BqZEGQIyx1tH/Iunjfgc/w0DcB91pz/qdq73JIwdKOQgSf1cvy5dH9D2ONdP/ ufNoKppFTOLTcLkvRmFi7Fj9YTQb42snornj2m7qh8E/4LC5vkeR97g+LUf5MOoqmASx qVVLfHB5OS3CT2JCW2K+SjoKcAkSbYQ3TcQQr/oyNhM5JaudhXA/dBGsHP8fUA3yseBh qkH6HN5JSYinbddSXU2vocV/3+D/4G0N9G4jmB7OfZ2sRUA0ITYP8qpucsBpRLEEapSA +6Gi3QjqWBpXviXCbNdi8d+ElEnLP0Gcvd9/YyLAVzOCb0J5eKMIUBndqBWoWKjXTQe5 dOKA== X-Forwarded-Encrypted: i=1; AJvYcCWv7B3s73phZ/x84o582sZvRSZtKV+guhi/NsQwhdEsMUUV/IwuTMkCy9NEKVrmvIk07n1Kd7gEtZfyOU9v/FMvAvE= X-Gm-Message-State: AOJu0YwerwQYNFq1HvXlrzYnNP+BcAVCHzBdC/Iq0uzCriUUey7/Nl2E RFPDMiPY7FMppHRWVOSmnFMlX8IrXyzc/lnja02TQkW9+elL5sJs X-Google-Smtp-Source: AGHT+IHGdJ9pU0p5MvXCP0KQeaP2XqUR3h3aauTkKl1mBnuGM+AjKEOAePQH06YoMSm6v5bIHMzPdA== X-Received: by 2002:a05:6214:4890:b0:6bb:b21b:d158 with SMTP id 6a1803df08f44-6bf7ce7b5c0mr1111866d6.45.1723742435947; Thu, 15 Aug 2024 10:20:35 -0700 (PDT) Received: from fauth2-smtp.messagingengine.com (fauth2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bf6fe2748csm8018416d6.63.2024.08.15.10.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2024 10:20:35 -0700 (PDT) Received: from phl-compute-01.internal (phl-compute-01.nyi.internal [10.202.2.41]) by mailfauth.nyi.internal (Postfix) with ESMTP id 6F99B120007E; Thu, 15 Aug 2024 13:20:34 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Thu, 15 Aug 2024 13:20:34 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddtiedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpeeuohhquhhnucfhvghnghcuoegsohhquhhnrdhfvghnghesghhmrghilh drtghomheqnecuggftrfgrthhtvghrnhepuedvgeekjeevgffggfejgfehueefteeuffff gfehteekjeffvdfgkeetgeeiieeunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghdprh gsthhrvggvrdhrshenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpegsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeile dvgeehtdeigedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmhgrihhlrdgt ohhmsehfihigmhgvrdhnrghmvgdpnhgspghrtghpthhtohepvdehpdhmohguvgepshhmth hpohhuthdprhgtphhtthhopegurghkrheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohep ohhjvggurgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprghlvgigrdhgrgihnhhorh esghhmrghilhdrtghomhdprhgtphhtthhopeifvggushhonhgrfhesghhmrghilhdrtgho mhdprhgtphhtthhopehgrghrhiesghgrrhihghhuohdrnhgvthdprhgtphhtthhopegsjh horhhnfegpghhhsehprhhothhonhhmrghilhdrtghomhdprhgtphhtthhopegsvghnnhho rdhlohhsshhinhesphhrohhtohhnrdhmvgdprhgtphhtthhopegrrdhhihhnuggsohhrgh esshgrmhhsuhhnghdrtghomhdprhgtphhtthhopegrlhhitggvrhihhhhlsehgohhoghhl vgdrtghomh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Aug 2024 13:20:33 -0400 (EDT) Date: Thu, 15 Aug 2024 10:19:03 -0700 From: Boqun Feng To: Danilo Krummrich Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 00/26] Generic `Allocator` support for Rust Message-ID: References: <20240812182355.11641-1-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 090162000D X-Rspamd-Server: rspam01 X-Stat-Signature: haem5mexm9d45e6p99krww4f4p7ahjgi X-HE-Tag: 1723742436-237184 X-HE-Meta: U2FsdGVkX1/lPsPal9ayWIosnF5S5kBEcXYHxi748lrrKJH83hrOOfifCzmjpNsjvLXU8VECqqpon9DsKo8eGCtnVw89sSIkSOTBoGaoBIi8Yzbx8UTnJcYPhBI6BhyOmkUq2f2U+seg7ANFCCu/MJQuWQ2tJAzKM9S4KWmQapQ6n2XEeyjekYQ3kvzumsCJZhzS6O8IBEhiWVTAnI2TlipZq4msZRGit+OmKVshFyjxnbVoYdU1niyWdixIZ8YeOQ7IIQK307ABl8OkR3fsRi7VWt2kLjr76xhR9zPxeMfISfn4ygM+ZWL6AzkWb/T6bubhde9rL/OknlgiX8xr5LDHU+0u9ozNXTK0kLqDgQT1Zh2k0FYKJIZOkyvA5qv2C6MqPYmmMV/njvKqtAGLBXPePlYLWBW9XQWnaXI0lHqf01BFS7N4XkPsJZocz6T8pna91RBACWNF+AsojYyIVegAVMUcCu1USyWRQbCBQ5kfmucro5JwuCHZ9iGi3PNvJyoIBBrALf4VuoH2a/n1JgmSwa1+H7qYt7TuSF9B4pFtUQu/K+/mUgWVCDXzLmFlsG1KlfOvZiFcu1KseZ9gAhsJgXhivNZvay58R1S6TqMYhLvZbAlmvmWpAbJYAEkHVEzc994ii53B768kNitQcMxpVlq/zRiMfVNAheZ2gjYqhUaDPFu5KBganGfBMe/uyAStwiRqqzBghvVbge+cyRwQsZ1UwFnagpdKv/7h14k4ojCuoWjSNo4Yhr1YyuTrSAamQwky2Gf5zuqHhoVkavJF4AQ7WjixssZXm03Xy24Gx1lvsxbjdaY2XKiV6l0ceFD2LmtUJOj35ija5U/1mUUZKROZL0I2G89/ky0ZfNnXOa+eebfhS1oUNW/57QHV5LVHRPatg/vCSK70OZfOPb8uV4GU0HuxqXfPiXmeMyz52zRNduXWIeanxZnJ88pDYgw+LZnUVm+B//Pb17/ Z1PP7/+U Vv17bq+wA6oWvtuLScrnJnrC0VrbAYVnu+yhknYuJvl7JMMDW7MQ7xcG75mh71JmiGCmrzMYi8/4NYiOMZEjFdwVKYrWr78t5RpOqn9bx6x2bSjwIn6daAJf86xUNqxNGJOUPWHOd8bh0ZGhg1DmgIBIWIUfj5Rlq0qGbUtLbydmY4vEEDhW/dGgcHy3nQKLf2bHNbMd+uVEPqktDSKhypWi5AQn1CqEEtz4CDmAfZ8r3u9PtAuLjE2dIfNKwZ23iBTM+qQLtxJKsBOT/hXPQwR2XtGmmHIPdgMAVbbYSDXOEZlzbDF05CL+/e3ZO0uuZsy3msGHoSk7RfZg8eVD8zUcSpbopDpEtmbwdISl7yaXd+/UEP6Ak+8SC+b1LNFPf1Qf49QpAmNyutWE4Lyx2HN3pTdmnjekxNfq7rrUjwCBU3E0dCmPH8VeGQpE+zrVMs8TtvxiPQG8fdfSvTQQOnDCmDy4K0Vig384P X-Bogosity: Ham, tests=bogofilter, spamicity=0.001508, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 15, 2024 at 04:52:42AM +0200, Danilo Krummrich wrote: > On Wed, Aug 14, 2024 at 12:32:15PM -0700, Boqun Feng wrote: > > Hi Danilo, > > > > I'm trying to put your series on rust-dev, but I hit a few conflicts due > > to the conflict with `Box::drop_contents`, which has been in rust-dev > > for a while. And the conflict is not that trivial for me to resolve. > > So just a head-up, that's a requirement for me to put it on rust-dev for > > more tests from my end ;-) > > I rebased everything and you can fetch them from [1]. > Thanks! I will take a look later today or tomorrow. > I resolved the following conflicts: > > - for `Box`, implement > - `drop_contents` > - `manually_drop_contents` [2] > - ``move_out` [2] Have you considered naming this `into_inner` which is aligned to std `Box`? Regards, Boqun > - `BorrowedMut` for `ForeignOwnable` for `Box` and `Pin>` > - `InPlaceWrite` and updated `InPlaceInit` > - for `RBTreeNode`, make use of `Box::move_out` to replace the original > implementation partially moving out of `Box` > > @Alice: Please have a look at the changes for `RBTreeNode`. Maybe it's also > worth having them in a separate patch. > > - Danilo > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/log/?h=rust-dev/mm > [2] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/commit/?h=rust-dev/mm&id=ef80ccca2ccebf3c7bcafdc13d1bfe81341cbe63 > [3] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/diff/rust/kernel/rbtree.rs?h=rust-dev/mm&id=c361d66df7fb7760064fbca6bf9d72171c352a73 > > > > > Regards, > > Boqun