From: Alexander Gordeev <agordeev@linux.ibm.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-s390@vger.kernel.org, linux-um@lists.infradead.org,
x86@kernel.org
Subject: Re: [PATCH 4/5] s390: Remove custom definition of mk_pte()
Date: Thu, 15 Aug 2024 14:12:33 +0200 [thread overview]
Message-ID: <Zr3wsRHO+hcwv5Y0@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com> (raw)
In-Reply-To: <20240814154427.162475-5-willy@infradead.org>
On Wed, Aug 14, 2024 at 04:44:24PM +0100, Matthew Wilcox (Oracle) wrote:
Hi Matthew,
> I believe the test for PageDirty() is no longer needed. The
> commit adding it was abf09bed3cce with the rationale that this
> avoided faults for tmpfs and shmem pages. shmem does not mark
> newly allocated folios as dirty since 2016 (commit 75edd345e8ed)
> so this test has been ineffective since then.
We will investigate if that is really safe thing to do.
Some people on vacation, so we might be not too quick
with the response.
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> arch/s390/include/asm/pgtable.h | 11 -----------
> 1 file changed, 11 deletions(-)
...
Thanks!
next prev parent reply other threads:[~2024-08-15 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 15:44 [PATCH 0/5] Provide a single " Matthew Wilcox (Oracle)
2024-08-14 15:44 ` [PATCH 1/5] mm: Introduce a common " Matthew Wilcox (Oracle)
2024-08-15 2:45 ` kernel test robot
2024-08-15 2:45 ` kernel test robot
2024-08-14 15:44 ` [PATCH 2/5] x86: Remove custom " Matthew Wilcox (Oracle)
2024-08-15 4:08 ` kernel test robot
2024-08-14 15:44 ` [PATCH 3/5] um: " Matthew Wilcox (Oracle)
2024-08-14 15:44 ` [PATCH 4/5] s390: " Matthew Wilcox (Oracle)
2024-08-15 12:12 ` Alexander Gordeev [this message]
2024-08-22 14:06 ` Alexander Gordeev
2024-08-14 15:44 ` [PATCH 5/5] mm: Make mk_pte() definition unconditional Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr3wsRHO+hcwv5Y0@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com \
--to=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox