From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C55B8C52D7C for ; Thu, 15 Aug 2024 12:33:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58CAC6B00AD; Thu, 15 Aug 2024 08:33:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53AFD6B00D7; Thu, 15 Aug 2024 08:33:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 402E96B00D8; Thu, 15 Aug 2024 08:33:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1CB206B00D7 for ; Thu, 15 Aug 2024 08:33:30 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 965C316150E for ; Thu, 15 Aug 2024 12:33:29 +0000 (UTC) X-FDA: 82454420538.17.950EE52 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id E38921A001B for ; Thu, 15 Aug 2024 12:33:26 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f1Qxzjlm; spf=pass (imf19.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723725134; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=85UaOkvG2/e64bIVdnSfacWykd/k0+Nq5JGJ/zfL/5M=; b=jDF41uiRwSoidwHMF4BFkZr7XPnF3NDDl7lw388VPqtQUjjWawaXMVex2aD1qO7nr3vjou vLQbVXNE7C5xfWMPKQ+OO3AjGrlFR51z7ut4L2h8MWg5uZXEmb7lqZA2bNcix5M0t9gxh5 nnE+Zq9GjhR2zA15bSqThfp1WuLqT2Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723725134; a=rsa-sha256; cv=none; b=gilRZoVdybcWvbRqPeTLPFNgGpAluWgkQT7GdJffvikHuOvPRrRGskXAbrHs+Ha0lz2ZAW sg5JUo2hCWI7pGjFQAZGX3pgy81THFM5fMI93wZheObHpafV2XQtNIwNgl60oNeJ2HiYIR SJSVFhLvbe3wX36wQJ8xdIXJ8sSTUew= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f1Qxzjlm; spf=pass (imf19.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 04B6861E4E; Thu, 15 Aug 2024 12:33:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFC07C4AF0B; Thu, 15 Aug 2024 12:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723725205; bh=aFz6QZuvfklNKy+lGLokX91B3P7oStHD3S4UrY7+mxs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f1QxzjlmzHIWRxp+GaMG0YjawSSaxCHv3jHbKHPInQoPZzf1nuHi1T6l23l5izyJa GEXdmb9wwxsqluXvX/0xrmP2lkoMQSq67WSRqr3LRbC+GuttD3GhFYhH1sC439zq0u qED0H7kKAcsXUgaubAKZcf0hva0Tg7CB0JUDtrDpYG5RNtwaJwAjknUt1m/p82em/P pCC2aq7vujNOPiJwKfRLjzj3JwFhczkC1XDdfVtXUaCDMKItIRYbxrW7dqCt9tkkiC BcYCZbS2dKFrij/ZhpgsdGtdMJP7KHtJDjY/kopZDG9p20hvbZ9MKNm/IILrW1Gk0E DmB4x6pCR270g== Date: Thu, 15 Aug 2024 14:33:18 +0200 From: Danilo Krummrich To: Alice Ryhl Cc: Boqun Feng , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 00/26] Generic `Allocator` support for Rust Message-ID: References: <20240812182355.11641-1-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E38921A001B X-Stat-Signature: oeupuo7o1xfxjk3rcsqs6xtuk9qj5bo8 X-HE-Tag: 1723725206-304832 X-HE-Meta: U2FsdGVkX18x25PpRq80GWJaGY3Jbz+4FFrmKYUHvVvQFR8R22vnN5f0AwzNMcg+GC/CpL2woTDBFxHfpcIqWylgBPH0FjrTtyHDM597+4X+rwXgbTqUc73gc2B5b7iXq+vqnWyovdKYczPS2F0R1c2ZPKLQW1DKMh6OzoeS/55enb+W+DwYdld89esgT7mCbcDqj+wisbhN5HtjYimJfWmp0Tg1iTWtDw9crrmn8UK0+J0yjKeIcmcHf2/7X15dv+EmZTQ4AdWNtjqPxXXOgslrL0BeQyK8XHPQtau0NXZ7YDcNVG9FJqkq+z0u5MB+3XT+YxTVC+lRmvVhXIn63DKJAYVOONB/HWFsuVwX/C0dpmOvgcoi965oEjuBR0siantayrZDJKddMBMN5H3aEO+9lVahnT6t/4G8KMGGvWHylIahuSezb39sxKgzJeIB8wtxf23tiVl/M+tTFu0+MBC6pk3sRMm/GBQn8o2cW0jhmOUC/I6jOxDeSxeWj/dZGl1EwQ3lyeEmcpX8dEhrHm1PhqwkV7nH6yZmiEUeit40rzIJkdvx5xgCtjatO6KyMqTL1OTJFKT6KNoMzlv58fCVtCx7BAO00JpKaf+c7Yw2MYpVoq5hM8MhBeErNizEKts/sNgeDnITGFgVM5wGKQ4FWz/XgfLBBzzZnyFp/arUxEHDIwEmwzm+/QRudN5yZ4CzcxinzB5OYU6NRCEXJohoKY/JHbeD4WHAO0KMIOqdBmA+J2sLpuMekrVBLcYs+KqG1NwMR8zRxj2T3Uk+sJemi+ppNH6gd2JNyAJ2U+Tjj/fWe+kYAlVj4/Xou7JHKFeg1Aju3eKNEhLbnMQm33TNJatR3p4osHUBdQK3I/Ix/c/d1cRXj/v3Tcbty8FNcu2+IF3u3DUA7LLl5Y3DQSaeSyNnxWwjJtDlFmNan34FshjphGpKlhbR7piYdanNkdrdnGMjF3zx8LsXXei WtqVqkxQ e0JRmMwtZkwFmK+9EKCYLm/AdUqPtQLpbYpVa02ck6XjVoegF47Tro7paBhBBHPDqc6pefIc2qLInAq5pagd4gVyGWmUFHO1f92Klf0U07T/wyUgEjOl8la/eOilmLz9zlWP1mdQvfZhEqkrelgx0cMsJU13sTToQf3jTqWCiudGuOljNgW6+nj4i5pzR8qDB/Er2pnqKsVg7cEBS4P8QZae4XX91D6Eu0SmYpP+dg+LcWSmq0+fuxQHCOZ7BcsYyVZGzKEAd50Q9I4Ulng9aNUZPXFpHfRkm3naykWSPvg3HBUyiUmTvhOfdPewH8FWdz0w9cZ+0ah1aXiYJFcoMEFLMaUr6lnYeOuOmLjFa9NOMMVDf8sL7VG8hsQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 15, 2024 at 11:20:32AM +0200, Alice Ryhl wrote: > On Thu, Aug 15, 2024 at 4:52 AM Danilo Krummrich wrote: > > > > On Wed, Aug 14, 2024 at 12:32:15PM -0700, Boqun Feng wrote: > > > Hi Danilo, > > > > > > I'm trying to put your series on rust-dev, but I hit a few conflicts due > > > to the conflict with `Box::drop_contents`, which has been in rust-dev > > > for a while. And the conflict is not that trivial for me to resolve. > > > So just a head-up, that's a requirement for me to put it on rust-dev for > > > more tests from my end ;-) > > > > I rebased everything and you can fetch them from [1]. > > > > I resolved the following conflicts: > > > > - for `Box`, implement > > - `drop_contents` > > - `manually_drop_contents` [2] > > Not sure I like this name. It sounds like something that runs the > destructor, but it does the exact opposite. I thought it kinda makes sense, since it's analogous to `ManuallyDrop::new`. What about `Box::forget_contents` instead? > > > - ``move_out` [2] > > - `BorrowedMut` for `ForeignOwnable` for `Box` and `Pin>` > > - `InPlaceWrite` and updated `InPlaceInit` > > - for `RBTreeNode`, make use of `Box::move_out` to replace the original > > implementation partially moving out of `Box` > > > > @Alice: Please have a look at the changes for `RBTreeNode`. Maybe it's also > > worth having them in a separate patch. > > RBTree changes LGTM. > > Alice >