From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8CDEC3DA7F for ; Thu, 15 Aug 2024 04:59:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBC2E6B007B; Thu, 15 Aug 2024 00:59:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6B5E6B0082; Thu, 15 Aug 2024 00:59:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5A606B0083; Thu, 15 Aug 2024 00:59:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B87526B007B for ; Thu, 15 Aug 2024 00:59:14 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2FEFFA12E4 for ; Thu, 15 Aug 2024 04:59:14 +0000 (UTC) X-FDA: 82453275828.27.A12C061 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 8714580017 for ; Thu, 15 Aug 2024 04:59:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="2oZjKt8/"; spf=none (imf30.hostedemail.com: domain of BATV+b03a3d9ca89c7da11e41+7662+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b03a3d9ca89c7da11e41+7662+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723697878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I9YsIjUPg7mWLOLjxqUqjobvMzYvNQqbEzmIlrvU5xY=; b=x6rpve5/Tddo9SG1V4VCLjQllNLs/6H4jkvU+d4jVuKvrK9o0V9zvfDk5qJZX5ILlDk/xw NACvxXruIqr7pvnpW2CeIeQvTmB3fopomqWyS+EeDK4jj1rWy6ORcEpNivCEmtsbXdvRvj AhVKs0dNKAMTFjngPzefzkxEeCCppjI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723697878; a=rsa-sha256; cv=none; b=gL5OU/i+cxlIcRlgeYM1GMJliDof8gUpEb2gIYR3B3P9sMWWjz/JRxFJlpk+Cit6afy5Jz Tg0GOTAb41UuK4wnMbX8c7ifORVOuZIO821BVBXhud71OVakO2gG1EndBq1LOSlci86YX/ /Ax10DSJs1oiiFGV9Wd4D+bCz/1XjdY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="2oZjKt8/"; spf=none (imf30.hostedemail.com: domain of BATV+b03a3d9ca89c7da11e41+7662+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b03a3d9ca89c7da11e41+7662+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=I9YsIjUPg7mWLOLjxqUqjobvMzYvNQqbEzmIlrvU5xY=; b=2oZjKt8/RNYe3lteggYoumClez fnGAeFrqokx2z/1zNvo6AhBYwcLE/pMgtMSi5cx1gzyKkQV9odZOBpXKBIlHq34NQl91Fnw5J/F4P kZ2ncn3dNhv9ZDXlsXWEnijseWqFP+MwfmLLwI6mhG69pLzXx/WGxRJNbztuQoLrJPwStnv0D9/vS +Tv/0GUOOPsxnZEWQPNNsD3Z8R9R1fIVWOCV2QMzIZei00yJiTopt0EaP4Qvbbp8QwkjxzAcd/d4w imzPosUXNcsVydAFehS21CUM+IVSk+KnsjqOk/OA4kt8kQg/5LPTfJQl9ZeO/3+CmUn1Qa36UH5oW sElEeA8A==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1seSZn-000000091dB-0wSh; Thu, 15 Aug 2024 04:59:07 +0000 Date: Wed, 14 Aug 2024 21:59:07 -0700 From: Christoph Hellwig To: Mary Strodl Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, lee@kernel.org, andi.shyti@kernel.org, linux-i2c@vger.kernel.org, s.hauer@pengutronix.de, christian.gmeiner@gmail.com, Thomas Gleixner , x86@kernel.org Subject: Re: [PATCH v4 1/2] x86: Add basic support for the Congatec CGEB BIOS interface Message-ID: References: <20240814184731.1310988-1-mstrodl@csh.rit.edu> <20240814184731.1310988-2-mstrodl@csh.rit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240814184731.1310988-2-mstrodl@csh.rit.edu> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8714580017 X-Stat-Signature: k43sk6z6pih6gu474moie8swmp6zcsp7 X-HE-Tag: 1723697950-5097 X-HE-Meta: U2FsdGVkX1+ac/39Csbx/NRZtvZcrEqluU/EZbiPmJcSxUeq0At7+E6XaUhsQu0Xd1p3KeyL22ZEGflQwU0yrnVli5YamQADyDvVh1pXv7q6SEOgC6OVqUZtaS4SRscVdRqxBvgdEfnPsZGmyJl3HTJ635fXk8hshXBiCyoN0+k9m7RbQTn2g3wV1HYWWjDT8ytDGUa2kFi8atIdXJup6MsOMX03QspTzLhLqrIVoFgirxEX90yGCyiT21dEJb9nxC3IVr21iqNNEC3SVMgxBiCwnYlepyLgbCAaFLbha02qs7h5tdQHUXNzg4dCNxevnbyLKeQAmuqCqiCRndF+qT+Re5D9Z34bVNOVoH3p++gIUoAAZ8dQfSmraM1gHXpRSMfV7d++FlKrb/EBdGRjtqnZsnoTOeO87KmS8aXgQzlSRNF7b8mDBh5mLlYBxZnAMRPs3z1lCzO5X83pvPmw4U2V81gr1InAoghkCB8qDSJbmmKNYMBJOL2dAnB8GWsKh8GO14DmBQeS97Oj7D7cgzxDAikvhwDQZhMuzWpEkCpd4v+rKiQIXI7ms0Y7Kivxr69dmp4O5WWvIW8CX0eu2I6Xd1zDEbfXnqOq6hYOlHANty4iya+htHmzzGCS2AjwbiqbcCIgxPi11BrI6IpHf9JLPzHHDPhRU7Hsu66BcIiWJokz0CWuG2+e2zt+wi+WPK5u4hoN/BEn3mgnSxlHXqlJt2g6DTlL+XoDlS7lyKlrXqtd88uEQkN07O668ZCy/6djfBachO/1HGCNsx5+kEBV8juX+uVwfQyF4JaagrnV7Mw/UrlE8CE7qDMYFYp9Xeyt2bmlhb4m7DMgApLABYsvbvXrraFSjccng8q+PXeCXjap8cbCY06tDGGnGJexBYUFgWNdW7onujMjgcyf2kGUFuBMaIkiyCz/JWEaMG75+6jZHY2hBqPAbrYL5e0kGGyKmbQ9yJsoL428aQd ICifTNBa 2h7+CtvLTIi4uGqbYxc1k4YlXCWObkEl44oU1P+1QQazSJLOGpQOTgHQnN41jpcLl5SuXdmjq/sRmuqJI6i9whUnp0IIjyMNhtQCcLz8R6kDEugRwnBe7jx0SvoXXi/ZjAOWyPiinP1RpJPMccJ4jsOPtZQVZSP1vEAirzVHRLBmlLYDnaIGeIV9h528xldIpGxJVXljh6Kzt80i0SuPpOei3Ot2tIl4CFQ4/ghWosz7JseNCQfiC2QyIkJadhCqH1Cv+8A23/fgv8PO7e5PisoyZh5jgUY14w+XrOORPjtITEZC+vWcY2qnys4U1PFdRApWFkvVS/k3fKmw6wMAK0YX8m7qT2b/IFnFnKrEiEcVE0q/YCnkKUX9a3tgZz6wE8H1AlR0eywniO/mer/+ssb6TeblDGvcRYPWH8sM05fEfvEQL3t7yp0Gt/VXluciGLacqGsosC97RQf9jCmfxt0HmVl/JNxVLxBieAH/DLom+UkEQ3QFgB9pN8bHDu3DmgV98MIrpySzcxqtRN4Yngu4H/I8801AUyraHjVpnqSZbfmI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 02:47:30PM -0400, Mary Strodl wrote: > The Congatec CGEB is a BIOS interface found on some Congatec x86 > modules. It provides access to on board peripherals like I2C busses > and watchdogs. This driver contains the basic support for accessing > the CGEB interface and registers the child devices. A very short description for very unusual code that copies exectutable code from the the BIOS. You'd really want to extend on all that here in detail and explain how it is supposed to work and is safe.