From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC45C3DA7F for ; Thu, 15 Aug 2024 05:02:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82FD66B0082; Thu, 15 Aug 2024 01:02:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DE986B0083; Thu, 15 Aug 2024 01:02:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CD1D6B0085; Thu, 15 Aug 2024 01:02:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 55E916B0082 for ; Thu, 15 Aug 2024 01:02:47 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CAB211612E3 for ; Thu, 15 Aug 2024 05:02:46 +0000 (UTC) X-FDA: 82453284732.21.85506F4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 15ADE4000A for ; Thu, 15 Aug 2024 05:02:44 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=LTST7chL; spf=none (imf27.hostedemail.com: domain of BATV+b03a3d9ca89c7da11e41+7662+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b03a3d9ca89c7da11e41+7662+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723698092; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2W5XBTTcn/I+V3oQ5FiJK9Bnvhu/WhbWQrogDVbs2cY=; b=HVD/uCNuwmCFy4Y1TbpXsIS3C+H6pgibl3xE3s75l2hDYd5rismkBFT8ou2gDD87X+pGhp R6RPc978hU/fhkUchI1q8xvISOIJrFEgyUkHX+AMmbJ7ufpQUKMxRupi7k2QI2bu7UNp2D qAEjEUIOaUWnjX0Qpx/aNQ3f0VRvgTg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723698092; a=rsa-sha256; cv=none; b=0xyZ9u9divCrkB9mjTs5Bus/hAtf00MTqP+mI18t2TN71SSLyCRhEsO5DfNxthdCqLv8sh BeInNiG9uDClzZQOdfqzvqW2tqmT2SC1CqZ232yUs50K9c/Wp+7ARIRgWHK026rjDSRogu auTrHQdBAFAeFyDdHpN+aG2hiixly5U= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=LTST7chL; spf=none (imf27.hostedemail.com: domain of BATV+b03a3d9ca89c7da11e41+7662+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b03a3d9ca89c7da11e41+7662+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2W5XBTTcn/I+V3oQ5FiJK9Bnvhu/WhbWQrogDVbs2cY=; b=LTST7chLP1ATK0E4FQjjad272f g16xPEzQ7w2Y/kztiKO3xl1FuY9NpZWYbSqHBG/eh1yh3jJxbOM8ApZr4URmneDoKQoPYsd985fzr WfP7LxkLgeSF0PARE1D55KvfTD6IiChF5bYmEbhKoXvmJzsmYbIOfac7I3Q+R9GeChngmX3ZiN/4x MwegQ8Sy6BDKbI7aocmbKrH7oW1rwHnx1uvcz/PkgRlRebxyPJFT7K7/IcRjXZkIzp1Q4OJwBJm+g MB83s094F11jYzqi1jnCnrKgkt1tOB86q65R8LMjnlCG6n31rQed8jp6j4WSCLK2Pm0kz1eWwwiqA 4O0xbnjA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1seSdE-000000091xw-31ne; Thu, 15 Aug 2024 05:02:40 +0000 Date: Wed, 14 Aug 2024 22:02:40 -0700 From: Christoph Hellwig To: Thomas Gleixner Cc: Christoph Hellwig , Alistair Popple , Max Ramanouski , x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org Subject: Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap() Message-ID: References: <20240812203538.82548-1-max8rr8@gmail.com> <878qwzpfbi.ffs@tglx> <87le0zmhdp.fsf@nvdebian.thelocal> <87wmkjnqi4.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wmkjnqi4.ffs@tglx> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 15ADE4000A X-Stat-Signature: xc8s64e9m7xg9uejk8j7reza3ogeu4q5 X-HE-Tag: 1723698164-257040 X-HE-Meta: U2FsdGVkX1+h2bT8p6gzesmZV7ByLH9Xed4gpcWAD5NBPWPu9/cu8X7ImrolXZlTClkvq6XSTGfI6iLuvUdSrthOIMSZ4jPG1XW3g2plUoiSNPgHqOfcvt4NsxWAQrilqJgZUwPLCH8tg6lQDnSYVtGNYFv3i/Bb5nCrpkfM/biz5OZEquJB2MtgrE3SeVJgDypDnmOda/3s4WURzGGgY+HLRnjXgBhdc0imEp/B7LLs1ITucHVk+EJcmj81g9tXQZBrknYQGsmyBbbapJikoeDaGZrw4jqWgRdDLH/pKVpTpu4WRCe6Y9HB0YZZ5pmdwQdg9JR2si2tS30AI03feo/El+lWO/WIWjh2AEaoZ+3OWhmK+K7IXlTfR0RHbruy95pO8sijPVNJHI62AkUhcRZwgWuYvKlzpiMrHrL5CwSMnJYdHBPeMNUR286e5sZOWRTIGespZCgfEjokz9IiiykgCUbvHKg/vm48EoO32w1lV954LC5tEMAS6wbvTEkeN6xt7sddOiZU74NBTvChviwtlKKx5igjTJV6vJ5K6TTLiB8ElRjPWujO3dmsKF9aq+5ZAOYML9ePqsV613DJg4mbxbyoUtewHnRDXfxRiCP8nQB4aKEIEHHIlnh3YSdjJvhM9hRz+yJJqeIi2oMRNTEBR47DbA8/rpse8jiItVops6H8LTA5ohavK3+MfqvRID6VNbcMQ4sBx0Elf3931h4RfelqpoND1sTO/WEVDKoZThOdsbLs+FBNWZck+Zgfzwctgf3fiZmQiYTQ4tJ2Bbep/p1AMwprgvTdcKrnnya1KFzQsGNngkDEdiZp+YOQwbXRPaBYoI3GuMc8G6sSBTGOdIet31UbQQrZ0vcEuzKJhM/9lF4TQMH4KMZnLmGN8JRqX0ATK2PQHd2uqi4tSFo2zXZrqVzvjj9NDLccuT57N8KFYrp6WRdjzyefgH3vWwoF9cepSJTLvsLLDMm fSs9thCB foPj/6lcYclCI9g4h6uTJKMIcg3iRrYGf+YafJCbtCOmviVdxEofkis2S/sL/pA27RjR4jZ8H1o7z2NaHlU7dTztK/y0HTa0WjEIn1KKpdvwFCWn1XGEKr9K1dZoVQz21QujNxXOHnzFTNnr/gphJAiSaOZ1zTYi/WeHl22dMEvGXT4qUdkCRaxhcjSxZhqJChMMHh6eRDQjkUCNEASZRX2EsTMDjX0qHGS2gEaGi2cSUWC0kWpcvvlSnnvsHUmxZIHCroafbyov6quKVaesJeC0rfQ7Ow2OdZZlmS5AblDU0hvlfyw0xOpSO4LSK5FlIh82kjoexSPHitRPrmApuhtEuuk85073js+1alhuCbVgMFMlGrZ08BgAeKA8+4q9lHvq/82GtYb/kVQxvlhMuOh5MNiNIwJ4pCDLlJIDpF3dpXulIhLn599tL3OUpA7N0lp9loSxE6dzYOn/kmDezlPhytyJgHsLgG0+NJaQCYNoH7IqczYLehLu7l9q26t/SCpxV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 04:11:31PM +0200, Thomas Gleixner wrote: > > Various architectures had either an early ioremap variant that got > > silently ignored here, or magic carveout that don't get remapped at all. > > None of this should currently apply to x86, though. > > So I'm inclined to have: > > if (WARN_ON_ONCE(is_ioremap_addr(addr))) > return; > > in the x86 variant then. And we should do the same for the generic code eventually after accounting for all exceptions. Those should these days mostly be handled before hand and have explicit address ranges as well, but it'll need some time to figure all that out.