From: Christoph Hellwig <hch@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Alistair Popple <apopple@nvidia.com>,
Max Ramanouski <max8rr8@gmail.com>,
x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, linux-kernel@vger.kernel.org,
jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org
Subject: Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap()
Date: Wed, 14 Aug 2024 22:02:40 -0700 [thread overview]
Message-ID: <Zr2L8PUglYWzFTic@infradead.org> (raw)
In-Reply-To: <87wmkjnqi4.ffs@tglx>
On Wed, Aug 14, 2024 at 04:11:31PM +0200, Thomas Gleixner wrote:
> > Various architectures had either an early ioremap variant that got
> > silently ignored here, or magic carveout that don't get remapped at all.
> > None of this should currently apply to x86, though.
>
> So I'm inclined to have:
>
> if (WARN_ON_ONCE(is_ioremap_addr(addr)))
> return;
>
> in the x86 variant then.
And we should do the same for the generic code eventually after
accounting for all exceptions. Those should these days mostly be
handled before hand and have explicit address ranges as well, but it'll
need some time to figure all that out.
next prev parent reply other threads:[~2024-08-15 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 20:35 Max Ramanouski
2024-08-12 21:13 ` Thomas Gleixner
2024-08-14 4:28 ` Christoph Hellwig
2024-08-14 10:30 ` Thomas Gleixner
2024-08-14 12:08 ` Alistair Popple
2024-08-14 12:16 ` Christoph Hellwig
2024-08-14 14:11 ` Thomas Gleixner
2024-08-15 5:02 ` Christoph Hellwig [this message]
2024-08-15 13:41 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr2L8PUglYWzFTic@infradead.org \
--to=hch@infradead.org \
--cc=apopple@nvidia.com \
--cc=dave.hansen@linux.intel.com \
--cc=jhubbard@nvidia.com \
--cc=jniethe@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=max8rr8@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox