From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC93C531DC for ; Thu, 15 Aug 2024 02:52:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 953B26B007B; Wed, 14 Aug 2024 22:52:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DB906B0082; Wed, 14 Aug 2024 22:52:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77BEA6B0083; Wed, 14 Aug 2024 22:52:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 596FC6B007B for ; Wed, 14 Aug 2024 22:52:53 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D3198A10CC for ; Thu, 15 Aug 2024 02:52:52 +0000 (UTC) X-FDA: 82452957384.14.4F1D867 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 21E761C0004 for ; Thu, 15 Aug 2024 02:52:50 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=g4sEqKBr; spf=pass (imf21.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723690298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T7pBVuAQVcwfS0XIB9jCID0H/2+68PUfROylZhIb0SI=; b=4o+z+Y9Rb2b//cYy1qiQcBuH8dC+xOKBuJAbcZ0NC6fRP22/g0SbrxTUuWR7Ijqw6ImkEn XeZHWLm/2OEYW16Xmzc717zrZ1L8YDcu1kfHD3+IOd8KNsqC/IRbyiUQ4QeI0DR6tOGDiZ 1CWeJkLNAY2bsoJkKl+6PBDpXJQCtjU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723690298; a=rsa-sha256; cv=none; b=U+GVlkES4gr2MDKl8QUDHAT34t8UCDoKGARyF0vm8+JVx7osVgCKtF2AMcHTRqehZf+aqu nxkFQ5xOrJ5yIqDObq4LiMbm1FR6uiiQDyI0g/r2RXph+Px6mm8LLgxJpi6NbkN4ONSm4S ybhIqj4tgKcGdTRqn+1vkIssn+qLrm4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=g4sEqKBr; spf=pass (imf21.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0213A61D59; Thu, 15 Aug 2024 02:52:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05297C116B1; Thu, 15 Aug 2024 02:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723690369; bh=9lHi4Fn05Fqn+UhryIcKZ35IIPLC/wPvR9F2k2Ns8cM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g4sEqKBrmnWlBt8i+NAmFnBQMJb+TClGPq40kRq6aEOzy237abhszxAqG4/VQ+F/j ii94cDngj1RVzVnol55shUXUhi4xiYB/b1vEjG4xcqkLbZvRBnmgMjzc61Sf4CIlwO fg7l5at6aBTJ5pp4jaPmy9kdi0Pk78YH6RU7M58fk61jA1o4RmmHx/XmeXJZDOHNuX nStvf4Lpj9ESgk9bDUnXXKMgXQz6IaEU3pqrv3G1kY0f95DvAbQPqjlfXuqd2QXPGr m4TBkP5QZoDInMNeIWSZLC8YLyZdxPUdWUbg34znsyQjGncYMklpZ8d1bHDlfvUz44 S05Ge/Pu47omg== Date: Thu, 15 Aug 2024 04:52:42 +0200 From: Danilo Krummrich To: Boqun Feng Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 00/26] Generic `Allocator` support for Rust Message-ID: References: <20240812182355.11641-1-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 21E761C0004 X-Stat-Signature: 7fqrkeg1s6q67t9dsfrcjyqiujiobx6s X-HE-Tag: 1723690370-747819 X-HE-Meta: U2FsdGVkX19doxDRpmQHc+iglANeIap53Ead4UtsBbL/dg5je79H2I/9SocyXbSuO04PEILpGMFt09HlsRztmZ7dcP40cUAjw0wVVA8qMNcye0dt5KTycvIUzF/kB9BydIlJW3z0hEqHViLGzS0oMzYm1ij6kcK8xQ41wktKiuOCygiXQAzt5qUac2hypM4I3CJWXk0DRZuB0bQmnyrnW/Z13RjlLgXSpGdHtyD7kVpYotGTmUjwvR9oijYNubYKb+hCS0SSHpdHPF8Sh1LWFnuCYGLU95FrrIPj80KSIAbUBVQM84YhfWUTWt0EeH42p/v9u56V7PMo9L9f04bnWciFe/QCSTywE9x9071O8iIlnqS7U+ZN4CBLaawZTezs7fINiQig7EABUUeWTKVZhERdZjul5Mm/8UTX+QwW1MAHigGi1q/ENX2nB7c8vwGp6vJ2LU6X1WnCjwk4UmgW7Yhp5Z2Hm77iinM0Y2PXat2i5lkiNZnfHtJNyZwox9tJB+n3Gahu5VKAOd3lyedo+1Go0eplUTFoe5cN+10ne1nTeWKee/VIdqVpvrrnly02nVIhNzWK3GWEBpedamdzdU/BtzvfRqQZXds3Ms8Q9W9eginVm+ZM4+u/OPYtmwH4BcK0WFPIka4j27FkXjKMu90O/vDDI9xUcAnc+6X00bmrvKTVmLyCLyiiacDTTr1ARyOj3aqlMUyGGsLvfI3lwYGJ2twDi0+LK3fzLjiMS69goTD9JyQ+8lBE1KHScLWZpZsF7BMSitSyERjNW6s/BJk+J/BWdwibQVThHKQFJKi9EOAyOItWEXOrOrcVxe2NRUR30NoNuAAGpjO1GqQNY81MqlL66rjADBzo/o5gP6BWXQGiBlTfPSOOTwuHy44ZFcER8of+ttq9a3k4wnzlakhHmphHsMwf6CA0b2HDnGm90NjrrHmox17lTlsoFphHHxcn2fbYXgWmDD18B5D y9MgtnD8 okxb3MfrpILxrYbt+6aTVwpQCEFV2k6jcdQqkaGgKS/Bn8SVHX9ZHf0dLNrJnKftSJXlIFsuUwJowxlmVK3by1bi8TGV6dDB2ic6FFwouNOVPMSKwaMNxSKGT3SGNyS9xZ/c/rk5UZiq/8d8LrqElvWntXaHz0lDqRSwCNBV8JX3me3K0+5V/uwBRhRaElcHRCg84x0wllcgnhfGKxhYHZQeawQh4HkD7na53x1C8tkSfUXJf0nWIqDLydl3+bLZz85r/nHcCdQhPAvAzRDURAXdM3/6uS8ShZSBhdkhwTQfm0Mw73CIgxcxzwoyKCMc/FwtbIALznf0iDQYedWYf38ZjnG9tOm/mWnXM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 12:32:15PM -0700, Boqun Feng wrote: > Hi Danilo, > > I'm trying to put your series on rust-dev, but I hit a few conflicts due > to the conflict with `Box::drop_contents`, which has been in rust-dev > for a while. And the conflict is not that trivial for me to resolve. > So just a head-up, that's a requirement for me to put it on rust-dev for > more tests from my end ;-) I rebased everything and you can fetch them from [1]. I resolved the following conflicts: - for `Box`, implement - `drop_contents` - `manually_drop_contents` [2] - ``move_out` [2] - `BorrowedMut` for `ForeignOwnable` for `Box` and `Pin>` - `InPlaceWrite` and updated `InPlaceInit` - for `RBTreeNode`, make use of `Box::move_out` to replace the original implementation partially moving out of `Box` @Alice: Please have a look at the changes for `RBTreeNode`. Maybe it's also worth having them in a separate patch. - Danilo [1] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/log/?h=rust-dev/mm [2] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/commit/?h=rust-dev/mm&id=ef80ccca2ccebf3c7bcafdc13d1bfe81341cbe63 [3] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/diff/rust/kernel/rbtree.rs?h=rust-dev/mm&id=c361d66df7fb7760064fbca6bf9d72171c352a73 > > Regards, > Boqun