From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B9FC3DA4A for ; Fri, 16 Aug 2024 18:16:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E5746B02CA; Fri, 16 Aug 2024 14:16:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16E026B02CB; Fri, 16 Aug 2024 14:16:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00F096B02CC; Fri, 16 Aug 2024 14:16:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D5DEE6B02CA for ; Fri, 16 Aug 2024 14:16:12 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 878C71401E9 for ; Fri, 16 Aug 2024 18:16:12 +0000 (UTC) X-FDA: 82458912984.29.3DCAF36 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 2CE7B4002F for ; Fri, 16 Aug 2024 18:16:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UnMJYcnr; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723832157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k4GNUDgq1rdKwWJZPQjg2jXsjDkBJpVO6LjrpxDhD2E=; b=eXqC81qv5SHMg0gaZ23p4G5G9ijZ9xlDL0+WRkxB7uamGDwm76eyw0CpmMHsv1mYiVwLuc MwVX45DodO+G7hdq2TODQlVAYA3IjH+7htaBUd02TFlTp1kp6E+4UE67EtisZCXzbhdTVB bB4bgoa52Lwwq8HLoN5z4u0n9yS+wfk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UnMJYcnr; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723832157; a=rsa-sha256; cv=none; b=t/N72FknZ1WNP9gPmD/FrOnnNTiwapHH4CXorRFaqaIVoyLJ7ekHUbNXrRPvwG43N9+pBJ 8NqAIvyxVJF+armoi6S8GpAkKoxUhCOhIgVvV2wod20D2wkOJvJjh0LfzuVncEaEIB+dKp XV7k45OECdpural2jxGK3DraItjcyn0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k4GNUDgq1rdKwWJZPQjg2jXsjDkBJpVO6LjrpxDhD2E=; b=UnMJYcnrEmeNJjC1MJFMZo79Tc ITF5CxuT2bnaoEAqV3adHHQp4LoLGcZTA2yNUq2MmjrkEQogqOrPd/B2gDO5zxN0zsygfJKXYDJhc TDeWAGtDEg/NSoQS+rJnjQJBWlUyKQIR+HT2nsYp3zTBlW+aVT5cXqKaybsm3D8SlZI1BcyaAg5+O 0T60VFJ4f+o/jVCYfQwEiksImTBZOdqiPVAhrYcQ+NFjO/Y6W06cxba1WT8TR3QSuqDKgADaQtaMn Hxmo7c1rdVEKdUKiEg1emlWZXfkUgiDlDGfI2afKQkKzmy+G6oRYs+lXHhkDYOBP8Oz/HnIJZjstN QKOJz7CA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sf1UN-00000003w0J-0rr9; Fri, 16 Aug 2024 18:15:51 +0000 Date: Fri, 16 Aug 2024 19:15:50 +0100 From: Matthew Wilcox To: Nanyong Sun Cc: hughd@google.com, akpm@linux-foundation.org, david@redhat.com, ryan.roberts@arm.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, ioworker0@gmail.com, peterx@redhat.com, ziy@nvidia.com, wangkefeng.wang@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mm: control mthp per process/cgroup Message-ID: References: <20240816091327.54183-1-sunnanyong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240816091327.54183-1-sunnanyong@huawei.com> X-Rspam-User: X-Stat-Signature: a5ab9eq316unh38w89wp6r5op5sbbpzh X-Rspamd-Queue-Id: 2CE7B4002F X-Rspamd-Server: rspam11 X-HE-Tag: 1723832169-569498 X-HE-Meta: U2FsdGVkX1/nh5XuqLgwREXarDob0AxQcv02qD5e+tv2AeBMn4BsTsLGwZYPnyt1vUEk+KHJVtepJ34DjV+NvHGfnK6UsVTx1YwR2r/uAqdwnlCAKUdV1Vd1yxO67XlRxRleIO/COkO2/EVYNUOiRyWJGbceR/2tqDCCuazL053bqFd4WT3ul7XHN2sfDXFs5fzyAkS3lkQnTuJJ69o5keJR4VaAIc0ayafOWo83lVBOWiEpFDW6958Nrdq/I3cUYsCak28aRasxQJqDlWxsUjAVLXtTyjxnNqb2EXYcrZ0KPJK+b7Ll3+4W401dqXfbRdS6KlrPLlzA6YhDQ4FV2qvW/Cd65pr+JQZNV7HPFAsnGIpvK/JMY4Pxf8mVWu6mWFVl19CWQdo15WPsYRNxRwU2qi+QR0QIEmdbHAoeSoqObwlxlcr9p24N4AOSwULjPD5TLRE0lMQLCorHpyr5XfbtcbC3eqXYUBYaeNsJtt1MdS/ofU426JDEoOanMW3B5I4vekOzeoZ1bsqztIbmF/kCSw/zjc/4HlMUHgycblPoVq4xk3xdfxM2BW/Onr+MA4oSYT15vuV2YnA7KZbfgNU8dKOvplEdGZI6r9NgZai13aZ0HO8tNUwju7XiGu63wafYPH/Vlx7rxBi2mhFbVnXXTt49MXQBDlmeSiMSS0mjUDZBEqE435dw9zahvn9JISyfTT14p2u3EBxBwfhMPIdixRyUpa3hCXoTNW/02dMxLuldks+28yTQ2j62l4WkL040cnS6SzQvfJ9JtlZ/vcONdI5j+6TKvqa3v+GOzglgKkcFIh1VTjnAkPjqcjZ0SmcLBzvByWR1SyQ1lY7qPd4jVgcV8NovMVZWsaIKSrE8EM/agmtXcZk/sVLzECIq07IozXlb3+dHuMQGAd/VkrJxictCJGBBxk5h1QF3UyEq8Syd8WWdcNlos+9aefDRgfkPrWKXDAHecmM0ISi qB/0jKjI eJfR1rh0yLjSkbVg4MihndrbTkptZ/7QLI/jKUxH6TUPnszmBEtQ+NuBKZm7GMVTjKdxFDY1C69R+idZ4bXlinWJcIb1y3gh7Lr88KUQqsmBjMqjUm6MVDPXqoIHRlYHfYaF4NKmlHyj/Bh8Fdl6vpHph/NFA6acK2dUysLcGECRw5+TuGlFtPAx7cFXhZ1EiL/VzbJDuUEEXXIY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 05:13:27PM +0800, Nanyong Sun wrote: > Now the large folio control interfaces is system wide and tend to be > default on: file systems use large folio by default if supported, > mTHP is tend to default enable when boot [1]. > When large folio enabled, some workloads have performance benefit, > but some may not and some side effects can happen: the memory usage > may increase, direct reclaim maybe more frequently because of more > large order allocations, result in cpu usage also increases. We observed > this on a product environment which run nginx, the pgscan_direct count > increased a lot than before, can reach to 3000 times per second, and > disable file large folio can fix this. Can you share any details of your nginx workload that shows a regression? The heuristics for allocating large folios are completely untuned, so having data for a workload which performs better with small folios is very valuable.