From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B2BC3DA49 for ; Fri, 2 Aug 2024 08:06:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1505F6B0085; Fri, 2 Aug 2024 04:06:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1008A6B0088; Fri, 2 Aug 2024 04:06:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F09EB6B0089; Fri, 2 Aug 2024 04:06:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D1D2F6B0085 for ; Fri, 2 Aug 2024 04:06:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50173A10F4 for ; Fri, 2 Aug 2024 08:06:40 +0000 (UTC) X-FDA: 82406573760.28.B0B73B1 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf15.hostedemail.com (Postfix) with ESMTP id 63562A001B for ; Fri, 2 Aug 2024 08:06:38 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=irleXUhE; spf=pass (imf15.hostedemail.com: domain of elver@google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722585953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5MPJE7ezvPCHFVJoWU7UFGAwm++u4dc+Z2RK0PA0V7w=; b=EksNe22T7e4F9lE0oVWyFCBH4mFH/YrkNVby1lrL83sB9NctNFgUGpfRYwwQ4qP3yJKd9Q qgIjVHOoO+wqWbHOvqjoWNwOT2YkkfbyThdsThxa4Q19AoWDD9GYxqZ615eh9MPOtzNyDz 3+J8hS/BsydzqMhoPpyY1sV+Hmhz6EM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=irleXUhE; spf=pass (imf15.hostedemail.com: domain of elver@google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722585953; a=rsa-sha256; cv=none; b=U8THjqI0+nloHvz0LNlIqJ3xynGFxUOdfP5NZH4Y9bVx9U5d/kEXcU89IBwB9vcwg0wW6C ghx6BuF/ell2mFIDd4TpmPJUCaL1PDK/b/QAra0gvxOs6qZBPL5C6zs7AOAQ4rAUsJupzo cMqr7cTK8uU7UShy/Yrhl9ugG8QuAE4= Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-428243f928fso42474555e9.0 for ; Fri, 02 Aug 2024 01:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722585997; x=1723190797; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5MPJE7ezvPCHFVJoWU7UFGAwm++u4dc+Z2RK0PA0V7w=; b=irleXUhEhYRD1DFrUWaAlAHSyYkEEg3oEgz5Zf9kUf2LuT0Mo4NpeDIMIVu9iPpyLF A4pRhO0Hogv5nUDYmAKz79b78U5x/Lgmfl1lBDMmc5EydhXNcJMuA7pR5bAMjDWJmj8p Kn6Ngr6mVKAUpNx5PQmLjSU0ChQJQoE7LSC36d36t7rLpUrf2UABNxtLIdOybLz3zk4B Je3ArsYWXdjhiB6UkmD4N+j9N5mMObZNIGbADTfXn0jBS78KLRUjF9ctp3egPznmujXn fl3KJfajCWSfvBvmtmRY53viK958LlaFaBMtvffcxLX7bbDMGZ/IyEqB1e2tnUVoZlc6 0tJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722585997; x=1723190797; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5MPJE7ezvPCHFVJoWU7UFGAwm++u4dc+Z2RK0PA0V7w=; b=eICxXva3HAzHXqUNR+TRSPb1owyR5743oz7bEMUJADEp9MyWCHnNBDnpmmZ49cIEyW RX4dA8+KdTWR8+8En2FifA1rNIxSdS8tOe+nJwCefUCAYVphvMPXv4eGxY8fGdlrRrB7 p8U7INFw+a6vN57x7mnWsv4sOQ6lFuEEycGCwtjgI251RUVX3JcigwFb0iTb0if9NRZr swM7Iz0WjAx8sRFgGeARWXCRvoVs8FSkA7vKekN7CgnJtwjBFwqXkakZALWca4LekKq4 VJ6wIVA00vVdrycYpTaEqPZK0zLqCZFKEg77wqtOWf3CDXzMXUkKIAlezoNXCyWV1aZn KLZg== X-Forwarded-Encrypted: i=1; AJvYcCU5Kn/ae+n7WC5TvocnngUJFiwSyR80AbP/wLGxBIO+EHiqfOTX7/guYU0tmx1+LfbT4YvFwt66pcMLIz4k7/Hm4OY= X-Gm-Message-State: AOJu0Yzn/NOuMUQ0hYB3oEqHwycIqi0TYc/2MOb2gWI32G5kitohfnuK M34+DxOfvFLDOpGVRnnlX2QjnE1HunAIKHx6odcl69z2zdciIynrRejoyxHqyg== X-Google-Smtp-Source: AGHT+IE2r5i5jqlUiPhe41D1Hu14GbCiBTHqSiEMaIv/ubJ9Q/G0LSsrLG2AuQT408lpdC0qzPikxA== X-Received: by 2002:a05:600c:4588:b0:428:15b0:c8dd with SMTP id 5b1f17b1804b1-428e6b2f14emr22464585e9.20.1722585996403; Fri, 02 Aug 2024 01:06:36 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:9c:201:6639:aad1:e65e:e31a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428eabb660esm10591795e9.31.2024.08.02.01.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 01:06:35 -0700 (PDT) Date: Fri, 2 Aug 2024 10:06:30 +0200 From: Marco Elver To: Jann Horn Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 2/2] slub: Introduce CONFIG_SLUB_RCU_DEBUG Message-ID: References: <20240730-kasan-tsbrcu-v5-0-48d3cbdfccc5@google.com> <20240730-kasan-tsbrcu-v5-2-48d3cbdfccc5@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240730-kasan-tsbrcu-v5-2-48d3cbdfccc5@google.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Stat-Signature: 9oauwx3ffn3moaa7sbgiyc8a4gto5hc4 X-Rspam-User: X-Rspamd-Queue-Id: 63562A001B X-Rspamd-Server: rspam02 X-HE-Tag: 1722585998-984975 X-HE-Meta: U2FsdGVkX18oO0alecKfgpbo41kh0gDG4EBnKopdxbIK+9yadIac0JDNf3M7VWAZB2QxIngHlv8RqljhBn5DwbCT7ekkLmrH8EHXMtomUu8DrTK3dqT2yRX+mpXpCngexe2nqwWbPMXokeqvXG+CrSQuKgvjrEN6uHffbnrgZtywXNNOziLiRyj+sZPkmsdcv+kvnvQQSQf8XNN0R2COgFz0fluf/f0yGPw8eMtvs5WaZ3m6ofKdb8UTK6yzfNxVpUmHFKpVlCDVmzmbdPpXilaooPGZbxRTWp8oZsGIZmORX9YQKH6sI0ZFqIxPhrttfSUeKNupnECXkUaM1F5bTGmO8ppxYcakSdiFz0BhnezDMn+I6vaPQ6NjVEYlrLeF5pvBp2uLvkTJB1YErqAQcCcxYpLDfVn028J/zpp/ZUeuKw3Rl/8rn/mn7v0gPKPO6QjumimxAEKHKBc49CXXieTKTJ5Z0v9gLy6pxBK6iinPzyPx10HjsN0bPl5mQelPq4R06VfFesFoujL/4sdAuG1P65f17EkgcWwTKwJGklpCTzm25ig3W9WbW2V+8xE1sHmN9JXtu0rVfuqSBokFz92FN1BUL/IRaUYZC3eoS9cKqouq/rrujA66uOUdZkq5AS0Cxzu7cEHNy7TaCyUgl7x10kqWKbcSg52Zl9/tuLUM4HKGoHAduGYJQ1gdZA/AiC0HVH7o7MEem5TC9XEQyH+KgH4fvpil2eutdyJbuzDbgxmIAW3DtHoxKZDi05KBtT0Sit8yH+qPv1AgLijSWRgzzkevRzsuL5sR3IdSWOrLTsmjUwwPRMYfOs8UAwm1bseEjMsLXZ6pq/Jx2EKyg4q6YqAnG6zegf4P1dxZBZ6HEX0HTBKl7O/+GQ3akq3venna2Kd8KXRDCvrXMHXyVWxAapod1CvBi0dp69jy8f/zd6KAUPpRVVfnNl0BqkiL+Nz40yd8yUAG/lOvPTE H2wM6769 kUpykuTv+iB5jurP+ffWoL8OPbFEg8H/6/YXKDNA2E4iNn/cTK8+0XJjrUzeEN+uR8k3eBlDS+VC57XEhmQbpm7GwHJqIqoM+64i7UNcfvuBiq/kYKNrV8wW2tv5rH1lHo/F6/ctva2jbfcVFpUauFHAV+XeEGnoicnYZx+qECR/bGmID/P2OWttGUZvNVbRKIVFCoEsbvTuCG7zGYIAo2DRvD575XM01KuMQH7YfbIdnF52uyNCyHVYahPYcuWom7TnPIQwlq9oZ8RzZKEo2e4TZG+TeXTRvQECb2kY+tbtyLzkbq06fz7/dq2HKpgLlBdHh6fntrql2AlVg+7ZLnOHYbrKXmZimR4P6g8uVCoeXUEQ3EVqKM5b+jEkhhdThomplJ9+LZuS+Q4RQpHLaHgTeR7s6ePpz+wTfzufK9bfnQUFkwgrkH1N2seL9dPSKsP44l7RNLulmjFHtqZNxTGY7uZeu9bmc8jjQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 30, 2024 at 01:06PM +0200, Jann Horn wrote: [...] > +#ifdef CONFIG_SLUB_RCU_DEBUG > + if ((s->flags & SLAB_TYPESAFE_BY_RCU) && !after_rcu_delay) { > + struct rcu_delayed_free *delayed_free; > + > + delayed_free = kmalloc(sizeof(*delayed_free), GFP_NOWAIT); This may well be allocated by KFENCE. [...] > +#ifdef CONFIG_SLUB_RCU_DEBUG > +static void slab_free_after_rcu_debug(struct rcu_head *rcu_head) > +{ > + struct rcu_delayed_free *delayed_free = > + container_of(rcu_head, struct rcu_delayed_free, head); > + void *object = delayed_free->object; > + struct slab *slab = virt_to_slab(object); > + struct kmem_cache *s; > + > + if (WARN_ON(is_kfence_address(rcu_head))) > + return; syzbot found this warning to trigger (because see above comment): https://lore.kernel.org/all/00000000000052aa15061eaeb1fd@google.com/ Should this have been `is_kfence_address(object)`?