From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB116C3DA4A for ; Thu, 1 Aug 2024 17:57:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84EB96B007B; Thu, 1 Aug 2024 13:57:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FEC36B0082; Thu, 1 Aug 2024 13:57:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C7256B0083; Thu, 1 Aug 2024 13:57:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4C7A96B007B for ; Thu, 1 Aug 2024 13:57:56 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EE6EE120FAD for ; Thu, 1 Aug 2024 17:57:55 +0000 (UTC) X-FDA: 82404434910.15.8D7D92E Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf06.hostedemail.com (Postfix) with ESMTP id 22B84180025 for ; Thu, 1 Aug 2024 17:57:53 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tvpAFiMJ; spf=pass (imf06.hostedemail.com: domain of 3oMyrZgYKCCUTFBOKDHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--seanjc.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3oMyrZgYKCCUTFBOKDHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722535068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YZsjMORWNMLw4A5ZHbitxpDYHrl9my8e/hfGilOpgU0=; b=rH4cb3QVcp6JQmvFCUSF5ameh487A7iaJ5UiszOcL/aAt2VPgdwg5npolM2jUfcO6dsaYq pKO8dKWl31DHXeixNWJ7UrwPC75f8eQg3NLei32O2Z7m3xlQQizgvnCfoSSyUoN6EzJ2Y3 s5gIu2fYtQID3BidtTjj5eUkHIdHtgQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tvpAFiMJ; spf=pass (imf06.hostedemail.com: domain of 3oMyrZgYKCCUTFBOKDHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--seanjc.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3oMyrZgYKCCUTFBOKDHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722535068; a=rsa-sha256; cv=none; b=Hvxw1lQ2IJWf70vEqAlZ+qJ7EXvgyw2kD1nrTzT1dQLfbuhaJikqKKnz+XNf5Jo7RLuQYn fa/xrDQUqpiaho8CBTH1f8yijBv3SmDB2ld6pW+4Z3JXk19tKvecjPlVGK27TTgn8xs9fx OPt5AFudodkzobMxd8hiqIAGtvpw0+8= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2cb5847ff53so8764645a91.2 for ; Thu, 01 Aug 2024 10:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722535073; x=1723139873; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=YZsjMORWNMLw4A5ZHbitxpDYHrl9my8e/hfGilOpgU0=; b=tvpAFiMJuT9mV04U1MtWNKNms/66NW8aW75DzQypI+DdOesAwRa3dPrA8/loONqiuP TjrEaR87ZChZpwFkOWAtNf5pUumumk/rfUd76GP6qqGAYyCQdq5yhzIYMX9PtMMwHZyT tQLTAhnI1lrBkD9E6poWijpZcxj3t6ryJR1Q1e8OPtv9GF7qQz/ageP1zbrCjmDNnku+ 0Mb6FJdIFXUPk+8p31ZZz57KfMVTn7qoa8xzJu9++As5q6ymo4lRD6vK4KMKnr8RBFdl FZHnmskwbibxZVHJ+X3WEtxGMd7pAI2mNC0gKu8EbPtwYjkaMK8Zk4GnCs+J6eYQ8I62 CUzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722535073; x=1723139873; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YZsjMORWNMLw4A5ZHbitxpDYHrl9my8e/hfGilOpgU0=; b=pZm/SJIlt26A4RRvQptGjWMoT1+VtPVHKkYnbHqkd9fg2BI2J2P2dqJLvImye9khFt 692rIUkVM/F+Z3gOwL9ruDwrI1T1GhyAVJaxRGNQeC+Er2+QSrL6zABr4VrLQ5s17CU8 NxPdAZyVRFWjtN/ARJONa70M2xKLxRjLi4uL4260Z5CXnDdkUH0DOPB/rdPOZxpC68c5 F/uOuKzc0wDKk7ieqAZWuCtw4SZWWJsb1T1qDkxEW+bUmwW0ryxcTPV27eRu/T8FL3LF 5m/1Y+LH+K23o4/FNkl/qYIsalJVbc22PcaLh3ZTPgdppzySkEpFM7e4wXqxyEpVQF6M TvQw== X-Forwarded-Encrypted: i=1; AJvYcCUoXaW1zBD+1h99HBVW+SNGLOhrD5u7wmWN4Nf8WiByykfWeZDgDqzIQ+7fvdhZ6WIlbUaWAZOjzYHhW7SIHGm0R88= X-Gm-Message-State: AOJu0YwrMMHJorVwyjRi5E9bxD1WISR+z9iVxzgJz5G6L/2sjQ9eA+qa D/6hdvMqAveCXzEqHc7TjjHoICIGDdbpytN+F5sd5JI48KluhA3cDGmd58smnpZWKOVytyACcUo OpQ== X-Google-Smtp-Source: AGHT+IFR+iUgu+QKJU7dkP2vun0rHsyzYS+V01y7jiTTuZQWqm44psgY1ZYc8q2GM5amzUuj4CJmeyx9mEs= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90b:314a:b0:2cf:6730:9342 with SMTP id 98e67ed59e1d1-2cff93d3415mr54282a91.1.1722535072537; Thu, 01 Aug 2024 10:57:52 -0700 (PDT) Date: Thu, 1 Aug 2024 10:57:51 -0700 In-Reply-To: <20240801173955.1975034-1-ackerleytng@google.com> Mime-Version: 1.0 References: <20240501085210.2213060-3-michael.roth@amd.com> <20240801173955.1975034-1-ackerleytng@google.com> Message-ID: Subject: Re: [PATCH] Fixes: f32fb32820b1 ("KVM: x86: Add hook for determining max NPT mapping level") From: Sean Christopherson To: Ackerley Tng Cc: michael.roth@amd.com, ak@linux.intel.com, alpergun@google.com, ardb@kernel.org, ashish.kalra@amd.com, bp@alien8.de, dave.hansen@linux.intel.com, dovmurik@linux.ibm.com, hpa@zytor.com, jarkko@kernel.org, jmattson@google.com, vannapurve@google.com, erdemaktas@google.com, jroedel@suse.de, kirill@shutemov.name, kvm@vger.kernel.org, liam.merwick@oracle.com, linux-coco@lists.linux.dev, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mingo@redhat.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, pbonzini@redhat.com, peterz@infradead.org, pgonda@google.com, rientjes@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, slp@redhat.com, srinivas.pandruvada@linux.intel.com, tglx@linutronix.de, thomas.lendacky@amd.com, tobin@ibm.com, tony.luck@intel.com, vbabka@suse.cz, vkuznets@redhat.com, x86@kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Stat-Signature: dh8fs59tmn5s47z4yfcw4sho1ou6pwpp X-Rspamd-Queue-Id: 22B84180025 X-Rspamd-Server: rspam11 X-HE-Tag: 1722535073-63262 X-HE-Meta: U2FsdGVkX1/9TPPXPKcLJ/5WksRFJNQd/Z/MImXnJX6oK1KuHI7kDVBO7F0YcaMIFJAwXuOIpuVo2Gjkie5RJN2wDA7YkjzUdDp6ahJzBiHMRAsoP0esnZOJk59ESQ96rNo99GBYZ4fA3o0U/Aw0yYlx8wrawDFjxL2mX4ttOsu8vu6SPxGbJP2JWC8JCHVDBAWVuXOAZYLOR8qUpV47oS8PdzMRsAyuWtjjP9ya5e35O7blKFl21hPbCEBz+18mdDDcJmeRcQeYuTh75VxYlk/ICPF1JvsrV9Mpi0C/Xck7nsdiym+qnGllziFthcXGpdylaYIOEYxInaNXFmCT1zPEjMmxTS9nAVqR+8SUxRwNLUkj11cp5taCzHlTlg5+XeUQS+lOd703eIb4uMQlmRp+9rhStr5fEvNJRYc88kDkH8c9Y9LqP8ICHA809U3UfvhOW8b3qJZo4XNGdYqt2Z3PP/e2p7en2THKJDfeSOSsoo2a3IymT9V+3gBACAKOh4P1+GO6p9Ike/LwU/StSUk00KGEsL3qDRyRN2A49U/PxDRNV4bwpc0/g5ORfFkkf4zCmr9s/zV3GecYSqZoV8Pgmg59tEUTXYS/wKeSYoDNUvSeWKwURApFu96TD3uZLOtkPSb/LeoorGwRrmjs/5Voy7MKDSNea4bB7/kPA2YhGq77NQkLVnTiJjmWi3zj3F6ce1dHuBZujCdFcyhD/thEpI7DQ+73852WF9nd9WTz9JnirFwc6bDVTaOFo6LvX3Lg7rDX0KcwR4xEzwmOzpbU2bYMTx0KAc7yIMx23IYSCiWhlnktEJmPUe9V1wjmzuBnvMMlJYgSZ+CLCgEMQpabKXsmOjR41do3jqVOOhVTss2Grv31nbatgyolioqV6OfQa9CWprSwj/DO+NjHVuF8m8GDiMFJFbUkdw4JBI0C4ENdqYFftfwSo6iGFuA+QfOjfek2RsZZzSF3TM8 +7L/GIj/ ZQWcawXqut4W48StyOsXV6vrYZFCb/aYy2vhZnYvpPX+EMiV18CWbj0mcCh6fYn9L/mb8rZa+R1Eco9uDlbhG1q8NjZPhrNanoH2poklumt7Ok6N0CsQjHBlYTxMhFa8MCqO60cISmvELaplbIvErcFrGQdH7Tw9ahJmqrMnUZTprjo4kp9cgRfmJY8sNq7PMRtq1MmJ5itIHlBdZDOs/ohYpkhesb7peOyWYk47oAeDODtBTQyRRwGDi/KgJXUQBOdD0n0HWsAvNAOsoUvm+8adQjDzPTPG2Hs00q0JTxrUDGJCo8KXxj9RObKtRKOInxAEwBPWJn128gYVJdplm4uINkuukZfe1mgDVbewB2arnv0gU++osQPA4EuvuOm2Ae36Pq/8dVP9UiwT8/IIWBjfvVbebtqF9WKfV2m3txWfW6U4DosAPXVqtrWMd0yJQvVmIl1aqiAT6FZKkve1QIigbbAMvDAvbqonxikKsCqjquSkiDajGz5s2FZVUlMvT8NYNDQSU/WHac6DM3bjGOflEWJYyBc3/E76YcyqPr1RQvSI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.009363, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 01, 2024, Ackerley Tng wrote: > The `if (req_max_level)` test was meant ignore req_max_level if > PG_LEVEL_NONE was returned. Hence, this function should return > max_level instead of the ignored req_max_level. > Fixes: ? > Signed-off-by: Ackerley Tng > Change-Id: I403898aacc379ed98ba5caa41c9f1c52f277adc2 Bad gerrit, bad!