From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E230C3DA64 for ; Wed, 31 Jul 2024 16:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC0EB6B0082; Wed, 31 Jul 2024 12:04:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E73046B0083; Wed, 31 Jul 2024 12:04:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D11826B0085; Wed, 31 Jul 2024 12:04:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ADFAF6B0082 for ; Wed, 31 Jul 2024 12:04:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 55A90A44A8 for ; Wed, 31 Jul 2024 16:04:15 +0000 (UTC) X-FDA: 82400519670.23.3592BD0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id 0500940032 for ; Wed, 31 Jul 2024 16:04:12 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oJcjR3VS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pXywWQYL; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oJcjR3VS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pXywWQYL; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722441848; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ny1cQJm2Lwyao+X/FxxVd6jUz5C/XMTTGu2oaWCfi4M=; b=CjPxmcWwmUsct3wLZjqKqGY+QTK96QyhDOXwTS1BLa+9cpGRqv+S55HODpw6UwatUu7ioY 0NrTwLqbu9VglRCkhF++5JPm0b+JJ46nV/lN+PRluwssvulqEoHYZ+ZT5TGLsZF9NAnIl+ uhzHDFntz0pDzfx+fn/TP7RxxgPYB30= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oJcjR3VS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pXywWQYL; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oJcjR3VS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pXywWQYL; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722441848; a=rsa-sha256; cv=none; b=ukEEw7BJ9fpW9jgMb4vHxqFBtDg93Hbny/n8sApe04JMONh0X9QEBqovfgofJS4r41iLQ+ nUjz/mSCBSheJFo4hwK+pnRYP8BHqJH7ho6SbP65I+Y6MZJsgqKBCUQtpvgok/dSj2CtmX +rGGo8bYlkSUYO8WL4wEhTGRNNBkxrs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6D93B21A70; Wed, 31 Jul 2024 16:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1722441851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ny1cQJm2Lwyao+X/FxxVd6jUz5C/XMTTGu2oaWCfi4M=; b=oJcjR3VS2GX2IeLTqS9h91H8Bg9dxaIuzRM4nH70z+W4uLn4KJ9y72unrG3h6ywQd0a8QR O2ftrCYZvOTG/e3lLLsZYPvmoElT4fC/greQQX0x5NDyzCpiSDfDoeEb3uiVo8mQ9lpB7H i0/Xv2FRg0GLS98GQOamel7pPChUwOA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1722441851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ny1cQJm2Lwyao+X/FxxVd6jUz5C/XMTTGu2oaWCfi4M=; b=pXywWQYLENY8SqT86qk1rM6n4kTpF9M6bKUG9IfhQUVtDviPbTBMVorZJfJAway4vtPSE4 iYxvDqZMjrtEYXAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1722441851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ny1cQJm2Lwyao+X/FxxVd6jUz5C/XMTTGu2oaWCfi4M=; b=oJcjR3VS2GX2IeLTqS9h91H8Bg9dxaIuzRM4nH70z+W4uLn4KJ9y72unrG3h6ywQd0a8QR O2ftrCYZvOTG/e3lLLsZYPvmoElT4fC/greQQX0x5NDyzCpiSDfDoeEb3uiVo8mQ9lpB7H i0/Xv2FRg0GLS98GQOamel7pPChUwOA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1722441851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ny1cQJm2Lwyao+X/FxxVd6jUz5C/XMTTGu2oaWCfi4M=; b=pXywWQYLENY8SqT86qk1rM6n4kTpF9M6bKUG9IfhQUVtDviPbTBMVorZJfJAway4vtPSE4 iYxvDqZMjrtEYXAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C807C1368F; Wed, 31 Jul 2024 16:04:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id jXscLnpgqmZ0EgAAD6G6ig (envelope-from ); Wed, 31 Jul 2024 16:04:10 +0000 Date: Wed, 31 Jul 2024 18:04:04 +0200 From: Oscar Salvador To: Lorenzo Stoakes Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , Muchun Song , David Hildenbrand , Donet Tom , Matthew Wilcox , Vlastimil Babka , Michal Hocko Subject: Re: [PATCH v2 6/9] mm: Make hugetlb mappings go through mm_get_unmapped_area_vmflags Message-ID: References: <20240729091018.2152-1-osalvador@suse.de> <20240729091018.2152-7-osalvador@suse.de> <8a57e184-4994-4642-959d-44dc7efbceca@lucifer.local> <354e4db4-e257-48a4-9e05-7f0595728ec6@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <354e4db4-e257-48a4-9e05-7f0595728ec6@lucifer.local> X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: rx5cm48mnbfi5upa8rgxaw4sbtrceta8 X-Rspamd-Queue-Id: 0500940032 X-Rspamd-Server: rspam11 X-HE-Tag: 1722441852-503020 X-HE-Meta: U2FsdGVkX19T/iNdgn1cOEPZP8146beR9JDrhqPnCmZBCsOlKo1vpCT7N8G/7ZrRXDdZ0hCX6cmPDQvWHOPWmXgI/s669yFOr0Yfv2Aqz68PQgbhtV4v4DYM5lblU/sgtylojwqZK2oGnZAIJraSFGw6w9qbJqpbGpzZHtUl3Enzg52ff1ZPjNU4iDgf5Rm0gSoQn48JTNArtwAZ4l1D+VtfW570dpeH5yU/2Wj2DjSUFv15p3M2xaO3da2ABtR5xj9xp7xIL0WMyusW5FC+XhtOHc5FJ59BsqhcMf7Hq98H7bqGr34slQh015kb5MVDD5sYN/TBa7diYkKnY14nN0rAkvBW61uX9dqmW4FUQ1yAjuYJ1lzV/MxUxqptywBi80zBD++LhnoGi8M27lHCuvfRmdjuk4nfI+1QvuRVdPYxv6m84q/Wxj+j0d2iY1BOhWM5xFbdBP7CoWBX2v9JTYmPr7rCk3hIkqG5RZMdDcsSkUnZl1tZnpcuNV+jhZC0qcahjDF3/iTCjigxuwD+gkvdlMFQ6+lw21JL0GpRRiLHX2Qz39Rjdc0vAgn45m2OahXXIt+icEZlgN573ERjGJUtPNnSYnC9CyDGMmYv8ts5B7Jj5pElN/SG5h1taerNHpP6q/3ZdExeFsaTfg+bYQBSbcnrjaeAIzXVNrtYViR+xJBU+K9t3i1LdfZnflmGShGT1jDvJaUwHb6s8LBBucUhJgGRea1n6Piubw4k8CHPDWOC+tGwr2otNOBIJt3tWyE+qlAo+UMSKPUkUHXYFMgc6zYLBJUq/7ys0dxCQvEBJL42sb4oxgjqiyD9kQnDEnICZyV/UkWIumy6otD0b/czQ2rAeRMhYZL+mdZTT2kfWZoQVAixQeZzQANSYzj1lAGQ57rZWaJdBPGEbSAMZMJZn+TIIoM7xvg+w8t2CRgwMynxSaqkdB7eS0gRbIN6imnIRK8Q7+hut+Uu7wz huEHMP0X 05MZ6SOt/Hcfc8xuVBj4Ivio1pMZ9BRwyOpN81wvbAapvQWUAzWvFhVJ6yJCeowRcl8rouO4hTDUKlvjepjMZC/O45xsSv3zKBlDl0vHXF8RrIKXytZy64YAfxhQMYbfTV/A/T0ba7WKid3+Aje5jPoHbBBDd8BE4eIE5OsuO3uL3vkrQqTOR7Q3Yj9MPnmqdsznAEzznYKFszFIBGA+8tY5kcdUvmUhouxCbuawqZc7Lu39s+IZvzl+5Cp2shpBo0cPDA1D2E2WsD6kURF+1LE/wYPM4808Xv/H3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 31, 2024 at 04:19:09PM +0100, Lorenzo Stoakes wrote: > Yeah this is at commit aee8efc95fc2 ("mm: make hugetlb mappings go through > mm_get_unmapped_area_vmflags"). > > If you: > > git checkout aee8efc95fc2 > git grep hugetlb_get_unmapped_area > > You'll see it. > > I'm guessing you remove this in future commits, but the kernel must be able > to build at every revision so we can bisect (I found this issue through a > bisect and had to fix this up to check). > > A trivial fix is just to provide the prototype immediately prior to the > function decl, however the more correct solution is probably to do the > removals at the same time. Yeah, I just squashed the removal commit and this one. > This bit is just a bit of a slightly nitty cleanup to make sure things > build at every commit, the first issue is the really key one, just needs > some tweaking to deal with the frankly bloody horrible SHM stuff... Do not > blame you for missing that one! I did not check closely yet, but are blowing up in: if (shmem_huge != SHMEM_HUGE_FORCE) { ... if (file) { VM_BUG_ON(file->f_op != &shmem_file_operations) ? -- Oscar Salvador SUSE Labs