From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA11AC3DA49 for ; Tue, 30 Jul 2024 22:43:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F2DF6B0083; Tue, 30 Jul 2024 18:43:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A2096B0085; Tue, 30 Jul 2024 18:43:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51C4D6B0089; Tue, 30 Jul 2024 18:43:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2EEF56B0083 for ; Tue, 30 Jul 2024 18:43:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D68878013C for ; Tue, 30 Jul 2024 22:43:13 +0000 (UTC) X-FDA: 82397896266.14.D37C4CE Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id AF3F2120005 for ; Tue, 30 Jul 2024 22:43:11 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lnboNwLx; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of dakr@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722379351; a=rsa-sha256; cv=none; b=TzOQMwmvZQTDvK3xXgFNZmcwZsqDWSFNKX1L3Ec/M0s3dHN6D2TNmlq9XiNrEP5TJpF5cl +L+cuQSeEFNFqcXWYXpgl3S/ov8FyTc5ZIPNgGLj8dJqj57d6nLMtOFQK7z9M5KyXwtVD3 I/R9c8pkX5IMwF2DhII1glP8TW4a0UM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lnboNwLx; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of dakr@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722379351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P9g/LmzddRE4ZXtpe+tFIoR9lDUNWoREdcNaTNZSRhM=; b=7QoB5uekePFWzDWFkz1prlfCGPVXdAQvtu1Fcn1qw4Wg/xYFvSV/2l3aLpPv864O1PObue 1e8KWIfB5CR7hOX9SHrXiqqIQ8N1pPGsIwaKwAOHSqQY8fva19eHBqp+b5/WgteUc/8keQ pa9puIFN7EFblsYVWyYRQ+ymPkU+AGE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4F282CE1269; Tue, 30 Jul 2024 22:43:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A8A0C32782; Tue, 30 Jul 2024 22:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722379386; bh=C3lXJgJCovoa1FrP2K9NxLwNt79kRXHdx71rpFLCEkM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lnboNwLxJyFxKtEaiWymk9Q/n8Xy6nev/WHULsWLoGXfvLKMZzR7y2YlrIeBvjlxU eMF2cmvQliHYtglKf4G4fh3NFOoMZo0NBDXFtXeFC4oWc38RtPpoqFtTZBXkmoLiVM RaRWYejEfeAjQuGneuuNZ+HzVf6qxnrmdaYS3oBWzfqKyh3fwA3njHUT/AUCN50kWN wE0LROsis7tkzP6Qmroke4mn2IJg/R1L6XdiRq2s9BkGYGg9123JvIIyCxot3kf623 dQyMiRWLwtj0Fta+STtU1GplxxzJ8OBkyESgXw6fc0hlFO6YNn9tY1R2EqfjTE0Fpb rn6T5vmno+9qg== Date: Wed, 31 Jul 2024 00:43:02 +0200 From: Danilo Krummrich To: Andrew Morton Cc: urezki@gmail.com, hch@infradead.org, vbabka@suse.cz, mhocko@suse.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/4] mm: vrealloc: properly document __GFP_ZERO behavior Message-ID: References: <20240730185049.6244-1-dakr@kernel.org> <20240730185049.6244-4-dakr@kernel.org> <20240730141953.a30fa50c0ba060fe0a765730@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240730141953.a30fa50c0ba060fe0a765730@linux-foundation.org> X-Rspamd-Queue-Id: AF3F2120005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 84c4kfsm53omzoexue1fn6dm79b9p8ee X-HE-Tag: 1722379391-477259 X-HE-Meta: U2FsdGVkX1+YDWS9HVmPSE7LCEKGDOswMgBZo+60I5Zk3NNJdP61VC9C3tKyO3o+nAZcf16Wa3wl1DpZkNn26k3Azu9zY0UIEQRfOyMpsehDLgVuAHEsWBTb+2ga/qd3LC4ux5hBl7reOj8XzprJwnXn8/UbuSIXsfrFZ1nYJWgS0em4AmUseNoSu3ULyv+XYQMhl2xkxnIJam1D7JN3Ly2mO3ooWhzO0HB1xQi1dPRzJXXUggZL3KY0ik4pDBBy1cE2694r+doYRjxZMr+vumYY1QBvno8yxl8WNgMy/XFprbeuuix9s5c4dVEvYiVqsQBcFm0ZTf9nENvcDlGyrQIfNBo8+LjsJx1EpcpGrAcTUNAtzI5bWSlk4Kpp1VMDGdGC+KeZh7WYaZNMNT7IKKXnivB5KIV9aFizhxsNAY9Q1IHI3PwMtSTRMWW/ODNG4hppcERNHF40yIk2O/P4zDlfCwGT2OXFvTcWc1HKNUMg7m0yIHrU9EyMjzPRe38jvHwjYIjy032bG3BZJgxoafhnuQuvfo9q9Au9K6XMMM+DB77T8KobZXmK4O12W28qYvr7bbCdtS6Cxr2LVMLPuGCi+dqAHXVDtia17voHrRQYiZE5oPvMBHLFcZtqfDAyzHi/SA1zYnLyLsOF1lSCroaHC/3oTdB9nPych7L55KJdPQ0zgX7rrZncnQhEUolCwS/56pLC8U3ey4j0IjYNYwY191763e4xj3iP/x+iLo4DzK4Pg0j1+NcOYxyCeOCbSTNdxsHm5IUHdDt5d+8txTzMyBCSdChC0aL7AtE7uwvmecz9En5UZ+ms7Mj22vbgTqhJBkVcDMaoTPyL2TrqX5TnUeW2AYTx6K8D8AL8DpX4GCqRjyfMrL4MqfkkDIgfuXVVPEfG4mX0ELaJQ92G5cu3smIjIkcCLbcuOeZgmIG4HyEosa5uSdgKrWRfgSufNF0g/m7UNgKeaTXKZuk szzOXiBd 63+3oF92yCupKpRgMZFcJTq5yecnwvv8t7LP9vDun9Yd1WPxn4xHBxZOHe/fpdH2I7yeD7ibaA+/YHHkM852L5IqV2GrFzdWo1tMEikqy8ez3RD1vlytEOxNb/2ypDw24Za7BwCAM89OA8exodoSEl7z+VAZ+ofrmTbjfLeUS1Y8B8XpQ1fpCkCyhYFqLiOyPmuJ0V1NDtOtlIX3lJZ1HBzsfrHpNnCD00VgX0PtrHsQH8Gni3TzBOpRFmrCWc6enGQ5rRNjQ6X/99mqGmjd6fwxmC/Ud0KS0Egpa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 30, 2024 at 02:19:53PM -0700, Andrew Morton wrote: > On Tue, 30 Jul 2024 20:49:43 +0200 Danilo Krummrich wrote: > > > Properly document that if __GFP_ZERO logic is requested, callers must > > ensure that, starting with the initial memory allocation, every > > subsequent call to this API for the same memory allocation is flagged > > with __GFP_ZERO. Otherwise, it is possible that __GFP_ZERO is not fully > > honored by this API. > > I appear to have just seen this, in a separate mailing. What you have seen in a separate mail is a similar patch for krealloc() [1]. This one is a fixup for vrealloc() from a previous submission you've applied to mm-unstable. > > Please, slow down. We have two months. Await reviewer feedback, spend > time over those changelogs, value clarity and accuracy and completeness > over hastiness. The only reason for rushing things is if a patch is > disrupting ongoing testing of the linux-next tree. There was a discussion in [2], which lead to this fixup series. In terms of changelogs this series is indeed a bit "lax", since I have recognized that you queue up fixup patches for changes that did already land in mm-unstable to be squashed into the original commits later on. [1] https://lore.kernel.org/linux-mm/20240730194214.31483-1-dakr@kernel.org/ [2] https://lore.kernel.org/linux-mm/20240722163111.4766-1-dakr@kernel.org/T/#m065a7f875b44dc945dd535c2b7168c3d77a98993