From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 341E7C3DA70 for ; Tue, 30 Jul 2024 14:25:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9758A6B0095; Tue, 30 Jul 2024 10:25:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FEE26B0099; Tue, 30 Jul 2024 10:25:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79DC96B009A; Tue, 30 Jul 2024 10:25:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5A32D6B0095 for ; Tue, 30 Jul 2024 10:25:32 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D84B4120341 for ; Tue, 30 Jul 2024 14:25:31 +0000 (UTC) X-FDA: 82396642062.02.3F3282A Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf13.hostedemail.com (Postfix) with ESMTP id 306EC20022 for ; Tue, 30 Jul 2024 14:25:27 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ihtT2WcC; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722349473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5VQEznJg84i5ZK7eGARok4l5wc3m0IWj/uMPsa8F98w=; b=DqdtR4LASnlDxwOPq43oF9Qo2TU11oqTQHt4Ksw/NsBEQQrzl6xVaOqH/kNf3Mov6D8Fl6 vb/OMJvOcN6xGTle4AUxSqIkx7dhSoarsIQFcIvSHWWsTndFj/ceg/7hPaYYwu3jAyE5qf e47zSWeADypMor1pTe60xEz8kp8DYcI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722349473; a=rsa-sha256; cv=none; b=HZsNdqc/CLtJCsYHoZ25IDFq3t0tKgfSUAureC60/94AJxCbPE03gDg9Lo6beCnDQl454P MTfrLH0AcCACfV7pNCbjGjYkAbp4u6Wzkb80duEq8SX9atVM9NqJisx7RySFCEaQOGr3vG xTWIbQ0ptx0nV4aRxzxuN3KYASQt/fU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ihtT2WcC; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52efaae7edfso5129059e87.2 for ; Tue, 30 Jul 2024 07:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722349526; x=1722954326; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=5VQEznJg84i5ZK7eGARok4l5wc3m0IWj/uMPsa8F98w=; b=ihtT2WcCtq1Vwl/ODqgcVykAJBWdfFQHOauGporD+eKWfXNqGqNjNZpu9SkzdQftGc rdPZOKcZyevni4Dt/mmVV76dd+FUy7iaWSHeFJ2NHaXFU1gTra2/bA54QA/Ao8bukzTm eyP7RCo++BL1D7tLp34epKUh3/14Djt5FzQwcAJx/dIJbtD4aOfiA26oi42ol7WY7upQ HWMSlTQgQkfnxa0cEnOmGDAB/AcU4ULZfyDWf/TieLxifGch6RodETQFWKq6/yx2xlxX yqdlt4c0wHZOYVnZS1np3vHMeeW0bHZ8868MzoCft2ATXbVvZljSzRnWuGDNvhCz9Aja 3GXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722349526; x=1722954326; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5VQEznJg84i5ZK7eGARok4l5wc3m0IWj/uMPsa8F98w=; b=dOw1s0KL/CqR7Qi7pearnLk0VSEnT8qTl1Y0CBOuY+84TRBPk+flLjb3ColJHjwnEb X4NLphHBRmaJs9AXw80+CCbEEdoUgBiI8FoPINFNmWr1c9Wh5jOqY2q0AhVNGzp82TPX uklFfJlV4Um0eTi6dg56JFT1wW4AcJbniZkSm4mWrcB1oFzYK7ZtYObLNq52FsOrTHIw WsLjGgjcq4JRQtmjpytS2FgRCGYk7eV3E5sjL0YjYw/WM5Q+abjbnnuC1sRvdVqD5Ift QY4I1rYIYQlIBD69k1AIIYNVdhNzG84/XDxfuXJRiy14u0or8VnWM/iUhwHq6DIAx2kk +bUQ== X-Forwarded-Encrypted: i=1; AJvYcCUtPuuWCqdUJicu4gVENqBREwKoDHXs5RvvKqXkxOJsMQGh19oIgpyZ1rq9YXR8sfGFw2jbuwgnvoetaZ35U4+Gqc4= X-Gm-Message-State: AOJu0Yy3DnOXkCgL4yOG+P12oti1Ff/jNlGj6hOFJKa1IoBn3Mkl8KSY LQfrC0tmoPkn40amUbCo3S8HjHUERnBM11mTr9x9KXsEG3Yt5V4O X-Google-Smtp-Source: AGHT+IFLzRCIQWexgX1O+QPShiRIrQ7VfY/StVijR9lRPcUIwz14qenunSfvdTmdWPtO571hiS57iQ== X-Received: by 2002:a05:6512:480a:b0:52e:be1f:bf7f with SMTP id 2adb3069b0e04-5309b27b283mr6293800e87.27.1722349526121; Tue, 30 Jul 2024 07:25:26 -0700 (PDT) Received: from pc638.lan (84-217-131-213.customers.ownit.se. [84.217.131.213]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52fd5bd15d2sm1868898e87.112.2024.07.30.07.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 07:25:25 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 30 Jul 2024 16:25:24 +0200 To: Andrew Morton Cc: syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Dmitry Vyukov , Andrey Konovalov , kasan-dev@googlegroups.com, Aleksandr Nogikh , "Uladzislau Rezki (Sony)" Subject: Re: [syzbot] [mm?] INFO: rcu detected stall in kcov_ioctl (2) Message-ID: References: <0000000000000f67c9061e649949@google.com> <20240729143112.3d713abe2bde51d718c7db93@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729143112.3d713abe2bde51d718c7db93@linux-foundation.org> X-Stat-Signature: oszi1ikqetspb1xct1zrqxgdswtwju88 X-Rspamd-Queue-Id: 306EC20022 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722349527-698418 X-HE-Meta: U2FsdGVkX1/TnqGPwmGaEpatKJjK2ZuaubypIJsTPsf54egT45Vah3toEqIRwORPwvs/kn7H0bVPGBipFy1OOlTjT5wM2OyyEm2SFrMsuUd4WdTjWcJZ/DKzawqYwwe6fc2fwHpLgDpUB47OtVksbNKnL2nnE/JumdaPFgtORufr9BnIS5IqYYRQSe2ycGwuJKxh8bcl2uKzt4zbphzPWiXzZTYpxdvnBaBHoTPKhZDjmIlRT+0YUXgMIoOhoXqMEU4E03npYn2pf9mjtgUNdjcyxP8s7OFTDEdQUBJLj949ftAOeSigK3RkD0gOPI0yL6DAdqzfPVsXD5DAKS1etMYF11j0nMFAm81rm2mY0p2kvuUJW+ROqQvqkEToCo25yIile0JMooPuAqbFV1SR1f9Ztob63JzH6c3vDUyJuoXrU3yxlCTRW3CgWCKdMMeer2KyowG/XO6tIUWwh/x6OUpyI+3mj3Je86+1T1QYweD6wS6KHtwgZwsrJteVee6ePXqUjvCxgfVIQH95I4X/xJF0nRl3KEyFwuM+nDKaRC4qRgd5nMJbjONsD67iPumFcYLJtsuwVNT/cG+U2mPV+/ZGP/iIkumn2n2wQwnMpDIB/ZKmZl1StzNYut9+b6rjwmho81+qbzhgmWmSmWVcX2naoXgIgLpGIRzm5NWD9DUScI5dSou5SphA6PnRHhwb5NSEWNIwGZMcW1ZYqSs44SEOjSKqOpRW85Qd9dTz3PQvuR3FSYLuZwJL9By599CbuP6plpprhx3peGWVHfnWk9TCF0AkFrzT3NZLCbFOXbXMwN2/0FgdlgWyWbrHtsWChCGZD60EekLcTeEUzivOIXhhvUxe7tvNqQ1iWT6vsIL/XliWcGxpllX4Zy5zfo2ByerBIwk16gK7Lm2vBT5HQ/BSjgfjEe22Yub2QZBfsgnhR6kfXmxy7h02obkFWcZHy0vjF7fAu1K1x2mXzG6 GUGnDyi1 yINRzshxfXgcIqFqP/h/m6qJJ8MNONEgnZw81xmEErXHcJE6oDEkt0Ct8K6udYsqG3Q126xFjikK4e/8ovEulSCklYn3GtEx4KHRds4vqm1SbxywD6L9W9iu++u2VfGLjvW7gxEvcr8j7+j1l73ZIDXJEBXXyNJgCdVja8tLAYhwR+B5o+nQjybBhsXYFRLoo7typh2UnLEgLJrZo9+9ILk5BXdAvJtalkdOKYnkOpjXGSodEXXdYMNJCGH2b3nXJCnU3anTnbXF+lmg1sRS3A3uAxQaWF1oyiBpxhmf3EPRqc/+Jpfz8bW0J7xhQKFK0J/USXTUoUH0ZbPmZ7pHNaj9fcX4wwLV1JY2a+b4IkvpA+lqZlwZ7IL9VnfuNdgEK6mPG6Y5rdBTET3ap3H7N5uL4Tm0UeRG/YGvCxJzsB/ettzRUKlpeT5K/8A6YsRAq2u0JmGoV1II/7AvjNZUpLOVyzjqehgb5oORMaXpTuQ0cyum8PwoSjep0qrqo1sg4V8XVjj105+pUB30dQjos/QDyoeWSrqygo2Oa054UXx2M4PbfRAmtCda7sQBdMxJs3VGtYpZlmNZvVpgF9sJqt5UxbjvfPzcew/MUviETi6WfZju87a2mNND5pnun7QZO/pbvQcz3FJNQePum41mRMzfzeVXigTR/Wfzy0AtMyrHP6SluG9Bbke+NgOu0qyG52UNbE1skI7eQNyOI27OhveCprgL2P6KI8pnQYZe6ftz6szwOAlSzZcylVJOJE50OFcC9fAe/Q258JFT8j77EdQwSf3m3TOI1KMzdijc+rJTax5XtMr19QnN+kGnroOVEQXUI92aLN7VlS6646WO3FfJqOml8etILLi7iYkaWZeDbbRfWHCRGgUyDCxXo++NPsCGXihXKyh0dHLOxcBFOkFWrKsK4H3XDP0Xj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 29, 2024 at 02:31:12PM -0700, Andrew Morton wrote: > On Mon, 29 Jul 2024 08:34:33 -0700 syzbot wrote: > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: 3a7e02c040b1 minmax: avoid overly complicated constant exp.. > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log.txt?x=132e32bd980000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=381b8eb3d35e3ad9 > > dashboard link: https://syzkaller.appspot.com/bug?extid=ff2407cef5068e202465 > > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > Downloadable assets: > > disk image: https://storage.googleapis.com/syzbot-assets/198814da854c/disk-3a7e02c0.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/868e99275bc0/vmlinux-3a7e02c0.xz > > kernel image: https://storage.googleapis.com/syzbot-assets/ce63033f3708/bzImage-3a7e02c0.xz > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > Reported-by: syzbot+ff2407cef5068e202465@syzkaller.appspotmail.com > > Thanks. Possibly kcov_ioctl(KCOV_INIT_TRACE) was passed a crazily huge > size. Perhaps some more realistic checking should be applied there? > > Also, vmalloc() shouldn't be doing this even if asked to allocate a > crazily huge size. > diff --git a/mm/vmalloc.c b/mm/vmalloc.c index bc21d821d506..450c6b10a357 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3783,7 +3783,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, if (WARN_ON_ONCE(!size)) return NULL; - if ((size >> PAGE_SHIFT) > totalram_pages()) { + if ((size >> PAGE_SHIFT) > totalram_pages() || size > INT32_MAX) { warn_alloc(gfp_mask, NULL, "vmalloc error: size %lu, exceeds total pages", real_size); We can limit it to ~2GB or add a special threshold which will control the maximum allocation size. Any thoughts? -- Uladzislau Rezki