From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F346AC3DA61 for ; Mon, 29 Jul 2024 14:21:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AD976B0092; Mon, 29 Jul 2024 10:21:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75D316B0093; Mon, 29 Jul 2024 10:21:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 624B06B0095; Mon, 29 Jul 2024 10:21:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4298E6B0092 for ; Mon, 29 Jul 2024 10:21:45 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B795E1C1689 for ; Mon, 29 Jul 2024 14:21:44 +0000 (UTC) X-FDA: 82393003728.21.41EA22D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 18F0AC0021 for ; Mon, 29 Jul 2024 14:21:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1IzM35Up; spf=none (imf28.hostedemail.com: domain of BATV+22cce97e185fdc5e0b5f+7645+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+22cce97e185fdc5e0b5f+7645+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722262850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZVZeP4kn4uvUlHvrkW4ziJmVQXuXAiVc7MV8VWayywk=; b=PUzQMfQxbAWNd+LpVPtP8ghfWEJ59lzx6+FXiVnpp5G2BGsViQdSVQvbFQJDZ2FA+p0ZSq sqNOvh7TaA34PjmiunaC1D4Zahtnh1gQ3VwNuAsRHqgZhItwavfcaZ+MP2kW0uSlHJCw9Q RnxcJS6vqaaIW63DcGWNSMszKF3xdN8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722262850; a=rsa-sha256; cv=none; b=xZV4AZ/jJOltdpx2tugUKwrOz7r9jKo9rjqVYvPe4SXE3Q3hCpkhNBCoGUvwIIW9PRCqc7 7I5w/nDJePULP8SzssYRzPIdT2mOPsfINx5T+XJgOLdTGIgUUy1xsdmwzkv/kjNBfgl6pg VTYR3SCA+3gqeSXAr/n6qCgLoZLN28I= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1IzM35Up; spf=none (imf28.hostedemail.com: domain of BATV+22cce97e185fdc5e0b5f+7645+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+22cce97e185fdc5e0b5f+7645+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZVZeP4kn4uvUlHvrkW4ziJmVQXuXAiVc7MV8VWayywk=; b=1IzM35UpR6KGDWE3tLxtYcQHIp yXqeIHL3femg7Z7DsYX3hLZcj6sCIzrf4DwmA82MK2shllYdMKOgTB0Eenx+TnR+p1KioCBQDvMvr rUTSGiSZLRjEA+rQ29J5IAS+AE8dMSojwUD4/anF2dqh+FKD9ROyRl3FpoBKClZBHmvPjBg4Jw2o3 d5GIKoADwwOUK6tMbQrYDwhYt8WuvFFP76ARRkjUz9RjINECABCkCIP4BOZDc2qqh4w8CdErPKYF9 ixeDoOBAayQnolnxG1PbVEut5rlVfXdc8U3n8vdRg8nLZYd99NAY90+V4mg3BcYEZRl4m0vbe4a6P MukraIdQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYRFp-0000000BXow-1eN3; Mon, 29 Jul 2024 14:21:37 +0000 Date: Mon, 29 Jul 2024 07:21:37 -0700 From: Christoph Hellwig To: yangerkun Cc: Filipe Manana , Christoph Hellwig , chuck.lever@oracle.com, zlang@kernel.org, fstests@vger.kernel.org, linux-mm@kvack.org, hughd@google.com, akpm@linux-foundation.org, linux-btrfs Subject: Re: [PATCH] generic/736: don't run it on tmpfs Message-ID: References: <20240720083538.2999155-1-yangerkun@huawei.com> <4188b7b5-3576-9e5f-6297-794558d7a01e@huawei.com> <9514fd55-4f83-8e43-bdf7-925396ab5e48@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9514fd55-4f83-8e43-bdf7-925396ab5e48@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 18F0AC0021 X-Stat-Signature: mhog7khmtb4kkyaf1xoeo7ishsbsdrsz X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722262902-931417 X-HE-Meta: U2FsdGVkX1+7T9oEzYrB2oo5tK7b1gOCcEizmdFv8onhCXpgYWN8V4CtG37vL5rjHEgIbuyvtRaptSYJBZg7LDI1hgYJMenuZYH9b9AgXkGyafAwlVMea/xZbM6dmrF/0Ewvwd5MdRHEYvyjc3JA2x983tV53GnMhh2bc8SeHK2NZQ1Bf7o1Kd0Lx4GhnOJ4hR85IzxP1DKyL3hSgDfUKeGuPriLOoWHKqStGIH67OZJroPa3qNkY/jliHY2i8PHq/ddACYGkg+2S1i/Qx9pPVbneL4xjoiVSZV7u5yLQ6QGXpBG/XXXQaThNHILLwhynJl+FCHCos88Pg77z1/SHPRpC/s/bZvGW7oLHM7oqdqLU3KFnIMdcNdy7dvPHz143Esr/4/hrlh3MvIK2q5+9kWbWuCvn21h7ayBxG5CgDVInUXzQ00b4Nttgm++Pfzu1QubMasILx/vK9kEuax8x6wmObOohpuSoOkOaczXE3gfUrevSXyiqEfbmB7K4lk0WMg0rLAKwXQDp9aaHo1rKBx/lZ1S1Ur4Mi/KTrLGU49PMfcr/EOq+ptfR/xMlzRj80DUCVfLVrSTD9p6xgeGFNXHttBf4LewlyaHO0u6gnKwexI3OYiZMDPMQRjVKid/wMrO2oEj7WTBJg2wcn9tMM6E2FFswtiaflNF54RIqhBizci8D+wwhPbD7N91X21kq0ENUtRW7MASRtQ4OIX6llvIkijWLNI0AFjBbvXS14KI1RLKzjKSW10f6h030TXSL77d3GjztB2Htr2CfRX8J47WpsP6ZQYlMw1P4hzZrkzYAdsWhmycBYTqG8thLtfR1wmbpM9n2rqyPHjwas/rMsCee5CiprbYRExz66mCkMqwGAnFnMP8X6FAOJnteznbztFM53BmwXEe36sx6MPgGCYFv7Z7UJ6UxQwScsSd05ux4nUlOgnLdB4aKXHKL35lH/rt2AOTUGLtWV9Gm2g 3KXqk36L KAa4iI7Z0L6iqL1ORFG4UQSjHLZnwUQp/vmzmmlXEe+w+2tDStTEweqzHfu0wDAdO+mHhZUGuS41JUglGds5dIgqRBGzfNIDqDocc3KtsFcnrNBGrVtYZatuhgv4aI3/4cwwVPVr1H80RirhH51TXbTJur/k02WjwO/eO31woltoFg1LDdkJ7iZEFRthkqgL1WihhhD5eH58kBX6/jDcUXUccmiHc+sw1Zaq+CpOiTLnxvrky2uqfnzT+MSPQVVUcdmLIxb5BGWgwv5+xEAm6N82YZxUbZdjQvKH7wvHBoeWVODeLL5Tl2NEhfWVwCRy8+Av1z3ADoOv89vr2BlLV+aYbw86aMe36uIvBL0COWwMbs6TLs003z1vfZbeo9Fvn2W8uorzB0sJswTmDzJBuOMZjbrAeJNo3uOPByiLetSJbEIUuqhT5pwsRHyRq9Uh4fQyk4NScZoHLbb4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 29, 2024 at 09:53:52PM +0800, yangerkun wrote: > But after commit a2e459555c5f("shmem: stable directory offsets"), > simple_offset_rename will just add the new dentry to the maple tree of > &SHMEM_I(inode)->dir_offsets->mt with the key always inc by 1(since > simple_offset_add we will find free entry start with octx->newx_offset, so > the entry freed in simple_offset_remove won't be found). And the same case > upper will be break since we loop too many times(we can fall into infinite > readdir without this break). > > I prefer this is really a bug, and for the way to fix it, I think we can > just use the same logic what 9b378f6ad48cf("btrfs: fix infinite directory > reads") has did, introduce a last_index when we open the dir, and then > readdir will not return the entry which index greater than the last index. > > Looking forward to your comments! I agree to all of the above.