From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5633CC3DA4A for ; Mon, 29 Jul 2024 08:30:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6A776B008C; Mon, 29 Jul 2024 04:30:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFD206B0093; Mon, 29 Jul 2024 04:30:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB9DF6B0095; Mon, 29 Jul 2024 04:30:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 868316B008C for ; Mon, 29 Jul 2024 04:30:51 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 07758C01CF for ; Mon, 29 Jul 2024 08:30:51 +0000 (UTC) X-FDA: 82392119502.09.C008AB7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 32A8E100029 for ; Mon, 29 Jul 2024 08:30:49 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gp+Rb7X9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722241846; a=rsa-sha256; cv=none; b=m935tPvw/vv32cEcV+7SB3+qfgIlhWppzWuik2RU5y9eSedzL20GArvxti0JL2hzL/4P5j /38+cPwvXIn1qMiyMMtnWTa8eCOoCUzk3F/x93wgNqW6+7mQ1ZNHk7L3TbfPkoEHd1Jhl3 FIrxd3kloJph3G8JLYbUB+L3zcU6t0U= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gp+Rb7X9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722241846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BXyPUaLFEwtL9HdgLuVBIuBGMnXshUe7E68g55fuMDY=; b=PYitcWG88NvgVjOQrhJTbRDEIfs/zkzhbrFnQM1R9pvuZAvry1n4CtibeNQWyjgp27nCpx lLJZVtQ2YDbxCgDwQxx7HyVlE51vpnMxDfhobl4eB3ipctKGDpKMzex1XN1JLmMI9awDpE 8Tr2av9Z9qZ3HET6RV8Z/dR8M/RKIb8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722241848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BXyPUaLFEwtL9HdgLuVBIuBGMnXshUe7E68g55fuMDY=; b=gp+Rb7X97OqpDfGVv2HtEvfNiqs9ctXNxHNHWCjJ4olamkF/xXwmN4HZjOBpeL7NemATDk fvyW/ln1farhKLX5akkzZuI94D4RbxwdLugvur2qh9TrwvcFVcbEuPTZ5i8GsL4UtaxF3W O0eg6heSd7gu1tdpHNooFKXkAdGVLPE= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-wb0pl83oPHywSPCvyvl9Vg-1; Mon, 29 Jul 2024 04:30:44 -0400 X-MC-Unique: wb0pl83oPHywSPCvyvl9Vg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0AF4F19560A2; Mon, 29 Jul 2024 08:30:42 +0000 (UTC) Received: from localhost (unknown [10.72.112.54]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 38D701955D42; Mon, 29 Jul 2024 08:30:39 +0000 (UTC) Date: Mon, 29 Jul 2024 16:30:35 +0800 From: Baoquan He To: Adrian Huang Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Uladzislau Rezki , Andrew Morton , Christoph Hellwig , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Adrian Huang , Jiwei Sun Subject: Re: [PATCH 1/1] mm/vmalloc: Combine all TLB flush operations of KASAN shadow virtual address into one operation Message-ID: References: <20240726165246.31326-1-ahuang12@lenovo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726165246.31326-1-ahuang12@lenovo.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspam-User: X-Rspamd-Queue-Id: 32A8E100029 X-Rspamd-Server: rspam01 X-Stat-Signature: dwwz3peukfu8r4x1nsa4i9no7mgpmumy X-HE-Tag: 1722241849-298978 X-HE-Meta: U2FsdGVkX1+8Wdxlp2vdxf6svvaFuaHqjCP5+AA/F+AVOouUvY2Din+eJwkB3/h6GW6OSnyGkuUQJpvZJF6PG1SbnHHyfjDlUVTZ78vvwmm458cwQnFYvKmZcpvxrQJ2oZ3P4rE+B6GMZg5CiQz1aLtas3E2DWlWSalj6rsBGbjm0KwBUVrxK6v64svZfZSh1l5EeWMQ95WucDOeC7PPnMtfgamKbUVbHCaRFWzxNZJPYDdgrkqCHFwuSLEzJ4+QXEXLjp+P35p3rRjISMWhK/5sZFKmI/lCwJnr8p259xRc/AhwX11c3QCzc3AJNHYOQj3RtLAlGRg0WXWi03Q9/RhCeEsFulnO1pzAXunp9AzErl81wIaq+YYVoW1JCetjbEx713KhS8mKAUEiWxtjHI95FeXgD9kEq1EyvBfjpiv1KYtblfBUyQjMQmfIlwQuG4grIR4y+9wf+mAl9ng/1oikUlE7JRD0SFbmMWTUNvyZgRrSklnkYjDHBYE0REYoBlsw1wsE4mNotDe3FrOtCvIiiMs8sj3Ex8SaewjTQal66fKgnwuvI0FctBV11sIBAenXoSL38M9H2RG06i9y777Q7w5NcbPow2RdwAkj9/3Q6zWyB93IlqHLQFxukJnjb65PfXtj+XIhljkqtWC9Famio+wAAT9ESxyAni4WTXzPlcqeasc9saV4ZSOJAhrGE0qtgML+zFgoFsTnJ5XI/mn/P65EXM06pr9VyhhyVmFffURwNLJC4FceevEqxOcGBp5ROP4wwUETEwVo3IW6W92nNrlxOHlza05jehTv0IOZ/oBgdO39rFfpty7pZh85RUNSL6Ex67K0CM3/vNoFiLsSXiRo1zFHaz4Pd6fEIPd2KizQzoyi71jmcrl6n+eMnJ2ytvIpBe9vMfHAi4kIeiGD9x/b58LY3J7YJ231LHkfTsXqQIz9wX1hAxDqGLuvL6h7/xzd9yYUCbHQ7+b Cxh1xfDs 4mmXt7mcr3qzNMcYCfyuuojpBJII9BNuCaQpIYaGSrBgnyVM/LTjkW4KPsjETcjsMBhPDbV+n9GZ0bXTtM+ezKoY+HNmqWYSflu/LDUP/7oImUrlm2Mm30NRG2N3OIi0L80tjea9CY3JxoUNDOYKfq002QT6YiQgilMnXDgIkOQkC8HBRkm/aC8OLCkFkzvwAWbHTdickIPw9px1OO2ok9l2D7JPWIEdovEikl1uXFPfvmo5RcQ3tEk2eZ4qhinlfLd/u3ExIh/fTYjxnoY8NqW6elN+c/NeOIHPOYKkVnJat+3t0qHWhRWcQsWHiQhlUE9BQQlaDNHd3MwkacLXRTgQf/8QmSn4ZfKIQcQJmSuVumRw8fEJPfUhUkOKCDuBfHBf71rUYcS8z0uMdol8NyxiEM+ZJofT17i86jmYKuJlw/ZzFv+wAKp5oGNPDqKTChsAJU10y8H3rA8BqXYdZ6lb1pdD8xWaKmn4//gezhbOtyohqnY7PHZ1DTNTEf85m/AFtgRdy8V/CBEIRrpXO6Do5oQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07/27/24 at 12:52am, Adrian Huang wrote: ...... > If we combine all TLB flush operations of the KASAN shadow virtual > address into one operation in the call path > 'purge_vmap_node()->kasan_release_vmalloc()', the running time of > drain_vmap_area_work() can be saved greatly. The idea is from the > flush_tlb_kernel_range() call in __purge_vmap_area_lazy(). And, the > soft lockup won't not be triggered. ~~~~~~~~~~~ typo > > Here is the test result based on 6.10: > > [6.10 wo/ the patch] > 1. ftrace latency profiling (record a trace if the latency > 20s). > echo 20000000 > /sys/kernel/debug/tracing/tracing_thresh > echo drain_vmap_area_work > /sys/kernel/debug/tracing/set_graph_function > echo function_graph > /sys/kernel/debug/tracing/current_tracer > echo 1 > /sys/kernel/debug/tracing/tracing_on > ...... > The worst execution time of drain_vmap_area_work() is about 1 second. > > Link: https://lore.kernel.org/lkml/ZqFlawuVnOMY2k3E@pc638.lan/ > Fixes: 282631cb2447 ("mm: vmalloc: remove global purge_vmap_area_root rb-tree") > Signed-off-by: Adrian Huang > Co-developed-by: Uladzislau Rezki (Sony) > Signed-off-by: Uladzislau Rezki (Sony) > Tested-by: Jiwei Sun > --- > include/linux/kasan.h | 12 +++++++++--- > mm/kasan/shadow.c | 14 ++++++++++---- > mm/vmalloc.c | 34 ++++++++++++++++++++++++++-------- > 3 files changed, 45 insertions(+), 15 deletions(-) LGTM, Reviewed-by: Baoquan He