From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9006C3DA4A for ; Mon, 29 Jul 2024 05:37:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 530956B009B; Mon, 29 Jul 2024 01:37:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E00B6B009C; Mon, 29 Jul 2024 01:37:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CFCF6B009E; Mon, 29 Jul 2024 01:37:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1D9236B009B for ; Mon, 29 Jul 2024 01:37:45 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BC32AA210F for ; Mon, 29 Jul 2024 05:37:44 +0000 (UTC) X-FDA: 82391683248.13.455D143 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 23A50A0008 for ; Mon, 29 Jul 2024 05:37:41 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CmNRIpR0; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722231409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+EKPOgE75aOZI2tE9UJcgALK+u70mSnTgDatO6jtqoA=; b=0sc69hAcDLFybpzzzGN96HukB4fpxv8vyGxUzPQvrk/SuRgvM6WTqKbvXjfJURsg5f/V3/ 3ascy0CYeob/IUrWh5zM2d5owVDeLPTbVNtdRVmM1Et0+i5/NJxthFUzPbSsI49Ym59tZz ScbEOWC7/n8uFILppW9lSXj8SbfO+TE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722231409; a=rsa-sha256; cv=none; b=bplKi9H0+VMa5U/k9uQXSIcivZIr+yX9Wf0Y+HxslHHX3dXU4FpITesUG1msM8kWRHUCHN NilVVw/l1S3xJZOe1HlqvvuQW4D+sdI64yMBH5CTMj7dngHjInTw1egJ9sysdysn/NuCPX 133sf/LKlGrCmkMq+nSAeVfv+zykdC4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CmNRIpR0; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0F44F61276; Mon, 29 Jul 2024 05:37:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70D93C32786; Mon, 29 Jul 2024 05:37:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722231460; bh=I5AyL0PIaSIryk035XCmbFKvN2GWmRrDu3BcdzLjeq8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CmNRIpR0bbPCzvZtjzZUBZNzzLw19QAsIPcwTKiWUr6W5fANJwGVhU+XUMZFJa1Cz oJ5031yoVuJd7QsqTR8dLPvSg3xz5sRbTkXve+WgakjTvVk0MFBIuXrQB0mJFn+32x K1YIpQUB3LwSTa+gpXuvD2RMe6sX2TJNiRZIvpWItla2Skd6AXgarwuOum7CexEiGR aWoWvMf9hRFLERKYn8GSWpVoMCaCSKBe7jdJN7bcpBjXkvNy8lH6OMkVF3o9a+qu9P wa9PXoz4DWL554OL9iOFRvBFNUstd7J0dPkK8UhrxYysFpRkod0d8LRGGX4YaBz1d6 p9bUcHc7Nz9Sg== Date: Mon, 29 Jul 2024 08:37:23 +0300 From: Mike Rapoport To: Wei Yang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/5] memblock test: fix implicit declaration of function 'virt_to_phys' Message-ID: References: <20240729014725.29839-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729014725.29839-1-richard.weiyang@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 23A50A0008 X-Stat-Signature: 1jyxun6munjherfag56gh7u7unynm9on X-HE-Tag: 1722231461-105872 X-HE-Meta: U2FsdGVkX18sBSEPPYfWQu0A8aoi2k+w0/CPVLog2Z2x0M/CIaa/9rSUfZBcZtRan1gehsPaVbYOp9p+Ahh+PQrFvYJjywi5bZm+qTfvPw7T5xNmbX2uP1+dCjKjEJaw3w62AS6xFN8kkrKbIdhpX8UqLJhMH1ezO45SJGIV5JqNweNulX+vrwo1DXhDdkLyCRHsU9eYrOl9toAB36vn8R7KUqfN+HNr5TDEbt8fZ12kGaHj+E+gbeclPlZd3PK/Tnd5Rkt9s8Es2TCaWEYGcbdP4XRwFqWZ3JqXKUEmTKtxxt6pj39yXs//kbQDwqiL4F5hSVVHY0mp0WeAorJsYnSoOaIrvOypj4PFqdSMiZMEyIg+s4r1ZG2qgSHsRikPPU0QnAG7Yj/pJ+F5bWXoa8XNBVHnWRLp2PlVqxfhMms3/tG5SzEn9LfZL9qrMXaPbCNBcbXX1lYZ4YGzdCcuUPyn3NUVsbUTaHSKhQXFErBmQz1LAiiSRslv8wmxcxqIF8xN4e/B2cJv2/gzyqwgdguQP746s3mOWdJBoS7RdkmzqlZ4bd56NrvFfhhhvpz/6VTonOuwm/x2Ro7cxQnq9zwMpNd2tVE0g7uNxN2rXdYU4yWn6KYLR3Fff/syAcIqD9TccmgdfUYVysZ37EnUbGg/tlVmh2YZaFLXTidNw6Xw99tbNxYOQnhUAsWnurDNZoEDyW6+Q8rK7x3aGEuRViC4FrmUzYqgraKsla1p3vPnGMf/XWaGc7eA58o5CtY8psKF7gWO0A9okZiKZZocTd1EBx3f4RMu4yNlpQ7zPwmG04EaLJyO7aHoKmbf1xyVLaW4KFRADqrNVyhkrqysUSVymE8qItpl/utN7aBhRniw35fTNvGY9xIq+n4I3z2PPmHHLAlLGU5cmQBm5Cq2aVfoc4tzMqetj0j2TUNR2AJiPYUSA64ifbS0aB17YdK+lM3ZW01r7Gw0RGcHe5P ieHP+4qN BAP2ivcwGQf+SOL8PlZxDw81a3HXGDoMPQhlxEtNlWdpssQT6qvL1tbKSIChgbM7EkqkpR61VYhnJLTwMM1tnroLrW3/WRIvsTsPe6pmPAeeMrRhMgMUjJXitwxDed1Li8bfTfhbr3jZAnHV2HVJd9HdaLYiZbpLhjsQ2QeclpQH4DiUCxFilky/aTcbKnjCjeeG+xuY7/iilewNYvuPckcRjNegAoOGxhtBWvcz92WgJXSaTveclU8ebOJxQoMfVW0jw30juNyDFnOwVfAOXl6S5iRRGG2tPca6NLl9xigY14M+4rDdjZaqxUmuaTc+cHp69 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 29, 2024 at 01:47:21AM +0000, Wei Yang wrote: > Commit 94ff46de4a73 ("memblock: Move late alloc warning down to phys > alloc") introduce the usage of virt_to_phys(), which is not defined in > memblock tests. > > Define it in mm.h to fix the build error. > > Signed-off-by: Wei Yang > > --- > v2: move definition to mm.h > --- > tools/include/linux/mm.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/include/linux/mm.h b/tools/include/linux/mm.h > index cad4f2927983..9db45c5d00fc 100644 > --- a/tools/include/linux/mm.h > +++ b/tools/include/linux/mm.h > @@ -20,6 +20,8 @@ > #define pfn_to_page(pfn) ((void *)((pfn) * PAGE_SIZE)) > > #define phys_to_virt phys_to_virt > +#define virt_to_phys(p) ((unsigned long)p) > + Please don't break #define of phys_to_virt from the static inline implementation. And please make virt_to_phys a static inline similarly to phys_to_virt. > static inline void *phys_to_virt(unsigned long address) > { > return __va(address); > -- > 2.34.1 > -- Sincerely yours, Mike.