From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BC6EC3DA49 for ; Mon, 29 Jul 2024 01:48:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1DA56B0099; Sun, 28 Jul 2024 21:48:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCE046B009A; Sun, 28 Jul 2024 21:48:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBDD16B009B; Sun, 28 Jul 2024 21:48:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 978506B0099 for ; Sun, 28 Jul 2024 21:48:57 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4880FC0179 for ; Mon, 29 Jul 2024 01:48:57 +0000 (UTC) X-FDA: 82391106714.11.9B15F86 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 8236912001D for ; Mon, 29 Jul 2024 01:48:54 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=axlhYRWh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722217731; a=rsa-sha256; cv=none; b=i4XwDrDdHAXLTNBwUZ4M1Z0YuoA7eSeYDRFfgi7vgGt+CKkW9CnIajW5TtDMJaNFQybUpZ oqRdx0ukGft2LkpVoSj3OkOdiiNg+AXozUfQ+H+KQ0qBJMnFtgdP+b1549ywMGkiF6QSaf /DvZpyJqZ7zUjgZILjmdZ56HnCzrXbg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=axlhYRWh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722217731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CSsERxOF6wJ/t/7TQvseMpYRU+ggIxZpcTX5SMQ5AG0=; b=TQsHrb+3obWkbLgmsCEKMH4vJ3xSIcRLgGvbuNv7oy6Q2LpY+uZNfYKlhyNM3vrlQvxKa6 uFxJ1R29wpUGjEavrdeoLFzW5faBNrgNX53MMUaOu8LNU/a4cRrmXBRx9gZ22abibYkioW /WZEkULu1QiAJbrOocbxNq7fgm/YEG8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722217733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CSsERxOF6wJ/t/7TQvseMpYRU+ggIxZpcTX5SMQ5AG0=; b=axlhYRWhTT/YcI9pfzcHaS/e8uSG6bvs9J+kcg/0fNZCFDgZLMndNDrBASo6orQJj24202 QXi0H3Wyx8ShYfOZsRhwHT0Q+tSrhnkHkU04iagpzi0amnEEyC3MyqJ7GNahNMwTmNCG/t lDaGZqkCyE2I8BicCPECKiBPDi7hdeQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-Vk5V_TZrM7Cxr3VNAnqZ_g-1; Sun, 28 Jul 2024 21:48:50 -0400 X-MC-Unique: Vk5V_TZrM7Cxr3VNAnqZ_g-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 616AA19560BA; Mon, 29 Jul 2024 01:48:47 +0000 (UTC) Received: from localhost (unknown [10.72.112.54]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 56BA33000198; Mon, 29 Jul 2024 01:48:44 +0000 (UTC) Date: Mon, 29 Jul 2024 09:48:40 +0800 From: Baoquan He To: Barry Song <21cnbao@gmail.com>, Hailong Liu Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Vlastimil Babka , Michal Hocko , Matthew Wilcox , Tangquan Zheng , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2] mm/vmalloc: fix incorrect __vmap_pages_range_noflush() if vm_area_alloc_pages() from high order fallback to order0 Message-ID: References: <20240725035318.471-1-hailong.liu@oppo.com> <20240725164003.ft6huabwa5dqoy2g@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Queue-Id: 8236912001D X-Rspamd-Server: rspam01 X-Stat-Signature: 3nt47dj3doswwnky74oe4j55zaed7fcf X-HE-Tag: 1722217734-785058 X-HE-Meta: U2FsdGVkX1+QWcvHi3eSYc4ocjvo4E05gb/A8ykuSWxXoLPm8B5huUBF6DvTFpZjyvZ2acoOW4LQPvmJGyJiN2uvORczg50QLRXSDgKwFq6BDtlV6tHrRw6i8ViKGBcY+OLCX0B280zfl2TihKwymo2DCMcHGJaVhbqBaop/i8ppjVT3IhwzdYvp3ajgQRlUiLB/+jpa2aCkQoLmmXLIvsBq1n8ZH8ykugaX4gwgv0/9FhV38t9J+f/hX90JUiCFhDOx87a+/BJF1GREWeHyK8CcNMCTo8dDR2WnpZewPa2Jw8NkHMb8VFP4KSeacT7rcXk5xWY+Qy8LkJqWbOwJHmvZo68RBpGfLp55lvzWZ1XPShIHZGnvyUXxVvSwYSljfk4cFEAdYm79l6qBM+fPwuWysWegxQvJjAT02eCJTLC3NRB6RR35M7Ez5mhm4EpDqhFaUS9J96iM1G01SGTrc9JiAHnEIB+5mDyffVPX61cpdFTOomoHrVCRas6AyCIjmUs4MSqn3DTO8ej7YYmkPpcQ+vYHaFCPPHoAv7qyT+DauXkWNureafKCIheLLTIh+TzkNncsdCU/ptl9+ZDBJxjL56lo56X0bPX2NODjEGkQyTq2HYM4FcxU9SaQTztlpPo1tipWASlq16gJ36Vgv7P2iCumv+ixtZWwf0frMUltVZo7S14Sc6HUbMvLVyK1IkQG6bOBZixAsLrVdcG+B5o6+Xs/YqS3prC5dtwTJl2jXCYhcvx0OwUGaJ/KEFSfX3N8xEhrlcT/1ZA7s1cZbBvSKrlPuKk4pVCseXEaplxoGrSmUaSM2Uzb7/Grah0vCaUElyVTn1jpmO6ALDGJlx8kKicv7gXEIipdkcJtwa7q08os1nbp1lCy8rBgq/NUdHneVomIlYGUrCox38vLV81Hz5lj1iNP0xfXGREhs+hyE2n2BFWv/64M5N4aWXc2Cs/wj18R+JiobwlXMbE cfu50rDX s71O2fJICbYBizoDWBOefh6gTcHtEAQTki5uAdRKTG5tsXlrojVpfKEYIJM3SbVnkLqQulVIGKdt8k8TN6tatmnwFexIj30hKZWWN9z4JhezmJy5nk468Ok0xYo0UA5NUAlQqFo0nrg2g7zDw5N51ebHMAnMDUlvl2/vMd4INbHGM7qaYoQdplqZt/bLkQ9O2degta8nXI5u3QHGw13Y2bIfMj9iMQzPKBS3Kn/YNljSHsy8YXya6xWZjfzpBte4Y3ciMNGyRAdPPEkuLa3aixPgFw0pAo/cOzwRlo8P4jL9Ybx30XOfON6oFli4RfgjfRJp6+4MoBXooV25jUkCxpDbIwL+YqWHtYoB1xSgLT5aXogoFixlQZzwgm9L8Ydl4hA3dDTbuEHaPsefJM/tDfiF6WY1FoY0a/W6wjHk7zXPDDEQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Barry, On 07/26/24 at 03:53pm, Barry Song wrote: > On Fri, Jul 26, 2024 at 2:31 PM Baoquan He wrote: ...... > > mm/mm_init.c <> > > table = vmalloc_huge(size, gfp_flags); > > net/ipv4/inet_hashtables.c <> > > new_hashinfo->ehash = vmalloc_huge(ehash_entries * sizeof(struct inet_ehash_bucket), > > net/ipv4/udp.c <> > > udptable->hash = vmalloc_huge(hash_entries * 2 * sizeof(struct udp_hslot) > > > > Maybe we should add code comment or document to notice people that the > > contiguous physical pages are not guaranteed for vmalloc_huge() if you > > use it after boot. > > Currently, the issue goes beyond just 'contiguous physical pages are > not guaranteed.' > The problem includes the likelihood of failure when trying to allocate > 2MB of contiguous > memory. That's why I suggest we allow fallback to order-0 for > non-nofail allocations with > your proposed changes. I missed this part of your comment, I agree with you. I think it's doable with below draft patch combined with my earlier draft change. diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 260897b21b11..9ae85342d337 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3581,11 +3581,11 @@ vm_area_alloc_pages(gfp_t gfp, int nid, else page = alloc_pages_node_noprof(nid, alloc_gfp, order); if (unlikely(!page)) { - if (!nofail) + if (!nofail && !order) break; /* fall back to the zero order allocations */ - alloc_gfp |= __GFP_NOFAIL; + alloc_gfp = gfp; order = 0; continue; } Hi Hailong, Please feel free to collect them to post formal patch, maybe two patches, one is to allow non-nofail to fallback to order-0 in vm_area_alloc_pages(), the other is passing out the fallbacked page_order to vmap_pages_range() if it's OK. Thanks Baoquan