From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35A1C3DA64 for ; Sun, 28 Jul 2024 05:58:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A9496B0085; Sun, 28 Jul 2024 01:58:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1329F6B0088; Sun, 28 Jul 2024 01:58:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F15006B0089; Sun, 28 Jul 2024 01:58:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D1A736B0085 for ; Sun, 28 Jul 2024 01:58:33 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 53F03A0312 for ; Sun, 28 Jul 2024 05:58:33 +0000 (UTC) X-FDA: 82388106906.05.2E41119 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id B873980003 for ; Sun, 28 Jul 2024 05:58:31 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="PBDm/HZP"; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722146260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pF3aF24tqOCNSJnT7p2zQC4W8Z+i7/RH8qRJ/EpE9nE=; b=JK57LwGI76jndLYggS+sz5/7W1zB9y0ZPSKXe4WJZTVcBsKBUPwsheTpiVkZnYdznLEXz+ fIybm3yMELH9jIboUI2n36Eu9lcfRxFANvyYe34hhAJ6P24eJeSnvLRYaH3zrJpYuYg91f pyW6PchKWiD2I6e4duUSlPckb1FHnfQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722146260; a=rsa-sha256; cv=none; b=Y77QC2aIwiJifK2EHr93zBzsiOHYnwhS+OzExfkaHz52aQA5jcAe/EUvjt01q+Y+QuctmK shf1VB3lzq+7mMOlAreeXwPKnEDRgRMcMUy5cuZWAYnNee8hPDDO5L1g3juzKXp4QocmVC 3ofpIVZRRJ5MBcvAcSya6uffxdvFvcU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="PBDm/HZP"; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E0B746097D; Sun, 28 Jul 2024 05:58:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46E79C116B1; Sun, 28 Jul 2024 05:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722146310; bh=l4fu/VPqBqd4Eg9e7FeLjCWuP5UxNhkqO9sBMyflRuc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PBDm/HZPOUk6QT+whxR2HASSWZsYcwowzAU2jhucW/jOLLgn7SMSk7BGYjw2UiCKI nHl6l3rEwvu7E/xJB+qdNfCKjD5LchvHe50NSsBc5nqrXRBEhsdYbUg0YVDIWMsaQk XZUYNSK2bRszX78oPIhaaalvWl2YNQfOvASVpK2elDxy2h0z7cVHNQ7VsUEKxYidO1 myeewff7UXt0POGGxxiBN+/FnXSqpBtC90zrN3hjqasMCNjrHZ6Sq8gS1fkwkNRrni v+oapMye9DrzaCCh6HWgReiOwkt8HBvV4r6JxdbJ7u5ve/3+nKNmUIKakMQHH+TDV9 z6urPxOcLvtuA== Date: Sun, 28 Jul 2024 08:58:14 +0300 From: Mike Rapoport To: Wei Yang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] memblock test: fix implicit declaration of function 'isspace' Message-ID: References: <20240725014157.17707-1-richard.weiyang@gmail.com> <20240725014157.17707-4-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240725014157.17707-4-richard.weiyang@gmail.com> X-Rspamd-Queue-Id: B873980003 X-Stat-Signature: 7hmoqbses63p4d3niye1i37kp3s79kjw X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722146311-406060 X-HE-Meta: U2FsdGVkX1+gMMTUND4EUaFQApORh/ZlJIcHgywvL3MYaSw0lvWC/RJztEJgHW/Z0aX7aeiNxDgAmhnGP5zvY3cmnnod5z+P/s9mAJ+yQa4+2DxsWXwEWjMno/NgFvLB/fr4nE+8O/4Q4H2f0lfnXqAMrZgfCCDWNHSWL5ki31cgAcLlwO6RdBFEReY++2os7Yu+klqR1DSOYT/MZbEriA86Z0RI/TGutj08WwV9SBnjc8F1seVMsEwMSSp6CT/N0q/Sy5QHLYMJquUoo33r9hp3lwKjw3wBtJSrURFX9hAkhzMU6laK+ERSU+/aLLqchwZiqSpIR6283vV52YH2iF8GQC9Y3WIKwBic1oGqx2MQ3WXtXO/+doLxy/4UrHXIbVJrbx3vUO2Ih1XpcmHHq5XlWGz4J6UXe1y0rgHmgVV+9Yl1t1DF54S/lEJVRQwlkhHnFZJNV491VXu+0GuyAygab10idsaQxWP55j+NDMQBxEYUXEQOkxNd5okR8z3VYRqu0DIcFl6jfekm3L5ojrvKOB6H2iYnAwRMcxvxQZN+ObvboRcT09b6VbrelQB90fR3/uV+LgP8aUq9I661Bh2mwCGlPuYyZtt6dD+RXZXLKUfW5qI2K+4Fz0H+vqjfGpeO1uItOeF2wOsxNQIjYwzzdXzL8dbFCk49wXYMNBvomMrLNXGTLnsWc6inHWIshQEpKGz+fvEkOu8A23eVFI+EAs+/nghIHyStypFBkYpYxJJnyj5SiZb5SI458HfMRCAebP0As+6fgt2Meek58XjLYse/3Bd1ThSJEh3xM0wPPLafdZHiuy79wrDh2fQa3tY0yADjFyFuZwrz6Tzglk5yiYWaMC9xHoKrbFogSINDtdvn7RRp0FEDM0VQDVY5K8HlqVsqbZvmmL7SFJHTMEqYmRdXOL/TnWJTuue7y1wcME62okVodDe4IZqHE8JieUAwXMyvcewgl9oM1VN GoMDISef vNhMcYyWL3+tkgjFz6mWC17P95avTCEW7fxl6J0tJTLELpcYexBTv9LZ/AAsXHSKFsC3xdxISRnqDxmLY6szTKRYx+7grCYPQpeYuUPnt8UUeqADY5tlADTFSE6erTMyaTmjXt8j34FJkBeH9c12a3eHLjhVJqtJJyFxoPkUN4svvXUAMXHk0U5p7CUfLj42DyJkRPEHaMFzH9DXGKG0a/ASbGSdDx6C9bJMlFHs/eo9SZAQnP8uC0TG0n1GUQvu32d9ksEuCUSQgJX5P4wHVnfpJkyySryqcW/a9s9SOW5NIHbopPYc8SyMkog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 25, 2024 at 01:41:56AM +0000, Wei Yang wrote: > Commit 1e4c64b71c9b ("mm/memblock: Add "reserve_mem" to reserved named > memory at boot up") introduce usage of isspace(). > > In kernel source code, memblock.c include the definition by > debugfs.h/seq_file.h/string_helpers.h/ctype.h. Since it already has > ctype.h in tools, let complete the include chain to fix the build error. I think it's enough to include ctype.h in tools/testing/memblock/linux/kernel.h > Signed-off-by: Wei Yang > --- > tools/include/linux/debugfs.h | 2 ++ > tools/include/linux/seq_file.h | 2 ++ > tools/include/linux/string_helpers.h | 8 ++++++++ > 3 files changed, 12 insertions(+) > create mode 100644 tools/include/linux/string_helpers.h > > diff --git a/tools/include/linux/debugfs.h b/tools/include/linux/debugfs.h > index 4ba06140b1be..a99b0e0c5414 100644 > --- a/tools/include/linux/debugfs.h > +++ b/tools/include/linux/debugfs.h > @@ -2,4 +2,6 @@ > #ifndef _TOOLS_DEBUGFS_H > #define _TOOLS_DEBUGFS_H > > +#include > + > #endif > diff --git a/tools/include/linux/seq_file.h b/tools/include/linux/seq_file.h > index f6bc226af0c1..8614fc2ca695 100644 > --- a/tools/include/linux/seq_file.h > +++ b/tools/include/linux/seq_file.h > @@ -1,6 +1,8 @@ > #ifndef _TOOLS_INCLUDE_LINUX_SEQ_FILE_H > #define _TOOLS_INCLUDE_LINUX_SEQ_FILE_H > > +#include > + > struct seq_file; > > #endif /* _TOOLS_INCLUDE_LINUX_SEQ_FILE_H */ > diff --git a/tools/include/linux/string_helpers.h b/tools/include/linux/string_helpers.h > new file mode 100644 > index 000000000000..bc11a762be8c > --- /dev/null > +++ b/tools/include/linux/string_helpers.h > @@ -0,0 +1,8 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H > +#define _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H > + > +#include > + > +#endif /* _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H */ > + > -- > 2.34.1 > -- Sincerely yours, Mike.