From: Mike Rapoport <rppt@kernel.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/5] memblock test: fix implicit declaration of function 'isspace'
Date: Sun, 28 Jul 2024 08:58:14 +0300 [thread overview]
Message-ID: <ZqXd9vgalOSI_j3S@kernel.org> (raw)
In-Reply-To: <20240725014157.17707-4-richard.weiyang@gmail.com>
On Thu, Jul 25, 2024 at 01:41:56AM +0000, Wei Yang wrote:
> Commit 1e4c64b71c9b ("mm/memblock: Add "reserve_mem" to reserved named
> memory at boot up") introduce usage of isspace().
>
> In kernel source code, memblock.c include the definition by
> debugfs.h/seq_file.h/string_helpers.h/ctype.h. Since it already has
> ctype.h in tools, let complete the include chain to fix the build error.
I think it's enough to include ctype.h in
tools/testing/memblock/linux/kernel.h
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
> tools/include/linux/debugfs.h | 2 ++
> tools/include/linux/seq_file.h | 2 ++
> tools/include/linux/string_helpers.h | 8 ++++++++
> 3 files changed, 12 insertions(+)
> create mode 100644 tools/include/linux/string_helpers.h
>
> diff --git a/tools/include/linux/debugfs.h b/tools/include/linux/debugfs.h
> index 4ba06140b1be..a99b0e0c5414 100644
> --- a/tools/include/linux/debugfs.h
> +++ b/tools/include/linux/debugfs.h
> @@ -2,4 +2,6 @@
> #ifndef _TOOLS_DEBUGFS_H
> #define _TOOLS_DEBUGFS_H
>
> +#include <linux/seq_file.h>
> +
> #endif
> diff --git a/tools/include/linux/seq_file.h b/tools/include/linux/seq_file.h
> index f6bc226af0c1..8614fc2ca695 100644
> --- a/tools/include/linux/seq_file.h
> +++ b/tools/include/linux/seq_file.h
> @@ -1,6 +1,8 @@
> #ifndef _TOOLS_INCLUDE_LINUX_SEQ_FILE_H
> #define _TOOLS_INCLUDE_LINUX_SEQ_FILE_H
>
> +#include <linux/string_helpers.h>
> +
> struct seq_file;
>
> #endif /* _TOOLS_INCLUDE_LINUX_SEQ_FILE_H */
> diff --git a/tools/include/linux/string_helpers.h b/tools/include/linux/string_helpers.h
> new file mode 100644
> index 000000000000..bc11a762be8c
> --- /dev/null
> +++ b/tools/include/linux/string_helpers.h
> @@ -0,0 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H
> +#define _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H
> +
> +#include <linux/ctype.h>
> +
> +#endif /* _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H */
> +
> --
> 2.34.1
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2024-07-28 5:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 1:41 [PATCH 1/5] memblock test: fix implicit declaration of function 'virt_to_phys' Wei Yang
2024-07-25 1:41 ` [PATCH 2/5] memblock test: add the definition of __setup() Wei Yang
2024-07-25 1:41 ` [PATCH 3/5] memblock test: fix implicit declaration of function 'memparse' Wei Yang
2024-07-25 1:41 ` [PATCH 4/5] memblock test: fix implicit declaration of function 'isspace' Wei Yang
2024-07-28 5:58 ` Mike Rapoport [this message]
2024-07-25 1:41 ` [PATCH 5/5] memblock test: fix implicit declaration of function 'strscpy' Wei Yang
2024-07-28 5:56 ` [PATCH 1/5] memblock test: fix implicit declaration of function 'virt_to_phys' Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqXd9vgalOSI_j3S@kernel.org \
--to=rppt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox