From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AD05C3DA4A for ; Fri, 26 Jul 2024 20:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 872886B0085; Fri, 26 Jul 2024 16:22:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 822FC6B0089; Fri, 26 Jul 2024 16:22:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EA246B008A; Fri, 26 Jul 2024 16:22:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 519E76B0085 for ; Fri, 26 Jul 2024 16:22:09 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0044A1C03C3 for ; Fri, 26 Jul 2024 20:22:08 +0000 (UTC) X-FDA: 82383025536.17.9C8A5C3 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf27.hostedemail.com (Postfix) with ESMTP id 1240340025 for ; Fri, 26 Jul 2024 20:22:06 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vayo67kX; spf=pass (imf27.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722025301; a=rsa-sha256; cv=none; b=EJhYf+Mg2+jYwHBVJVdy57FrnrPTLIVhmYnlT1+FpcS/o61hwTZRyKq7C8xTCrHqDOSrV7 XBHGqjWFzkWJ2vsm79cHSMlnCWNmNsmD2w5eJ7F0soCvEgtSpFyhJD3oFGCdiGG7DWghm3 ImTXFAJMYWpjDInqQ9p/z3bINCn1jQY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vayo67kX; spf=pass (imf27.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722025301; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I04y2vzUB5spbfoQs+w/eH+P8YuqTfLTQOdpnSD5X/M=; b=NR7biS7oDV3YFuaje9O07Npea081MflL+VEUTpXdbO/iYJ6PV6ykckiJzCR8zG9DMmDpms prapnVKqpECkKahFUFLm7/SVXv6qxzQOjen8Xj+iWdb7VO6CTwIQYBm20aqr4JTOIkI/3q +j0Op4xtYvWV/2H6gaNQ0YsZzXnrwV8= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1fd66cddd07so9051945ad.2 for ; Fri, 26 Jul 2024 13:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722025325; x=1722630125; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=I04y2vzUB5spbfoQs+w/eH+P8YuqTfLTQOdpnSD5X/M=; b=Vayo67kXgKfyZ19zVT7D9Pg6ItUeJpeDff19eqxnrvQXnnI8coldNa1ASoY3OMN2D9 PDJynjV0CmmcPnQuEYQ63s0vFdrYMVLrHYgBXkzddLs5oSitCpvMW6h66O7pbZGiLKzo q3dZtf+2NKPKEf39orsnInBWUeIZrdEOOY+5zBjJKwl5aM14Zzj17o/hy5Pkxo+IDxNB xyZzUOQuryY5kXvjlZkxStKSVi948pKj/vxMIe+Miu3fM3t3TOANr9ep13lXLrE15Uuu evk94fwkrVOt6+Hb70dzl1RWTgb2lo9knLuQ0J5/5P8GTypEHenFgKx6iP0bX0uKI89e U5Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722025325; x=1722630125; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I04y2vzUB5spbfoQs+w/eH+P8YuqTfLTQOdpnSD5X/M=; b=CP9fAmg5CmBHwDpgfgALOo/qNQzCwlV+AB1/5xFtY/kLnjl6yFHdBhz7mCdtMzcbkc z1YuXAvUCdAq80p2Kkoi2fjIJckqHLR8kvJSrCYnrTjZxxMdWNAudKhCwIi7u6dJSkwQ zQ7W67Xbc/0hVzkMza9Km6SuziCOyJudzi7y9fE+lpCmdLywxcsymBbC8+kyd/B9mD5Y GTCNMqWH1XBA8VCW1myrVmlVPUaeT4f7Bh22jlsGieeYrNTT1p7FVtFYN5u8Gm/68ASA Kch5sZ5pPJ5R1ZR9Ofu/FdYSllXOB9RWlLTxrdLC/xKEqGpqXeDzwHqGryUEtjMDs8Nm izmQ== X-Forwarded-Encrypted: i=1; AJvYcCUQGfS0uL1dQdjCe5QKWF/eulH1x+/1MBbKswAk7RJUf7OcWEF2lN763mtXlonboyqXqPgLV/yJA0Yt1SxWDZPx+a0= X-Gm-Message-State: AOJu0YxuOXWLhS4DDSw8P+DHbmqx2dw/NGXIA0ZM4lDCRSBmimt/e6qL ug1HrEarcskl5yG/FYci/A8/82f4H5x6IA1T2q/vrWLYUQPLGWhI X-Google-Smtp-Source: AGHT+IEmKAq2//jjyyQHgSfVFlu85kePhlWK9rvBRE8BIl7ji0JX/M16W7mdND1KTEuRHR07HFZmOw== X-Received: by 2002:a17:902:ea01:b0:1fd:d4c2:a2ef with SMTP id d9443c01a7336-1ff04839437mr9349225ad.21.1722025325480; Fri, 26 Jul 2024 13:22:05 -0700 (PDT) Received: from localhost (dhcp-141-239-149-160.hawaiiantel.net. [141.239.149.160]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7ee302esm36896745ad.145.2024.07.26.13.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 13:22:05 -0700 (PDT) Date: Fri, 26 Jul 2024 10:22:03 -1000 From: Tejun Heo To: David Finkel Cc: Muchun Song , Roman Gushchin , Andrew Morton , core-services@vimeo.com, Jonathan Corbet , Michal Hocko , Shakeel Butt , Shuah Khan , Johannes Weiner , Zefan Li , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Waiman Long Subject: Re: [PATCH 1/2] mm, memcg: cg2 memory{.swap,}.peak write handlers Message-ID: References: <20240723233149.3226636-1-davidf@vimeo.com> <20240723233149.3226636-2-davidf@vimeo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240723233149.3226636-2-davidf@vimeo.com> X-Stat-Signature: iejuh39sdb8ycimurocowjpbqd3yhu3g X-Rspamd-Queue-Id: 1240340025 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1722025326-836346 X-HE-Meta: U2FsdGVkX1/FgwRp25fDHOHklvl8wfSctjvRJerukuRVUjaACH9mQZgg2dyC69vhgMnwMtZlTViTdfVKG/QM7sdYOFyZ8FyMajOoefUEZ9njcbP2C/eqkGuKd54I0j8jrhy4xshX1zxrz+g7O7f1kMyNW6Kko0FKQ6zRP4Ze8WX4TKPYWQxnztrBZWE314VQMpWyOchXcrDtFqPiyvD6y2A58Dt2uB16ne5IXwJHDwHF9+kuJpviAKWB72yfzrNqZLOEB2yQHV5H/ahlNlJ3RcD77xbFYaivQEIQxxiBjiX8P9J9ba4/WEFaEDT4BcMind9CHFSBcPkJT9kia7JF2VEcgLco1+kyH00sMmZUnf+a3UnkWbD69F9/JhW779RQXU+FmElHbumYR7UjVTUptvqrHunUD+N3Sa0yqKo/uJwb3ApAyHiuHzLRqv4Mw9TGazAQp98K7D2wNaLujDixwOJWPdnlJxdj+wSDahuVjJ1pRf+z9DGTlGGpeLJLX/JBYJ+k1v1ZApTlFbT72xD7MowGFY3CmRXsSJ80W0ORP12bmLL0Lbtvt0vlmddePw5CzG68Q5Ho0n2IHsgidhNPdbKC6PzzfTEGW2V/cCBWS5DlHDol6EWFiRb/VL85wt/5ql85sfF9ol1m7Y9aFwS7IwRY9HQWQr1/3XFe3qZWLbguQX1wBgYhcLQt2bLc8UCtA037bmzCNXjLHlvjRSJUOL95IhXf8aoEylaDBsN3U9lD5cDZvHnjt9w4v/4s+TmweuDPa7QGszAdNhSDRV6uAcfKZMGq2JkZzDq/iNnyAAxaiqphUDLAfitk6b7qQJEORqqERdn04Z9aTdqDLrdgsvahEk2w5SJos00bzl6MD+HlAfjY3Xs3dv/a205Lb5kO+KhQ9+v8z4TPDASqge3MY5KyxdtAAxhpFsYibK3s4TWpIf715ZMGbhcbKRqwoM4ykGS/qTEnZnD0vm7z/n+ KdbgQ2/g jYMCRpwNq6E34AT1LSMOyvVkXbYXdZKGxP+3/bySOmuAcp4QiSA0to1wrCZYmF4AVF4veu2c4G6ePrMHceicK+U0w3amr5dW7ScDw8fDmIEBS6VmSeoQhZJX2rjJvcLF5l/103a3H87iAK21CUUTl4VQIDJlpcLDXVyVd2p0UP4OeiJk8wAZO085BwIg3IHOUUU4pkxBl5nZ+K2pIusoC3AN8gBMcuEtHsOfySl7/Vw4IJh5B99MmjgWf8cPHx85JZ0BhE35kcLGSlLlqTfZX0Z88owo2T437Hh9wGEdsdSHZX31hUr9vLOMoNvwbJWXF4OpFp0JZP/67tgI9Me3P1XHTSQ34135RW3U0zuWBwdZzV9akX+vxzHRpXMwshR5vwjgxwT/xQBrBo9UJWcPg6M46vz7Mwd1ieIYqrdMNuoNcQJ5wNdx48MsVT8z2NR7WIgbG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, David. On Tue, Jul 23, 2024 at 07:31:48PM -0400, David Finkel wrote: ... > + A write of the string "reset" to this file resets it to the > + current memory usage for subsequent reads through the same > + file descriptor. > + Attempts to write any other non-empty string will return EINVAL > + (modulo leading and trailing whitespace). Let's just please do any write. We don't want to add complex write semantics to these files. Writing anything to reset these files is an established pattern and I don't think we gain anything by making this more complicated. Thanks. -- tejun