From: Tejun Heo <tj@kernel.org>
To: David Finkel <davidf@vimeo.com>
Cc: Muchun Song <muchun.song@linux.dev>,
Roman Gushchin <roman.gushchin@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
core-services@vimeo.com, Jonathan Corbet <corbet@lwn.net>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Shuah Khan <shuah@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Zefan Li <lizefan.x@bytedance.com>,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
Waiman Long <longman@redhat.com>
Subject: Re: [PATCH 1/2] mm, memcg: cg2 memory{.swap,}.peak write handlers
Date: Fri, 26 Jul 2024 10:22:03 -1000 [thread overview]
Message-ID: <ZqQFaz07jIg4ZKib@slm.duckdns.org> (raw)
In-Reply-To: <20240723233149.3226636-2-davidf@vimeo.com>
Hello, David.
On Tue, Jul 23, 2024 at 07:31:48PM -0400, David Finkel wrote:
...
> + A write of the string "reset" to this file resets it to the
> + current memory usage for subsequent reads through the same
> + file descriptor.
> + Attempts to write any other non-empty string will return EINVAL
> + (modulo leading and trailing whitespace).
Let's just please do any write. We don't want to add complex write semantics
to these files. Writing anything to reset these files is an established
pattern and I don't think we gain anything by making this more complicated.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-07-26 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 23:31 David Finkel
2024-07-23 23:31 ` [PATCH 1/2] " David Finkel
2024-07-24 1:55 ` Waiman Long
2024-07-24 11:49 ` Johannes Weiner
2024-07-24 16:11 ` David Finkel
2024-07-26 20:22 ` Tejun Heo [this message]
2024-07-29 13:37 ` David Finkel
2024-07-23 23:31 ` [PATCH 2/2] mm, memcg: cg2 memory{.swap,}.peak write tests David Finkel
-- strict thread matches above, loose matches on Subject: below --
2024-07-22 23:55 mm, memcg: cg2 memory{.swap,}.peak write handlers David Finkel
2024-07-22 23:55 ` [PATCH 1/2] " David Finkel
2024-07-23 14:29 ` Johannes Weiner
2024-07-23 19:45 ` David Finkel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqQFaz07jIg4ZKib@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=core-services@vimeo.com \
--cc=davidf@vimeo.com \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox