From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B162EC3DA49 for ; Fri, 26 Jul 2024 15:26:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAB736B0082; Fri, 26 Jul 2024 11:26:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5B2B6B00A5; Fri, 26 Jul 2024 11:26:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C22EB6B00A8; Fri, 26 Jul 2024 11:26:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A6D3E6B0082 for ; Fri, 26 Jul 2024 11:26:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 09BD6C19AA for ; Fri, 26 Jul 2024 15:26:29 +0000 (UTC) X-FDA: 82382280498.05.73E0F97 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id DEF47160024 for ; Fri, 26 Jul 2024 15:26:26 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iaPCpA4S; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722007585; a=rsa-sha256; cv=none; b=c761sfNL7VQ/Tmrl28+t7iGhCVkcxrCVHxyvDiRBZMmyRPgUilqjVcpJSPlC15Qvdd98kl VNMb/hy5M1oCEQNfvqNJL5q1mShB/0uGKIu5Vo95clHlAYBf0kQF2NXkEn4LS6WDtKk3Ht 1ZR15u8hneKWNylKwnrnjIQl+iWwlHE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iaPCpA4S; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722007585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HQNYIPK7LP0OA8/oIlZfnEndy7+rTzNkw4e6NMHkIEk=; b=7nYFQgUiDTUP0wVVxjnE9+NVh1uEniIJvaewzOwrybHsvCPiNwR4XCt8M7oPDh/agvbUNy 92ksklZlivNQJQZ1fh83FU0WPaaLcKpj7kuNgg02v7pS33frhqne1oJZFbgrOteXukXMRK btFH8DLNrE5SfiqGQX3Ph6I7lRhFaEk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722007586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HQNYIPK7LP0OA8/oIlZfnEndy7+rTzNkw4e6NMHkIEk=; b=iaPCpA4SF/U/RO8TSNxCWAHJqzuIFKx1meYyNaQjXw7EKCMYJky7VtzK/X9swveIzofFEu xbcexK2jZJyX8im10zJ5j/+ZBbQbZuBDwbNdb0KtPuyKhDaf8ayPyiu9vwbikq9I7UTsUt X/aTFKMoxasaMKJT9VJh7FKMNksSj0M= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-483-XrZq8IKxPs2FIZaF3epD7A-1; Fri, 26 Jul 2024 11:26:24 -0400 X-MC-Unique: XrZq8IKxPs2FIZaF3epD7A-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6b7a0e7b823so1406836d6.0 for ; Fri, 26 Jul 2024 08:26:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722007584; x=1722612384; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HQNYIPK7LP0OA8/oIlZfnEndy7+rTzNkw4e6NMHkIEk=; b=L2CSLVZst0tYM/+nRc9+lG4awbnK1xH2o64nPv/c5rtRwLANx6Bj4okl+T7w0AWGmt 3RvCo/etZBjmLxehytfHJM9erGdbl+lJM/nnFzPMUaJbdYPzQJgKXlfLn57+va/9AsB/ JX2wBGDt5mzFIyTaTiOOG4VLC+PKijVsF8T7VEXQYMqgOXOknj2G28LLtSUg/AHkXcb1 i+WllZWOVuycpMvB2DnebqK9rDu/voJe0knzJ6XABAD52SbAC1qRvE4iVnOJw9KgJzPC qENzr9HEsjTF8mFVuWKPGntR9UFA/rQXyoWW2zLgM2VuHSlKwrrBvsMRbSz0OxHtm1B9 DZBA== X-Forwarded-Encrypted: i=1; AJvYcCUMon77FUAVFIPqEu00WHXTfyV7BsIxiiS15uy0uiPQppqR9/PIIJiu3NEpOnWzL7myzT1oit9u0A==@kvack.org X-Gm-Message-State: AOJu0YzYZkLwaNYMpjuslJhp829/nOeIKIG8D+iRFedFYLchx+K0TJ/Q unMIH3SokQIeKIoukC/OvNM5DueQcjRhMk5L1FcNYMTCG17mybuKhjg3pYRM54SLfr0PiwwchZV LjfUxXSw0wzrp0InAyOdO7Ru1df5wWg3v0JmpVc/uzE4z6azY X-Received: by 2002:a05:6214:d4f:b0:6b5:ddc3:f610 with SMTP id 6a1803df08f44-6bb3e2d368amr41051776d6.6.1722007584077; Fri, 26 Jul 2024 08:26:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCcOtmcKwMx6TXZjWFNTwpesdryp7ZSGGDThfHjU5YW3rn/SrGkp+RZ71WQrrnKaPTgZEnHg== X-Received: by 2002:a05:6214:d4f:b0:6b5:ddc3:f610 with SMTP id 6a1803df08f44-6bb3e2d368amr41051676d6.6.1722007583704; Fri, 26 Jul 2024 08:26:23 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bb3fb0bf4asm17526386d6.139.2024.07.26.08.26.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 08:26:23 -0700 (PDT) Date: Fri, 26 Jul 2024 11:26:20 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Muchun Song , Oscar Salvador , stable@vger.kernel.org Subject: Re: [PATCH v1 2/2] mm/hugetlb: fix hugetlb vs. core-mm PT locking Message-ID: References: <20240725183955.2268884-1-david@redhat.com> <20240725183955.2268884-3-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240725183955.2268884-3-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: DEF47160024 X-Rspamd-Server: rspam01 X-Stat-Signature: pcmzrsoryaugxfkjnsibhzhdwr8zk3p1 X-HE-Tag: 1722007586-163939 X-HE-Meta: U2FsdGVkX198lS7rngW5HxIrTLvwHbh76oU249TnAfi37nQnnL03zplNyfohIRnBdFET8IQhuNFVWblCwjkBFaU5IWIYzXWwIINDKVSuxKAzBju3t1J+gnFfRfDn0QGzlnSL+lNSm1m9pBDsdLl630+jTj10DPqatF8Bpd0cTB7cq2jV0OzGjHYVt8uLl1DGyp7gcD9eEyIbezgelyfWlGgWbIGEJcZ9INJeHpDWME4Y0efGQzchlpto4l2Qz3ZaJWo+dd3h6DlIzkg/2yW6sqU56EdHJ+b/9cQEGpLX7Z4yiz2obB9262DvtQct6uu21C3wQhDlcfIMcmIfy0bVOjXLmyvYpHgG/okv8RSPbwfhHtHnssK7r+X1gaYfKeAE5u2NDodqHtqjhL07UvBKHNv/IJCJurcD/xarkegijW0gxlO3guG/+RoDlD7a/leUkcncpN4J2eULJ52vzyWCmeZ4vqtrLNn3aEx+gDc/TJK/vgG1TL9ComKObSDTCUXj6UV86UV0fYgHYduB3BkDEhdRvLiTRJEygLT0/Way8bzioSPRYA7TNOOwQXf3EusQEsgCRYFAwyBYxAwFmjT5gHz7vYRVCwcd+rrHOOC7svVsiDg5hY6beT/adVMCzjldX3tyOh4Ydc2GWEc8wkHGiBSysinkjWyAyUFJ6geRQK9UtPgeuNCvIJbzr83/6Ii8ktpo7875O0I34HHXPELEXmwSX1MeIbmQPXJ8r2ncT6xrHnUr6dWdSRa83Vu9D35XlBF7+/JZoqfZZoSaFHr7fwSVm8LVsDRZLRMiAgGucW9XEFY60RcTtzpaGBh0aAGXUGzQ/SlZmbQ8PXN5DNFH56ZJUcQ9PgiZ/c+WkSlUYJiKLpdyNFfpgPQnBwlVm0Q7AWjLW/foKd6cSYdKa9SyHyN9Bjuq9DrgA/jGH+U+MKRfGSkulhkjR6fAmYTdQ4sWqfhBrZrRPiSHPsqgHAo hQL/4ai+ l+q91VXUMi9IiR5DcGuSa5V2CcaGqBsdIs0m254zWoYUkR2NXD2CtKXLAzglV8NUFse26Ld89xew5yGIpwdn0G/19m4mVpricfRYxBvX6L1gtrvpBLA9smt7qCH7zHEkXfIkiyfjYSzKdd76RzXI9tgpS0ng82WBmx0ix92l1oS++WBFd0OGLynP2UzeO001tzox5jArAE1XE0aJdVJmkddBzxPvccMr7izNib1PgEeTDoQvHdov1uNVJM73XVDSwjUzdQQxIGn1uOuRMVTr8jUAcLj0oLzY/XkpXKiOOPjJ1Gjr26rsqEo34IVC7q74qzlNxinhZ2+aWD0VEfnl4Jm/VKAZIA75zRW9S15O6NEoKYBaFqaxtSUt8oLK2D31D0dgtinK0ddj9fp69zsJji0+tYiV22OVA4mD/iFGJpKNXXoiHcF1B6hwZp16pnZALBYRydZ0+OfJpLuIfwI/owBiQEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 25, 2024 at 08:39:55PM +0200, David Hildenbrand wrote: > We recently made GUP's common page table walking code to also walk > hugetlb VMAs without most hugetlb special-casing, preparing for the > future of having less hugetlb-specific page table walking code in the > codebase. Turns out that we missed one page table locking detail: page > table locking for hugetlb folios that are not mapped using a single > PMD/PUD. > > Assume we have hugetlb folio that spans multiple PTEs (e.g., 64 KiB > hugetlb folios on arm64 with 4 KiB base page size). GUP, as it walks the > page tables, will perform a pte_offset_map_lock() to grab the PTE table > lock. > > However, hugetlb that concurrently modifies these page tables would > actually grab the mm->page_table_lock: with USE_SPLIT_PTE_PTLOCKS, the > locks would differ. Something similar can happen right now with hugetlb > folios that span multiple PMDs when USE_SPLIT_PMD_PTLOCKS. > > Let's make huge_pte_lockptr() effectively uses the same PT locks as any > core-mm page table walker would. > > There is one ugly case: powerpc 8xx, whereby we have an 8 MiB hugetlb > folio being mapped using two PTE page tables. While hugetlb wants to take > the PMD table lock, core-mm would grab the PTE table lock of one of both > PTE page tables. In such corner cases, we have to make sure that both > locks match, which is (fortunately!) currently guaranteed for 8xx as it > does not support SMP. Do you mean "does not support SPLIT_PMD_PTLOCK" here instead of SMP? > > Fixes: 9cb28da54643 ("mm/gup: handle hugetlb in the generic follow_page_mask code") > Cc: > Signed-off-by: David Hildenbrand Patch looks all right to me: Reviewed-by: Peter Xu Thanks! -- Peter Xu