From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB8BC3DA7F for ; Fri, 26 Jul 2024 12:31:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1E3F6B00A0; Fri, 26 Jul 2024 08:31:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCDA46B00A4; Fri, 26 Jul 2024 08:31:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B95066B00A5; Fri, 26 Jul 2024 08:31:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9C6506B00A0 for ; Fri, 26 Jul 2024 08:31:41 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3DEFA14182A for ; Fri, 26 Jul 2024 12:31:41 +0000 (UTC) X-FDA: 82381840002.06.912D23B Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf15.hostedemail.com (Postfix) with ESMTP id 4286DA0023 for ; Fri, 26 Jul 2024 12:31:38 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WYNXgyVl; spf=pass (imf15.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721997049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PJrBvfo2zlrU7WCRKlFsrOVZ5D9Gg7mMKJJjvLeiuM0=; b=BeTxAbai0yAo5binWCLpovBC/5jqncVcS4ro9OlKuejhc85fQ1QHzs453DwMusNCtx5poo C4p01TJoY0Len8FrANE7PGJnDk36ZGpEoGqtn84JTUPDsZkRCyF05eXlu2zL/y9gdEo9Im 9Y04/gXmnArmghel0L4opZShGxwf5fM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721997049; a=rsa-sha256; cv=none; b=4RELvTjS1ZzDbAdcQDd5N7UmVgpz78EhL/rNpkdrgGn/BhG+SjckxEh8abY/4cheZH+/X6 7RIKdt4YAyCHbt3EeeAEWmGg5EOXQyAuiLErkvFWgFFrIc0W3GIo1iHTJ3tObad43WwAM8 t8G7B/wFITfp8eW5d6385vbxAMKTmPY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WYNXgyVl; spf=pass (imf15.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a7a9185e1c0so144688266b.1 for ; Fri, 26 Jul 2024 05:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721997098; x=1722601898; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=PJrBvfo2zlrU7WCRKlFsrOVZ5D9Gg7mMKJJjvLeiuM0=; b=WYNXgyVlNtUlywsOnclpuKj1whpsB1b76yF1F5MXRUuC65UufP1PeuDj4rjI3eiQgv Cy/TtmEuie8TlDXO08njF7LZzIss26EAKD+HYeLyZOEE9dplZaH1+bBjbs8aG3BhbTu2 u0/b2X8bPykSFBY1lrE+V6j/NZtplC7LTT4cDZRcJ2xJvdG2cv2eAWJIYdsbqP1WY0BK VHGk4/9YBw1S1gfzNtzIrpNwu/4fw4XN+d6zGqIblVsrQOOQN/4BndwQHGlnWgSTzGI6 T1tEA4Jsz1kvbz52jGtCbUNOj1+PsHcT8Jds7OeFG120SyjrcV8/w1mQZIlufTkj7vOu vbWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721997098; x=1722601898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PJrBvfo2zlrU7WCRKlFsrOVZ5D9Gg7mMKJJjvLeiuM0=; b=DY4itrJNxTFkyRMhiRDzDyVEXz0Wvrv0uUFAsQU8+kyg2D5IlDlex5dGAZkPRldxpU 9DxH3pzmYHvNQZ+JOu6vRbamRs/BooDkMMQ9aq5cpvjWryxoA8wkGQtQdtReaAJInFjc xGjWTDDpJbnZe68R/VxIJl4YgpNVHUwI8Xy2WZaFvdaYCcvrivFeck42Umd1kKeJr7ox 4tkNi++soCrK0f3qWbQMg5BX2NkzunqHsQsN3+uSz1GxyAqLXHF2IJMMkDTCXo3s+W1R gkyR3W8i2viW7eX1Yi8u25omUMs77xepj4ea73A1+6TqTNdptZ/mVauaGUECKRq8t0WI cEMQ== X-Forwarded-Encrypted: i=1; AJvYcCXGTYqLqz2z3JFtwdTbBzg7O5G7VVceQiTNzoZRA6Taa5WMrZQAzDenjPVnGflBreEbaetaA8vw/s8qMCxcpkfPv14= X-Gm-Message-State: AOJu0YzpcOVGiW07Df6jgyOk2t4y0J7h4aOULRJhSWgMSJnAyml7LAcY FGzCZXtXCPXIT04m4oCcJ5SBr/iCHJMpEHme1XoV5/So8RjO0i3q X-Google-Smtp-Source: AGHT+IEiAOpGjH+5oVk5mj6Jk5s6YAp3UHE1t27F/6HE/HVaR3ZJ+Tl6UB2NPmtUbvMeoJdyrCjl4Q== X-Received: by 2002:a17:906:2acf:b0:a77:dc70:b35f with SMTP id a640c23a62f3a-a7ac508186dmr379063066b.58.1721997097510; Fri, 26 Jul 2024 05:31:37 -0700 (PDT) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad91005sm171415166b.173.2024.07.26.05.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 05:31:37 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Fri, 26 Jul 2024 14:31:35 +0200 To: Andrii Nakryiko Cc: Jiri Olsa , Andrii Nakryiko , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, adobriyan@gmail.com, shakeel.butt@linux.dev, hannes@cmpxchg.org, ak@linux.intel.com, osandov@osandov.com, song@kernel.org Subject: Re: [PATCH v2 bpf-next 01/10] lib/buildid: add single page-based file reader abstraction Message-ID: References: <20240724225210.545423-1-andrii@kernel.org> <20240724225210.545423-2-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 16ubxfjzbqrmak6syepma3cqodcz4iho X-Rspamd-Queue-Id: 4286DA0023 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721997098-316868 X-HE-Meta: U2FsdGVkX19lpWG13yJlv/etEHGIiFQ0AwWSMhqmbRdxVJqSzK+b+9jERhTyl9ti4WJp5VER8lE1t75g8bHxwM5mWPiN9Z41XKHhM/C/8levBPhgX9EbKO3ft07gUfVSIvzi+s+48qxw7eG3Ee7dn6ioVsXQ9YFMta6aJIOFs0WKjAnIYOVsa+oRALKa1DmTIygUNqT9EmPD2ed5idcdtmlF9PZOlIFAZE9qvsGvyWKmtXg8MJuBj1Apg63E7xxZF/0yjJmMjTyEVA9Kd0gPitzmbeSG5xm+Oxc7j9dIXw2OtIvYZt6AuV1Tvo9WaiY1bY3cjnfEYm2zHu4o0q/XOLOWWfATcThZHdO/dggu6yIt7y3x+nqdcwrgZssvV8b7K+Xupk3Weo8GSNVYjaClLG8km1P+WJ+f3v0XBMmW9iEpUGxUtPm6GgDSnvJVLYpN7x0dEfSTxsOG9I/CJpIn2YfSeXRI/pBqaVgScqTreRaTvQDvPYttk27m6rFBtEs1hCt9gFqtw1D2NAUFz5cFR3GY3i10HB+f0jzwQQ2WaehW6470KHwejYpQRLVjXkzscYPJOSGJ/+h7sMcEIY07iBEoQRXWVvIMaZnmIfLRC1M6L7UrYa3T7FAq79pD6VppLesJeNikWBirP4ZMuNTisEZDv/UvnI2yopo/JQe7gbnzQJge3mRyr9cPrNTFlarynt92EItStcIfY+z0Fg42UERN3qX5UoGOxYxgHQGL3WB7D+hwps+q3ekNDGfp+1P/zMqHjBddZn9B6Q+X143s52WS4qDYBMEH7mwR9qCXD6fxeb6A5flaNmqx8HBEkLI/ooCANnWwsuErDj2q/k33Sd3mDq7RzQWNo6fCXP6M0BMW5lCta/jKjaXl8g3w5L9Irix3WoZMUSPRwSjYD8NbDQatonms0AuK+e/DRbx1oRdcphc9ofh9Se7q9WcdCjc2cyWVwOlYMJjdtkGyiMF bIIIdAss 3P9jG8wetpR3MWcKkLGlpp14iDwQ8qUhtLlsLK0mMLLjXCx7zzp2N+4A1O1n4sxvaNZT8M3Y7GwbMfHT5zZw78fuUMbAWrFx8MUeNaGCOtpVRkbwspJ/sMVmfVgSJhiNSjobpXt3EFg/cb+BbQrfqeomdqXs9Jk7ZiVewcsMX556FPYSiFZzAjyDlpVgyUHaZIoK5XcATE3obRNQXFCjSQ1v6KPcDbYr0zkIZ23g7PBVDyKcjBbt2U7RpSK76mMKeNvpULuMP9KIxzro7dgRmTafvPeo9QG+A8IxWyYn5bootkUNZug4e1I8KkM4ifGBRa2hGdtrWAb0d8G3c/Aoo3XC/eUAHgncr+VoDYY00d/emWPRL5QrHY3CBD78MsM9jyOQUYVSQYLLP0PxR0TzzfVXY5gFmmGXqSceqxp1CBd+7sU6uUE1hqQQ0JRZEHDLQwm+uFWa8mXIAyjAjj+eWl4TU7n7QoNrGA0f560kZsdNLr8P5YD5Gow69QUxXggv5NHja X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 25, 2024 at 12:58:04PM -0700, Andrii Nakryiko wrote: SNIP > > > > > SNIP > > > > > int build_id_parse_buf(const void *buf, unsigned char *build_id, u32 buf_size) > > > { > > > - return parse_build_id_buf(build_id, NULL, buf, buf_size); > > > + struct freader r; > > > + > > > + freader_init_from_mem(&r, buf, buf_size); > > > + > > > + return parse_build_id_buf(&r, build_id, NULL, 0, buf_size); > > > > could use a coment in here why freader_cleanup is not needed > > > > probably better to just include freader_cleanup() call, just in case? ok, future-proof jirka > > > jirka > > > > > } > > > > > > #if IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID) || IS_ENABLED(CONFIG_VMCORE_INFO) > > > -- > > > 2.43.0 > > > > > >