Re: [PATCH v2 bpf-next 01/10] lib/buildid: add single page-based file reader abstraction

[Jiri Olsa <olsajiri@gmail.com>]

On Thu, Jul 25, 2024 at 12:58:04PM -0700, Andrii Nakryiko wrote:

SNIP

> 
> >
> > SNIP
> >
> > >  int build_id_parse_buf(const void *buf, unsigned char *build_id, u32 buf_size)
> > >  {
> > > -     return parse_build_id_buf(build_id, NULL, buf, buf_size);
> > > +     struct freader r;
> > > +
> > > +     freader_init_from_mem(&r, buf, buf_size);
> > > +
> > > +     return parse_build_id_buf(&r, build_id, NULL, 0, buf_size);
> >
> > could use a coment in here why freader_cleanup is not needed
> >
> 
> probably better to just include freader_cleanup() call, just in case?

ok, future-proof

jirka

> 
> > jirka
> >
> > >  }
> > >
> > >  #if IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID) || IS_ENABLED(CONFIG_VMCORE_INFO)
> > > --
> > > 2.43.0
> > >
> > >