From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0ACC3DA49 for ; Thu, 25 Jul 2024 15:48:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD0836B0085; Thu, 25 Jul 2024 11:48:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7FE36B0088; Thu, 25 Jul 2024 11:48:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A48126B0089; Thu, 25 Jul 2024 11:48:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 878DD6B0085 for ; Thu, 25 Jul 2024 11:48:50 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4C74E1A118F for ; Thu, 25 Jul 2024 15:48:50 +0000 (UTC) X-FDA: 82378708020.05.1047FA3 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id AEF2718002E for ; Thu, 25 Jul 2024 15:48:48 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721922479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mB7RDGJP+V2z7iYc0eLSsUomYnSG75kC6TcuY0knlE0=; b=Peke5+SlQ7fatx/eGnQZZ0B748vnnzbozaU6v5uRNJyBYN1N2SiHVvnKReQ6bTBoflUO5D jjZDAv0zvzdCF3u+7zOLqGDods4ysnILBjLRnxzk9cmqmJv58KLXODKqJ+XUq4lXB79d6f ypMvcQu7cLVFaht8DbMWk0flYm8afB4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721922479; a=rsa-sha256; cv=none; b=TvOEM7lxA80as0AJkiVue/7GDAsAhR49V614mUkNFyhnhiDg4EJWVRnQ/UqbxeG/5sygMf Sy2r53HniCwj1ebIm0TWzY+EOt1UEcmh5M1qy47GFTEOXDcgzoggyanaZ93izGOU+iW3Oa WcGrINQtaLxC6/U4hoLdDrfI0upCdYU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78FD21476; Thu, 25 Jul 2024 08:49:13 -0700 (PDT) Received: from e133380.arm.com (e133380.arm.com [10.1.197.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FA393F766; Thu, 25 Jul 2024 08:48:44 -0700 (PDT) Date: Thu, 25 Jul 2024 16:48:41 +0100 From: Dave Martin To: Anshuman Khandual Cc: Joey Gouly , linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 19/29] arm64: enable PKEY support for CPUs with S1POE Message-ID: References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-20-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AEF2718002E X-Stat-Signature: wpir4mo3c3wox6qzuym5ypue6w4g1j4w X-HE-Tag: 1721922528-274472 X-HE-Meta: U2FsdGVkX1+V47b4usWUAOPk6q2W/1bQBxYE79seH+yHygfFYkEwGqUNJwt//plQp9ow0WhqqY/VpwKcEk5h7H7BR3Ul5zrmvqGingzWKi4nE+ecyhsEab05bmNdZ9a9DvYF7AjMpf4NHlmzgbiqb2i5EsrdgL90KD60FvzR8ftGgvA43r1daNUw44iXYNNBkEdhT4LulyXr2hRrEg0uBpanng0YT2iieDkgXkK9tKyIRt+GzH4rqQYbQNDmAC/FeVxIS9QdJqOK2AsS81ckSFrXgpXMJXs7ZEpX8qsav1j8nrvKLynNbQaZkTPtyUXKod0M6DowvUue5TWdkhK3cplhL0oLp8G9ZDiuTCi/C7pHUOUQCHRTl5F+HrrWzVHPDTutmhlb/NMIHYROmCnPzlwKkcMFA30EDoLrw7c7RBVexgunkllHKp1CNnjaflV3s6wgNlCaMJH7i27tjlPci6Dw2R1HaeqxohmpK0lZ3vqZJc/ADt7eQsrew7h8l5/lj8sZaJAOzgkZZO5Dle2jgbw0hYnRLf/e3ls2Xw4NJduG041FU5rQ5SDgqV7hI1X8RHD9pVKGjF6rpsaybhnXuWDL4PHefZUjPz29EQAXgZJacKmObimTkEcU6/evUHhQLSSMLsnMggEI+tguzg1iFiRZxrpW1QzIfN5fe6tudzUyXswt73aKBbsH0NC/ExPplNG60NRmGSiUvnrd/wLLj2Zf1F7IvORSGxlDxoL0ThcZBm3pS6P1DLt1dNww5cD2jPi+eXvjDQevSTfgZ2nA8Y3zt02ZnLICyi2x1BpvdOu9eK0nsY/UylA3UEHVYSpUKLpnVhbrzLIGSBUBh/uoJ4JaSOkDLeEwCj92t5j8DqRaoi1YpmuDyLas0JsfjWn4tJaCl6PXkeG6mCWscPl1PgbjzFzDFyDJaDzEY5EvwXm1YzbrJV9uASEC9NIpjw0gEQ+qoe0HXiJIu7WNRn9 4kCGRgcB nj2qfjod+FRpzYfgR+EK5uGtMZZmSmMUjUdJfpL2Eu0TX9UQdmaAMvOnsJGnWpkZM+2kl621NE73sFNE8RaG/Fc0Mo8diGJ06lAQp32QYMWwXTTaOHSj9xHSNhRO7F72EdGjjkuPrtBIx+f6gOr2mgtMVrQNhUOrwrX8e7CA6Q5SNeEqh/W0YQN5ECu+N1J6HuF7yGB+etimxnE0GKqoO+VukU+RzbrCcM8aNWBOz9fy4H5s53RfniYgYcZH4cNjiKBPcY6qeBStPdzA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 16, 2024 at 04:17:12PM +0530, Anshuman Khandual wrote: > > > On 5/3/24 18:31, Joey Gouly wrote: > > Now that PKEYs support has been implemented, enable it for CPUs that > > support S1POE. > > > > Signed-off-by: Joey Gouly > > Cc: Catalin Marinas > > Cc: Will Deacon > > Acked-by: Catalin Marinas > > Reviewed-by: Anshuman Khandual > > > --- > > arch/arm64/include/asm/pkeys.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/include/asm/pkeys.h b/arch/arm64/include/asm/pkeys.h > > index a284508a4d02..3ea928ec94c0 100644 > > --- a/arch/arm64/include/asm/pkeys.h > > +++ b/arch/arm64/include/asm/pkeys.h > > @@ -17,7 +17,7 @@ int arch_set_user_pkey_access(struct task_struct *tsk, int pkey, > > > > static inline bool arch_pkeys_enabled(void) > > { > > - return false; > > + return system_supports_poe(); > > } > > > > static inline int vma_pkey(struct vm_area_struct *vma) > > Small nit. Would it better to be consistently using system_supports_poe() > helper rather than arch_pkeys_enabled() inside arch/arm64/ platform code > like - during POE fault handling i.e inside fault_from_pkey(). > (FWIW, arch_pkeys_enabled() looks like the hook for the arch to tell the pkeys generic code whether the arch support is there, so I guess the proposed change looks sensible to me. For the arch backend code that is agnostic to whether pkeys is actually in use, system_supports_poe() seems to be the more appropriate check.) Cheers ---Dave