From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C44F4C3DA49 for ; Thu, 25 Jul 2024 06:16:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B2AA6B0083; Thu, 25 Jul 2024 02:16:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5622F6B0085; Thu, 25 Jul 2024 02:16:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4028D6B0088; Thu, 25 Jul 2024 02:16:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 204986B0083 for ; Thu, 25 Jul 2024 02:16:40 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9D97CC0E33 for ; Thu, 25 Jul 2024 06:16:39 +0000 (UTC) X-FDA: 82377266118.01.0442391 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf13.hostedemail.com (Postfix) with ESMTP id ABFE32000A for ; Thu, 25 Jul 2024 06:16:37 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NnxgEZOu; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721888149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SCMsnLhIBfGDTZvGq50b4YwFdguki325nqZTYfqn2Bk=; b=xGWjNS0PBaK1RpmVGZk2hADc5DMEcW8LSKUbS4DVEk3tqrjwy5gboTBI7MJeiie2MUSfSN XSqj68laDBPdKJGzDmsF9rn5LPBSLsiQaUpJTVpeM7RL588bTMZ3CoJnA4ueg+VkgI6qFV atzo7Eeg+V6hEi89OpbDwPYqPfqIHYc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721888149; a=rsa-sha256; cv=none; b=K8F3NMfDKb+wbjGrAbiiLwNBinjkM9GAwx4lhN+Zfy/PtrVYvyUtNApyrbDeXdwR1hWs+6 0X9YGU7lYarq+ZB//7hcwOPd8/+FQhB37ecBrF/IPbbMSYeYpgylu370CmYu7mfH9oSsdq b9bljhkNRIhOlO9vBmN57gL3n4/ezKs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NnxgEZOu; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5a15c2dc569so377136a12.3 for ; Wed, 24 Jul 2024 23:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721888196; x=1722492996; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SCMsnLhIBfGDTZvGq50b4YwFdguki325nqZTYfqn2Bk=; b=NnxgEZOu57/VcCv69+mFXqoCfCz1kJHICmBQUx6oXejPhh4+z8xbh+MjhuyW0D3bzt b2YhO7fSxeN/OyumJoGlyDPZQf8fCjGNpVJroMniwELr1jPOHTz+6AKc6CShCU9DubiP JqbyaW71Jqslo8YJtOehF22kvQbpM+h9N/oEjSLCWOH/DRvx6KRh30iIRdcUJGpi2KVx k+eEwF0weMmOJNZeKud7rhhNByilfVPMIjePmh1uMI4TEd6GNecy0eXk6h8XuR5Huicz 0OpmQOy+Ot4NbIGOQsKuWym/TkeOOWQu0Wbb6fbW5frZ9xdoHbIsTmGl5pMFHbQTvkDM kzyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721888196; x=1722492996; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SCMsnLhIBfGDTZvGq50b4YwFdguki325nqZTYfqn2Bk=; b=LdLu0QJLCmznLCUcSam85DUqeEMLW4d+gxZ7WCNq7wmLuFZY78y1qK7eF/FpT9hK/f J8ES1be1CiKgxZTGTTfYQkRwgCicm5dUVVPflAqNvlXuN216i4bQ80bpBGw0kTMlATZu tTKOJER6Qf/oDUcHVW2ccl2Vpp2QBV8aU+UBFKd5mcRpQ51GGyMlzUUtNxl3i13dDAyE b8PlAOdNRqqYSOqS89iGp6xs5sdfdxwClKw4CrxogO2HUCpRAMaDM4M9/PgvBuJN/jIO rNou+U1bt9u+VoS7KnDDi70xjF/cXL40yNxziOKhaviBAatSHoPpQvzJlSKb5kRvM9Hm nGWA== X-Forwarded-Encrypted: i=1; AJvYcCU3ubojCBX/GLrBp6PGwBUT7M4a0CD9ChP662s7KB0V8wnxrqXLYd1elDJemY4aYrdQVfFS0Wu2pRhQOJd9YuJiGOI= X-Gm-Message-State: AOJu0Yww7cktrVaXOzTHygAOnEiAWStaUeY/1UKZ61lZvfPyPt7JTX96 vgJv7J6P2zFQ0kKbGR0MAOuAdzLvxESqp3YzV1A4QXPw2BIa/urygOS9SjKrs0g= X-Google-Smtp-Source: AGHT+IGBztCb68n+EhFJJcTiqpcVxJPCtmyGojfDvnZ2Zcc+j18B5Mbdbp+cC1m5vz8cmK2nGoe6CQ== X-Received: by 2002:a50:8715:0:b0:5a1:de88:a5ef with SMTP id 4fb4d7f45d1cf-5ac6396b16amr799200a12.27.1721888195997; Wed, 24 Jul 2024 23:16:35 -0700 (PDT) Received: from localhost (109-81-83-231.rct.o2.cz. [109.81.83.231]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac65481320sm444363a12.81.2024.07.24.23.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 23:16:35 -0700 (PDT) Date: Thu, 25 Jul 2024 08:16:34 +0200 From: Michal Hocko To: Barry Song <21cnbao@gmail.com>, Davidlohr Bueso Cc: akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, hch@infradead.org, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev, hailong.liu@oppo.com, torvalds@linux-foundation.org Subject: Re: [PATCH RFC 5/5] non-mm: discourage the usage of __GFP_NOFAIL and encourage GFP_NOFAIL Message-ID: References: <20240724085544.299090-1-21cnbao@gmail.com> <20240724085544.299090-6-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: ABFE32000A X-Stat-Signature: u57ruc1djm8gog5h7p6kbznk13pcydnf X-HE-Tag: 1721888197-109584 X-HE-Meta: U2FsdGVkX18NoA9ww3yDYbLOJHbe95JwbYi80LoWHDGatcIUJ55D9T5VYuPKMZzfIpw7cffz/flGxHyEwBWRfOw4CPeO3xDwzvNBlLefaxJH1QrnKfO5NRQoPVY/iIhAVOCXbnwv/srIO6ibuQWBPFzcmuvIy3d+AjI1n61iL28AlfNySGNO4fmUnw87BWW0lnCa9dVs/8njBRRo6Z0PhSLi4fDepan1Dn9laBJDyCdT1DRzXSyrdjaIOI+X8++EEbOJT/2kQMGwxMqcbpN7okBaTfdrpG89dfqHu24gmizUqABqBGCDEmZ4/m1jRfOSL/XvdNpNp6XSaDaaN22dBFluTOPilhMC3uAK5KXXbE6pRmJZuq9hRMLKp9ifwh7C/nAvcx/4w6v405YW59rqcSSQ1MOU05VY+4wSKrjVZFCf51h36Wy403T2Hv7eLoWmqeg+QLgRJ81ITJVA8erl7pFqJBNd53AlHD9gy9K79jdqfCK+T12yaYVGZ9QrWhw8g5wQFIzYJF4KE/ha5YTpAlmBF2hEQnzcIWZtT+VwcTR/pwnCkbN1+NvbGzkDi/E9nM2yo3VSrEV6lwIhziWeEqjCh6Rgq1JhH0BzKaHQ2RsXkAPZhdCrnF3RZwyKCVvCuwQNoIBoF05vC8c+SeOz9lfhG/fr5XsOrAWvj+fzkPD3HBcemJQRYe76y7wk/nXNssKQrrfzvejqYAROxrlhLyL9ledoBvE3LngF1MWzxDR8TpLxyJg8BsrtJhjrPAN6KVc9jnEFHqbRH4Oj1IY+kv+UtctMqU9P9noFrsJ9Kw6PmrfMJjryeCBh2qCduLHI9qd1O3iDJajWYL5dOm04SpXKOzy40gRm+6/K10N/9qJiwaKZ3hWj2JO3IQ4AOin3YEWg8HRiIQ/FHeq9JsG+MQYRyUYLgwlH0izLGJxsV9ToivSc0N7E26ilwYycifqYL9u+JoMwrGaS70j58wd XKEnGcqZ IPgxGbA+V8Nw1ig2Hf91qSb5vF/OkzZ6QoNHGUuNuBbEHNtwwImkjYMopDkGejUY6eDLxeMU0CVNfASujkrpHTD64JTwl1n09XVTGYg2h5gVorYeiuZWDUvOGU2+Oz+KWPsiAJlJzkcJbJe5GsJAAq7bSX3mudikeNHNxHRr43DZp2QRDfko18QoULv9LOaqnpMScHvTu5qc/I7NWcAJHoS3zzZmshfqu5KA5eXkUHOas0bIybaCfBeulaE48c/wLlLZsPEXHR0wHVlOym30VTHyIOUnDsEBmlSApB3Ytm5sX7g5rVDT9c74P8+oZlQxK/UobhJ4iiWXjdaeyCxLFCKCKRGgLBseHvomrFgbo1m34q+Q5SBH0OLrFsgfHVjQYmExvjIlx+kvA7Oiyit1gCNohsCPRWM9M0AhjpG9PTximcEXnZXE9vb3YgwirfnpiQqc4o6N8+GBaY/aCpNiHsJ4Ter0pgfv5Yq0cLps/v+BWj/ZQSfmBjHwXVC/5DJD3+ruHHID+fL57wLMU8KNzhnlR+VsdImZOJHT++EBPMWiaZZA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 25-07-24 13:38:50, Barry Song wrote: > On Thu, Jul 25, 2024 at 12:17 AM Michal Hocko wrote: > > > > On Wed 24-07-24 20:55:44, Barry Song wrote: > > > From: Barry Song > > > > > > GFP_NOFAIL includes the meaning of block and direct reclamation, which > > > is essential for a true no-fail allocation. We are gradually starting > > > to enforce this block semantics to prevent the potential misuse of > > > __GFP_NOFAIL in atomic contexts in the future. > > > > > > A typical example of incorrect usage is in VDPA, where GFP_ATOMIC > > > and __GFP_NOFAIL are used together. > > > > Ohh, so you have done the migration. Please squash those two patches. > > Also if we want to preserve clean __GFP_NOFAIL for internal MM use then it > > should be moved away from include/linux/gfp_types.h. But is there any > > real use for that? > > yes. currently i got two, > > lib/rhashtable.c > > static struct bucket_table *bucket_table_alloc(struct rhashtable *ht, > size_t nbuckets, > gfp_t gfp) > { > struct bucket_table *tbl = NULL; > size_t size; > int i; > static struct lock_class_key __key; > > tbl = alloc_hooks_tag(ht->alloc_tag, > kvmalloc_node_noprof(struct_size(tbl, buckets, > nbuckets), > gfp|__GFP_ZERO, NUMA_NO_NODE)); > > size = nbuckets; > > if (tbl == NULL && (gfp & ~__GFP_NOFAIL) != GFP_KERNEL) { > tbl = nested_bucket_table_alloc(ht, nbuckets, gfp); > nbuckets = 0; > } > > ... > > return tbl; > } Ugh. OK this is a weird allocation fallback strategy 2d22ecf6db1c ("lib/rhashtable: guarantee initial hashtable allocation"). Maybe the code should be just simplified and GFP_NOFAIL used from the begining? Davidlohr WDYT? For your context Barry tries to drop all the __GFP_NOFAIL use and replace it by GFP_NOFAIL which enforces __GFP_DIRECT_RECLAIM so that people cannot request atomic NOFAIL. > and tools/perf/builtin-kmem.c: > > static const struct { > const char *original; > const char *compact; > } gfp_compact_table[] = { > { "GFP_TRANSHUGE", "THP" }, > { "GFP_TRANSHUGE_LIGHT", "THL" }, > { "GFP_HIGHUSER_MOVABLE", "HUM" }, > { "GFP_HIGHUSER", "HU" }, > ... > { "__GFP_NOFAIL", "NF" }, > ... > }; This is a prrintk formatting stuff. This counts as low level functionality. -- Michal Hocko SUSE Labs