From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0684C3DA63 for ; Thu, 25 Jul 2024 00:25:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B896D6B0083; Wed, 24 Jul 2024 20:25:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B39656B0085; Wed, 24 Jul 2024 20:25:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A00E96B0088; Wed, 24 Jul 2024 20:25:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 82C466B0083 for ; Wed, 24 Jul 2024 20:25:25 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C1B1D40CA5 for ; Thu, 25 Jul 2024 00:25:24 +0000 (UTC) X-FDA: 82376380968.07.A85CBD7 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf27.hostedemail.com (Postfix) with ESMTP id CEE9240017 for ; Thu, 25 Jul 2024 00:25:22 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wo4xR7ko; spf=pass (imf27.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721867098; a=rsa-sha256; cv=none; b=m0jBBzchl1kDJ4OL3j1zj66g3UCK/yCjAyxX93htB2ef6hGf1hGc/2pVtqoUjItZ5x2jY9 HbxGbGDVFTP9a1mbwN1TY1f6R0MPvbBim4QaeACSdjRWK0kg0IBMJDRaIlpX+m33YZBeKB vGKwaMNsw/lLnXTO/5x8ci9zTBvT1SQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wo4xR7ko; spf=pass (imf27.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721867098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9i8xCty+wlBhuD77WYEniSm6emEYVnVvP2uoezmkh64=; b=xsb8IQsF/14b/M9bKMjRHEYq/9tOSD31UHEoH6+CgLGH3P/gwVp9ZVdfl6ZKfEMJKfed2E 2RjrY8SuPyFhPo3jrxLkVOQURSCfm5CyNSHanlKsUVn6YmNEVAKxAFH1G0VgkUPFr0YaK6 RZMMhvcW4eY3Ha+my8zuv8oo3X/CV4E= Date: Thu, 25 Jul 2024 00:25:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721867120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9i8xCty+wlBhuD77WYEniSm6emEYVnVvP2uoezmkh64=; b=wo4xR7koN+IE2YAJNgdj54jBKUwwPmzby5nMtbcIECvDux16LD3XnjhPUq7e/LM+1+UKM5 nicWcrdd6vSe1CaGTuAkb+MOi0vLvJZruaVrzXL6ZL6Ph+q0Jz2bc0/Qc47fC+wqY8JdoB 3JNu6c1DvsPNgU6zJxUkZwq49EmOjhA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Kinsey Ho Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song Subject: Re: [PATCH mm-unstable v1 0/4] Improve mem_cgroup_iter() Message-ID: References: <20240724190214.1108049-1-kinseyho@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240724190214.1108049-1-kinseyho@google.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 5sy8fsgk4ctp3nceyfmc154gbh6u4na7 X-Rspamd-Queue-Id: CEE9240017 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721867122-451560 X-HE-Meta: U2FsdGVkX18SgYW9+0h/iM+XmIXt5JJhLOUHekHk/Ewlcx9iM9LH+VzuR/Fp6rDejXkywV1fu7sELEHz5B/fR8nx6jv+dGrFusrB4DRNOEUTHI5AUDAJu6wFAQ8h0yJVs+qVTpKLjPEei55vqQZeIUxEAjlIs/DjOTCciP1tStSp16jIiMlTDrtLF6Hk4dPAerjahnZvMjBvlq9svkItnEzd8pkCF/GSgiPPkPpfyVt5nV7rwfFweQJRmXEETdsCV1ReEK6pBtyqcQpfWjwx8j75/TEPPlOiqdI3cTzAII2VT+o3ceMO9jCeHttftZ/8mo/pHxZO2qCOVLOXjz27E29qpp+ktW/pAOdWYnIzVcF/+GQSgbSB5lXdUgWmPbdNsSirSkBRIc9mKrp+8n2BNg9za3AXYDD4NQE+oJOaTQqzaAs7VEDIhRe4XaD990PPpP+9zD+i4E7bmoy6E9vTI0Ud9Q2mVzfc2rBidnVj/KHN/4W/Z57cn4gs8Mzpp8eEUwh8bM0ByoKJNDCyZ9XqysHJTyc1iNr3Rx9zJeG9e5jrUXnol/vnliZQ+G0xhVb7aPGcK5LAhQocdCZobtQ154p9uD2PdyD2vzGsnp2jluER73+1Bp56EExltEoXx/wol2IdO7DDcBjrashX+3tFuIkoO56F08Ii/LQr5+WqS89sM0bh9zfjg6jBV6PWe8AsMaJ6K0jFJhUck/oIs7SQdwV6Z6hMjz6k9b+1mVs11CVg/BT1daa41bKBMU/2NAS/ovRS+HVZ1kosscgkwLerAccCoeMNlZfJNHiGg6izcJcmZBUm2HpkRhMxbDHfMXzp+zefsw7IKND7WTHTj6fL9NEeacDqZQyEfK6J6rRZxumdZnTtp1uyOiyRYNBGPK5MLvGTj6IVc6oqC3GDqIhOzYhvOmfBeY5tb+ICeaSyZqdOtiIN+sqEleJ+KR+BdXWz2PZijyZbdaSCMAEzogd BN44kTzE Q//x2rcUB77WirXUYFVr7y58xCuW5/DjOCgNhvbREptawndSfli1d9TQMRjmSiGNEWSlkkKVT6oziXyVyZdvN82vpOeSzMm1OWgf+2Hbj7YaOZTEQ9QzRyA3V80rF6Y/nEwAFfPmCtpE20r5NpVxxEz9LxMMnvDmAkkZyF6zAs/mnRR40WUwFOf3mEe5bv+Ff8PEUk3Z23VlEFPAWE7sKs0ifO6HFMp/gCUIn16naloZo/mwmEjYqv9BN83d3OhFK95eVFTvouY8tJpoNqcfaD+WXl0rXWObmw+Z6j+1olI6fC4Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: cc memcg maintainers On Wed, Jul 24, 2024 at 07:02:10PM +0000, Kinsey Ho wrote: > Incremental cgroup iteration is being used again [1], but incremental > cgroup iteration was introduced for cgroup v1. It hasn't been fully > maintained for many years. This is a bold statement :) > This patchset improves the reliability of > mem_cgroup_iter(), along with improving simplicity and code readability. > > [1] https://lore.kernel.org/20240514202641.2821494-1-hannes@cmpxchg.org/ > > Kinsey Ho (4): > mm: don't hold css->refcnt during traversal > mm: increment gen # before restarting traversal > mm: restart if multiple traversals raced > mm: clean up mem_cgroup_iter() But the series looks great to me! Acked-by: Roman Gushchin for the series. Thanks!