From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 952CBC3DA61 for ; Wed, 24 Jul 2024 15:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E81D36B008A; Wed, 24 Jul 2024 11:15:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E30B16B0092; Wed, 24 Jul 2024 11:15:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF8256B0093; Wed, 24 Jul 2024 11:15:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AC2556B008A for ; Wed, 24 Jul 2024 11:15:39 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 272D61C1CBB for ; Wed, 24 Jul 2024 15:15:39 +0000 (UTC) X-FDA: 82374995598.16.62CD624 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 04BD114003B for ; Wed, 24 Jul 2024 15:15:36 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i4CieoHv; spf=pass (imf09.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721834088; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RUkRMF0WARuhu/29TKm6k3lHbJ84nYZGVBuX5dht2/s=; b=eGLgh7aP1Eg1HSND+YfHSMQBhuY8AQ35JddHqwEFW3YGpN61RNIEhUWrARRZVM0KGNObbX LQ4kYp2AW8KPMUigbDfaGXDlOt25P9L1TGDQe01Mnp0qJHT60wdnensKC8QMBKZCrKIeu/ SpqKRs+eP6GxGeygZ2wkXs6VcBBRASQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721834088; a=rsa-sha256; cv=none; b=qZALsHzzP4JcDbGggQwyoa88xvHLs2Im7yUSTFmudlNLnbK9hTWsWBHa+JcKc7xzuIkC/j 7M8mjaWYhN1vJiCosoMZzMlfPvkIi6VCAInUEHazNFDmIVxKHp5iHUG1lNGgIF/KCXe5Fn 2ee/gAyJy0Y9Q3iaOTRGmMLeQqdtgFo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i4CieoHv; spf=pass (imf09.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721834136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RUkRMF0WARuhu/29TKm6k3lHbJ84nYZGVBuX5dht2/s=; b=i4CieoHv0yqTh4tof9tgWVXqmlbHkOwgg/vDkmaE/2H3vw/jxk/r5/BqMDjziXEfb/12gk fZEJNiJ/HcYVBJGALvlGizgHdH9x1Vw1AS4voRFt0JvZ30jUkTA8jOEyMlptGMphQGFBbc Hc1mmlB3DACUUYTM0RCisKi1WvcU3oU= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-JVrtnZh5PKav-JT5_pA8Kg-1; Wed, 24 Jul 2024 11:15:35 -0400 X-MC-Unique: JVrtnZh5PKav-JT5_pA8Kg-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-447dfa83881so4446951cf.1 for ; Wed, 24 Jul 2024 08:15:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721834134; x=1722438934; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RUkRMF0WARuhu/29TKm6k3lHbJ84nYZGVBuX5dht2/s=; b=QOuRlwSt5nGynPlbd8bpt6r3jwo369FVs1DBZJGoWtzoSplgl9RTOPccgLUvYXZPPz eZIU6Zv16/Uln+EmsjvvWSaIGkKq5yqcbRh1+28PTftk9jNPveXU1u1f5SgX0udzYQ6w r3WTrbKBSdsZ6QTeRVu9zM37Kc4lCOL01Q7yGvyvbeqnhWc9MIpB9DwhvUKHbSg8wTcM YPZnDJgWA+IFoMWLmmPoyhNwEUJsmOWQjnV3CHiBCO9U+2dvtem6rtDhTHcQEhEju8Du /wsUBduKvmVD29x8nspICvATjsLj6z/ZSk/LclJCZ5ihlBzlNGvohDaezsXJXqroCrR9 HqZQ== X-Gm-Message-State: AOJu0YzWiocaBdLC0kiKbwI000B0QIPRdutv4MgVhNi52DWWeQGo3a8O BhX++0icmgH/KlvHCwY/fKA8LVRWiRnqDAMTaOmHcvr05vkriofA6mhLVN6Toe/LqY1jbMf4ZAo as8JKPy3B3UVHjJBqoXn988y9W6hp7d6ugvquze3MsoU+SAmPoMzDhoUPg0dMjFImh5TB6IfZ3y /KRrfxdF7zuTqCz+42ycqOlBWTfSvEyQ== X-Received: by 2002:a05:622a:1b9e:b0:44e:d016:ef9 with SMTP id d75a77b69052e-44fa5387fb4mr104228351cf.9.1721834133912; Wed, 24 Jul 2024 08:15:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHg7QRjC9p2RRivLgKhyMUlPKC9on06KG9o9HrmhOfrljMwx/vxFCI8Gd5BGr39JQzDkkckHQ== X-Received: by 2002:a05:622a:1b9e:b0:44e:d016:ef9 with SMTP id d75a77b69052e-44fa5387fb4mr104227901cf.9.1721834133260; Wed, 24 Jul 2024 08:15:33 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-44f9cdbe223sm54733741cf.83.2024.07.24.08.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 08:15:32 -0700 (PDT) Date: Wed, 24 Jul 2024 11:15:29 -0400 From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Dave Jiang , Rik van Riel , Dave Hansen , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Matthew Wilcox , Rick P Edgecombe , Oscar Salvador , Mel Gorman , Andrew Morton , Borislav Petkov , Christophe Leroy , Huang Ying , "Kirill A . Shutemov" , "Aneesh Kumar K . V" , Dan Williams , Thomas Gleixner , Hugh Dickins , x86@kernel.org, Nicholas Piggin , Vlastimil Babka , Ingo Molnar Subject: Re: [PATCH v3 0/8] mm/mprotect: Fix dax puds Message-ID: References: <20240715192142.3241557-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240715192142.3241557-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: n1b6t4x34i7u46rg83ogeyfqqb8yi1uz X-Rspamd-Queue-Id: 04BD114003B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721834136-682581 X-HE-Meta: U2FsdGVkX1/Fg8so+MobK50OszgvAhInWwWb/4qIIzZWvrwNnzpMTrk7zhsyOCtnW8bE23vYMEa3dXiMn8jmyr1uKMCOFgSEBxA4bs9zAYYfwuC+L8Nng+woPMqcJPk+jRfbIy3cRY+dYaqrgBHCOuHWzLsts83MmJBS5ngopbyIal377dji2pGVyfuhKIQLxjJUuwvpYDQHbnUjL9N3Jyw8bcxG0PD5Pd/pvMEIZ0O9BQji94p06+M8kvh767JA6xtzFi/ZhN2gCd0BDvRQzndbDR8AekC1tGoZCNJv0/ymGqeRHBX5aQmlS0BJll0vIias2TEfYSvS6AALe5rkfmcODfZKJuTA5jszft3CeJAM7u1TnCV9cHpKERZ0PVRaSYE4FbyqpJdWkHKyYuJxw7Q18IEcLqaAjmYifEUTATxR0hiZDaJtHpouKjjN0sXktp63Oiq1Khn0/9cNeq2vViUrYpk+clOVCmoe9NTPqBDrpexC1tM1F6QTVhIye128r+4ExxzainR4yWKi+ce4XYkQ6wAAF0phcnkKwKWApyXcuZ/5FrJDCEalgLN4ibaFz9+lXT7AlLq9r2ZkSv0+wA2i7q5aPrJcb66lzTEb6f+7TcrsZ4Xqi4hollUOpWA5PcEIQyZmJyEoqA+NaEn3eN9XbYMKlYeD0ISYgDLnr6Tnafbv3KgXky/6P/Q8xo8AwWwFsmf1+6ROg7zzx0eSGG/8zrS9zz3dxVYvKR3H4+1PaZNwYCSl3+bxTCxVmvHG6+2i5TA798ydHdQCB3Z91ei0zmKRpwhQvd0GFNi1bDQrFBbDXX8S9UMz/DQ7hfyV0GbF0xBGynttj7lYBFCeoXrZ+osGUohnxLMXpsrgkKAMBLH+OWAVCDbTSe66PJD7N9gX1eY3YypKfkw9jaGr/nwgJZY90OAezg0a1L/CDLarapbqcrAyJJLxd6rqaCYG2PDLxXcSM255niUTCau FJKd9BSD bjmu7CiY7GpcStSN9IgJtzvXUfRX2ENVXRjrBpvNcji9Im0dHXufxhbGVF2FEQh8VX+vxNaUW3Ly+RIHmtOdpP+tOy9qDDjw1Y7WjpO5QekaefBpKpuKUJIlKjRAKvKmB1mN4Z8nD1WsRm+DYxUdDYIF2E96tIdTId1rHutKxQdaexMAgWDDpYyFx2cOUn18B/IdGXH4ZYRfpvnUXBulfV2p+LYKNwzTjq5exxuGKcN64kaWdcSWepdTrY5CJ34NoKV/GAPM2RYOVYqVsZ4tLDhkn1sUA9FDBPk6D0DTo9w9TvyTRAIYHvhj2a3aAn8kJnjdoZbZBexfn1T3AY4/IsB0caVaKBxmmuR9hWLk/fWTbFmyZtQ1MS9kUzapXwJalSzqU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 15, 2024 at 03:21:34PM -0400, Peter Xu wrote: > [Based on mm-unstable, commit 31334cf98dbd, July 2nd] > > v3: > - Fix a build issue on i386 PAE config > - Moved one line from patch 8 to patch 3 > > v1: https://lore.kernel.org/r/20240621142504.1940209-1-peterx@redhat.com > v2: https://lore.kernel.org/r/20240703212918.2417843-1-peterx@redhat.com > > Dax supports pud pages for a while, but mprotect on puds was missing since > the start. This series tries to fix that by providing pud handling in > mprotect(). The goal is to add more types of pud mappings like hugetlb or > pfnmaps. This series paves way for it by fixing known pud entries. > > Considering nobody reported this until when I looked at those other types > of pud mappings, I am thinking maybe it doesn't need to be a fix for stable > and this may not need to be backported. I would guess whoever cares about > mprotect() won't care 1G dax puds yet, vice versa. I hope fixing that in > new kernels would be fine, but I'm open to suggestions. > > There're a few small things changed to teach mprotect work on PUDs. E.g. it > will need to start with dropping NUMA_HUGE_PTE_UPDATES which may stop > making sense when there can be more than one type of huge pte. OTOH, we'll > also need to push the mmu notifiers from pmd to pud layers, which might > need some attention but so far I think it's safe. For such details, please > refer to each patch's commit message. > > The mprotect() pud process should be straightforward, as I kept it as > simple as possible. There's no NUMA handled as dax simply doesn't support > that. There's also no userfault involvements as file memory (even if work > with userfault-wp async mode) will need to split a pud, so pud entry > doesn't need to yet know userfault's existance (but hugetlb entries will; > that's also for later). > > Tests > ===== > > What I did test: > > - cross-build tests that I normally cover [1] > > - smoke tested on x86_64 the simplest program [2] on dev_dax 1G PUD > mprotect() using QEMU's nvdimm emulations [3] and ndctl to create > namespaces with proper alignments, which used to throw "bad pud" but now > it'll run through all fine. I checked sigbus happens if with illegal > access on protected puds. > > - vmtests. > > What I didn't test: > > - fsdax: I wanted to also give it a shot, but only until then I noticed it > doesn't seem to be supported (according to dax_iomap_fault(), which will > always fallback on PUD_ORDER). I did remember it was supported before, I > could miss something important there.. please shoot if so. > > - userfault wp-async: I also wanted to test userfault-wp async be able to > split huge puds (here it's simply a clear_pud.. though), but it won't > work for devdax anyway due to not allowed to do smaller than 1G faults in > this case. So skip too. > > - Power, as no hardware on hand. Ping - any review comments or even tests would be greatly welcomed. I'm not sure whether this matters for anyone yet so far. I hope this still makes sense for DAX even if this is an extremely corner case... Just to mention the follow up users of this path: - huge pfnmap 1G may use this, when VM_PFNMAP can be mapped with 1G too, then we should hit similar "bad pud" here. - hugetlb rework will use this, when we want this path to process 1G hugetlb pages too. The 1st user is not a must in my initial plan, as VFIO + VM use case doesn't use mprotect(), so we can keep (1) broken together with DAX 1G here. But for the long term we should still fix this, IMHO. Thanks, -- Peter Xu