From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E849C3DA61 for ; Wed, 24 Jul 2024 14:41:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE22F6B0085; Wed, 24 Jul 2024 10:41:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6ACF6B0089; Wed, 24 Jul 2024 10:41:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE4F86B008A; Wed, 24 Jul 2024 10:41:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AE7EF6B0085 for ; Wed, 24 Jul 2024 10:41:44 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4B0921A09F8 for ; Wed, 24 Jul 2024 14:41:44 +0000 (UTC) X-FDA: 82374910128.28.9B88DEA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id 95124180010 for ; Wed, 24 Jul 2024 14:41:40 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sSBynAQ6; spf=none (imf16.hostedemail.com: domain of BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721832078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=crMY3yh38upJJIZqKdBkz6jKnqXn28NamV7YqV6NS/s=; b=aps+cG9aUGt9saD+CUJrfRTS8waSK3hmBDipZ2/hYWnp/NTvzjjZJptANkSbuKxGlxF2p0 /C2dWNwkCjEsE6C1i/Ua7213+3liJqXtFruwtaUlZMLVM5l0XWfBVE/wt/1+XrfzhC1f1c 2SFq8dT74Hb3ZvQHj2IYd3rj+UR6VHY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sSBynAQ6; spf=none (imf16.hostedemail.com: domain of BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721832078; a=rsa-sha256; cv=none; b=Bmlg1x/qCy5UW6ZdF5SCPlNhfsEvT491k+hjtJHJwE/X2ZWFIyqNEwLvS700SjCKOvM1O7 qh8Dbdsfrz9jZz9KZ0nLTVfGlzTvY+PO1/Ymc1bmAX19pdgIDOGx6OQhZGIXlG/WIFt8Kt Bvaa2Sx5R8asOWHf/GXwJLLeYV5oU/Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=crMY3yh38upJJIZqKdBkz6jKnqXn28NamV7YqV6NS/s=; b=sSBynAQ6F/fAVILYBCQxEtrV71 xyRh2ORRd1ET7ZmGKxrbXDit7f1kvTuE6C+cxh1/fQ+bofqsJhw+Lg5g1CrseBjYE2J3t44khsTA7 F5VuHRiK6juMHBXxEdoJy436ZR+VYpWfs50F1QouiyW5RnkJeDbsCl7svnuNpbQm2nPshc9+rpr3u kJBAp/1S/nweLxOkcONJER8/Vc+xnEka6UndCWBZU1X1/x6RK0nj9CMkIUklwg7yhkmUJXl0xDvQd j0gmgu/ZvGw+PDQMzDGv4zC/x+wB/dxTTFQngp9Jiqw+r+WyNVWAfX0omPL2xXvJbO0mw0+cCiPUW hvMgAujQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWdBP-0000000Fdci-3Hfd; Wed, 24 Jul 2024 14:41:35 +0000 Date: Wed, 24 Jul 2024 07:41:35 -0700 From: Christoph Hellwig To: Vlastimil Babka Cc: Christoph Hellwig , Michal Hocko , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, virtualization@lists.linux.dev, hailong.liu@oppo.com, torvalds@linux-foundation.org Subject: Re: [PATCH RFC 5/5] non-mm: discourage the usage of __GFP_NOFAIL and encourage GFP_NOFAIL Message-ID: References: <68ee812b-3b96-4c8b-9a54-70d4742488bb@suse.cz> <400b2f6f-f7f0-4888-99ee-7327faad7e5c@suse.cz> <5b9fa06a-bcef-447c-899b-fe3fb10315bf@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5b9fa06a-bcef-447c-899b-fe3fb10315bf@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 95124180010 X-Stat-Signature: y37qzcrsg7b7gabs6x43wo3brcay9h7f X-Rspam-User: X-HE-Tag: 1721832100-214480 X-HE-Meta: U2FsdGVkX1/GrhviiDw0lUL8jp/ZB7vi2hECtADgj0nyl+4RKx9ZgvAt35nQr1szuUuiKwaBLln9Uq2AJBAk931Rhfq64gnT7MYpjzToziOmmptS/pTJgGp+M8qtTh4LDQ2tx4HxIgpiZgqlj4RFRWB8vktudsyutUC6hiuQUCb2UtaE2ey7q0uy+57dGD5I8Sy90TU0vjLfSlcopFhd3ZN0MLgCkwUjw1sNXCnSSohvFAjvDCEYH52NkP4gRGBi2QHT7z8wkr17F1NMrgEUw5ap0C1Unruvuj21ZRIYM78bsiRiyEeCylMFKSzUK/zrdVetPU8BbCPFZr7k9luqLd3QySAMOHHG4OrfsSYx0swIFPwqLSJRCV6NQhBimwO89KXnV2qKMJ/q80pKubCuGxgE0phiA9pB2XuEKXdgq6Bs2cwGTKTvucVbeV4ZIflJxbG9ANEpVbd9gRX3fQo4R9AS6QGlGNGNeEi5dkbsQfosDh0YH9xLFp+DLzFKbLSZUpegWU0Pr3vQrBAFxlntCDtOZ+yAHLppNnLl1iXrgyx5sJKhBSrTfeQy+USHKZPm5jVuT5MDT0gA4/PJcWPYBmqwsjhKwR6z1IVoH/gUimAKOGag4v/97DDzwYpWVBHVr+PL9f1cPKv6MN8mdvIEdTMLWUvSLULl3+s5pBdvrHovxoBA45Y90RckNG5sPoKtWM3avh16dwTM6ekCStwdPdbq6LrKJxiyepnUPg05zlwiZIV97sjY9a0CgukaaCkndSqjR8EWMscTZ3tfofocyySX8qORWvKETHxZieRNr3qD/GIQOn+0Guh+3UipsSqV54x6NtcmOtxlSZxGionKNn9r8N867KeV9BusnsTXGr2A33JezTAL/SSvndvh3rJv3ZuSsfTtaae1avX/7TB2986tcUuywjQNKWGnZdn31MYjdbA4uxcpunI/v9X6WuDNgznALu9sYsoShs67rIZ lE1T2xES v4pQVh4jysRL0rZTLfShO0Q7y86kihd0ZL1gR/QB4tKXJlkuDVkC/BMbodpd6SRea4pkCgIT/woDmMj+Ai6haj77rEufb8pbf4/enyXvF0H6KMXXyGFEGi/t8xPE7to94CU5PkPJeU9xgLoGyGpRwrsP+hbsHGMHtHs3Og2WpVui8xF42gt/zO2RuC4hmvSGpCvWNLYmXC8WTfzQ7m5qTS5h+JFqKMkkhMCsneWgFtx90s+lH6NZwvrW5ocLJMeOTOhZsFu/9W3BuDs43n/lvs/R1FtAS5Rf3DWizm6vxi9ftMP5z0TNRaY9ZknUpW1nyzI+3D9+918m62Fqw5bg1rHGsgjR27CoSxDI+9iUtFf9xvGdipUatwwNgC136BOJo6Uk9d9d8aJnRHVoA3Aar6e2nzjg9HZRoEXtw739Xg6Dw465RhKIpik4jKqzbqwdYae6tIz7EntYglrOOTez6mLuzfljfWpY09QNsw8kEiDmUYeft8OZlUtt65VVLq+iz+PsskJyxMCyd7wrR2pl4FI2ChYuvcYiOG/JrKlU6DLQ31P7zym04KsU0mfk3zj6yRYPFnPJQKcLGZgpDwT7N0wxJ0SM2BOgCVANi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 24, 2024 at 04:39:11PM +0200, Vlastimil Babka wrote: > On 7/24/24 3:55 PM, Christoph Hellwig wrote: > > On Wed, Jul 24, 2024 at 03:47:46PM +0200, Michal Hocko wrote: > >> OK, now it makes more sense ;) I have absolutely no objections to > >> prefering scoped NO{FS,IO} interfaces of course. And that would indeed > >> eliminate a need for defining GFP_NO{FS,IO}_NOFAIL alternatives. > > > > Yes. My proposal would be: > > > > GFP_NOFAIL without any modifiers it the only valid nofail API. > > Where GFP_NOFAIL is GFP_KERNEL | __GFP_NOFAIL (and not the more limited one > as defined in patch 4/5). Yes. > > File systems / drivers can combine іt with the scoped nofs/noio if > > needed. > > Sounds good, how quickly we can convert existing __GFP_NOFAIL users remains > to be seen... I took a quick look at the file system ones and they look pretty easy. I think it would be good to a quick scriped run for everything that does GFP_KERNEL | __GFP_NOFAIL right now, and then spend a little time on the rest.