From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554ADC3DA63 for ; Wed, 24 Jul 2024 13:38:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC05C6B0082; Wed, 24 Jul 2024 09:38:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D71516B0085; Wed, 24 Jul 2024 09:38:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5F726B008A; Wed, 24 Jul 2024 09:38:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A69636B0082 for ; Wed, 24 Jul 2024 09:38:47 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 439BD4092E for ; Wed, 24 Jul 2024 13:38:47 +0000 (UTC) X-FDA: 82374751494.12.20AA235 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 399961C0017 for ; Wed, 24 Jul 2024 13:38:44 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="EN/3Ds8z"; spf=none (imf20.hostedemail.com: domain of BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721828301; a=rsa-sha256; cv=none; b=wylbLXcpYufXoZ9bSIEu2CfgJsPnLF121ENC2y1YYI4fjtaFONmmzcsJk+sEOmGSVJQrKl DjD/a3EVzxXR/Ahrj8UtAX4YFgyxbEInAl1wKs4FL1SEJPY/S6ybp7yu5qCwLo1jIDlv6j y0A84w20h0JQevjvZW3+25evLMdM8Ag= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="EN/3Ds8z"; spf=none (imf20.hostedemail.com: domain of BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721828301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b/KEzmx1aMMGRJQpHAjdbVT5z73BzbBw+LIwhc43mRI=; b=HXBNkueUYSkRCNfgSpNXz9bzg9pc1ENwWJOaO3ofl5RVIGENKk+lJjLkV02wxSAWZ9u+2P YDwWlVA95oVTeVMHdAL8QunI9fK6iVDe2bsw87P330TT3UzTZrwB1mSNDA7GyvLS1pmLCR 7yyE8bydeKkZ0bixEQm9zjaKQ6ktRsw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b/KEzmx1aMMGRJQpHAjdbVT5z73BzbBw+LIwhc43mRI=; b=EN/3Ds8zwhG6he2rQH2e04Bkq+ iUsMRkJH6sJWwWivU8LahkjYMU2RLUSIK5dSQJ1101Gcm4Cx9YuG6WTC/hgMg/0h1ydvh1DFB8FVq Ra5gjh9mhRQkTHVUNfZe6s/a2ggnwGB5LjNE48sXGyB8dODsMy5Y2JuPhays+uhf/nWuLJQf9n2Hw pAvCj+5xp9PqBBGGIIX+0joALiSxukDavmiHMCx83N3TIcjTXdjqveaJAd5RN9TYpMMpCvrOzZaD8 QTUWA3xWkfqjbVuq7/MdQkv2M5jUCt0PgtshZA1Mx4pq7kGb/al8Xv7Z1+P4V68IwtE21qNfm7xtO kuuIHyOA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWcCX-0000000FTDi-29nF; Wed, 24 Jul 2024 13:38:41 +0000 Date: Wed, 24 Jul 2024 06:38:41 -0700 From: Christoph Hellwig To: Vlastimil Babka Cc: Michal Hocko , Christoph Hellwig , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, virtualization@lists.linux.dev, hailong.liu@oppo.com, torvalds@linux-foundation.org Subject: Re: [PATCH RFC 5/5] non-mm: discourage the usage of __GFP_NOFAIL and encourage GFP_NOFAIL Message-ID: References: <20240724085544.299090-1-21cnbao@gmail.com> <20240724085544.299090-6-21cnbao@gmail.com> <68ee812b-3b96-4c8b-9a54-70d4742488bb@suse.cz> <400b2f6f-f7f0-4888-99ee-7327faad7e5c@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <400b2f6f-f7f0-4888-99ee-7327faad7e5c@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 9fsuq5xbox5iqxrpy4j51cb6iyamgbtt X-Rspamd-Queue-Id: 399961C0017 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721828324-370867 X-HE-Meta: U2FsdGVkX1+nQVypgLOO56rR9fbY0OCSQY5XgkpPG9PQB9+a0m2xDBe5XhX9TFTvYhPXlgSKxNCfU6bT1BinM6UoKFlhqiUn3MR1CyYtQoDLMUikqdyyFpqWZHilvZ7oDhLoApHd0+4dxhl+8cAqhOz+4UAABDV9JqEWopKnim6M8nBdmwZF5cH7+L3m9lKWanzi4K3NtA7C1arqQQrHub2JQxKMsNnWpnKLfnsEONSLrqdCcSPny7C8YKYewQEHIfTGHsKZvCqMb2UYO+th3Zhgva2/7GZ/tor0fnhmvQOmnSkLNs6VMbEVylAGGueFWqj+hcywsIS6cLCgas1xmefSeqIc6cTGpYxvpbjbx6udvNDM/HwYkwx9dE1ODNwNBs0UYpVVKgcTNg8ANv8DM/wWsZugXUgf7TWPGcvFr6KsRhLENLyS+UerSKIFuy2rCULuH/FX8/AawrQ1ileUdws4ZjESjSDX9bH8IixUluKrE5j/H7QHxqTGT7dcWfY3zCW1lJr0HWjJ4DqZjPvGr7i+uqiNpWq8p3BYnDVVWnJdEZA/6ob0qzQDhYEe21YKv/fXUD8RTMpYz5GkhUPcQIF1nEtDPvkygGEziBvwB+c3qSmgwzydfx3vyirn40w2V77UAOdTSusaKiuodaElfTOSFtxTXeKueEOIUAqRac8TZo7wIH4pFM1MAVlki0bpoec5YfVcW95Q51QJpM20vHTMMtKyZN9dmutIRTGfhPhokeafm8kN12mfNQEodx4mCEOheekVRb1NX+awHf4jr9PWe789mztPey6trUJr73QvrGigGJmq+oJLxGK/bE4GQGpI/enDnL0dyKaJIMhShLOorlxDxggOdhWuMBqZR5eBvCQALjlCTqMb/6AECCiZ2BLh5vL4qKxSdCu6NkuQzItgxymlCKeIg6yQNRQ3gt4szvJN5RFZt3cQOrJyEOU6sQMWAmdZ5wrzMoz5JHe dX5sBFtp 0Aonn/rTTBUZi+yZUnvFhJYWC7EEq1M+OIn8DLYgpD3U9UuaTartB170xD/k9lZrNxBUWMQXSp681DmmL9kdXgV0ZUXuDMIQb2vhnGjjj+W47MgtgqzsgXLdKPaveWON2Gn+5kEIMhov9aqCvUFNobkCg7K2YdyXr/gWQ4B9T2MYTl3UeKfWEE94hXTqCmCz2lTfiBggkiv7daDDLKwACKLh0an0sDeeQQshaGVsU54p8jDWGhlZ1EXmljlUc/ccxHJntsX7j3zshpei5mPZKqFC6hKi5TvstPetp5mWwc3SyLjtWTOKE4M22UH8Ri2YFrGBI1ccGwSkNRZJb2Auks0xwhWFDS0AF6fSqinr1M4dxrugb0ddGL7PhFlsoZWcAW0oDyWuniJHKIIbHE2xZ4xa+d78oCNOfI8L5VuoeQ9JKfNQFUjjiysYso5hGQ8UntAT/eap4QrUbrufWCpvXtiRFcPJY/RQushM14NTJ78UkK63Rk9DNHoBLFNCg2YbP46WHqvnQC2ZL2THIEYoBHAuKYz83PhWL1+1ez7fiTsZBeR2Q7ouHNX02LqdRtREvqp3Av/owpVA75GM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 24, 2024 at 03:33:19PM +0200, Vlastimil Babka wrote: > > I do not see this a problem. There is no real reason to have a NOWAIT > > allocation down the stack that has a different fallback strategy. > > I am not saying that this is the current practice because I do not know > > that but I am saying that this is not impossible to imagine and it makes > > scoped NOFAIL context subtle and error prone. > > I don't think Christoph proposed scoped NOFAIL, just use scoped NOFS/NOIO > together with GFP_KERNEL_NOFAIL intead of introducing GFP_NOFS_NOFAIL. Yes, exactly. And I didn't think Michal thought I meant something different, maybe that's why it felt really confusing.