From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC0FC3DA61 for ; Wed, 24 Jul 2024 13:23:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 700D86B0088; Wed, 24 Jul 2024 09:23:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A3C6B0089; Wed, 24 Jul 2024 09:23:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 552176B008A; Wed, 24 Jul 2024 09:23:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 36BBB6B0088 for ; Wed, 24 Jul 2024 09:23:35 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A2CC21A094C for ; Wed, 24 Jul 2024 13:23:34 +0000 (UTC) X-FDA: 82374713148.07.B5A86C5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 69B3940003 for ; Wed, 24 Jul 2024 13:23:32 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=T6EKofbh; spf=none (imf27.hostedemail.com: domain of BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721827364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aGDmrf70xonv6Qm91bhRo10OdhYvaEykAIZYXVPLJ8w=; b=ujZDw6jaB0q7WmE80pANHxHi2dqKl7QLdkkv9MHDoNR9eHflmMDsDjFY0Ad6KhtXJE1w/m g5rUjPQaFK2EF1rjlvL99mdUAPkh6dZfl7BJhwVTEiKDFrcgZCQlaC/xVRGHBAB5npVYqy 2bAKd4yR6V4Dcu6K134/v/HBKr4sdI0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721827364; a=rsa-sha256; cv=none; b=DLaCFm0VOwg38h/p0xD2BjAp3Pwu5WPCAvXonNU5vS15LWRsyPFCTcZ15+9ZApUqE2MDdO cd1dI3YzuMy5ZCr1ERUkwDUGs/+O3q9p26FFOsNQokiN75/I7NwaJnvWpeq4cmQg7EA3Hb rgn+WSqJwAwe7itZI7ODP7le18oO5us= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=T6EKofbh; spf=none (imf27.hostedemail.com: domain of BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aGDmrf70xonv6Qm91bhRo10OdhYvaEykAIZYXVPLJ8w=; b=T6EKofbhHAV0bXikVRXIvzascT JLhhFq6JmRbVL4FEZWPnF3KmN9egpn/MLIznUPvYW0FPL45+dnJ7bP65/vjNKq8bKvoiQShdEklKO 4o9F37RzB9UXMEBMJpRgEoXBDgOL7aFOhY6XITr6GOZmQ/r55u15i6Y07FAbJ3b6P+ng6ev99fSTm IsojksZSOczxUCn5ZCVkPSYIUuujhd2VTfXCE6ns7od/dNBgCECWR1OdXp8zhkTZCv0Ymo+kyZcyN NYCuBVGzywsHFEIFOjOXpy26okIsTUJr6a1gT8nSiJUEBC4mSUtgQStNoLff3LWu35p4xMmt6dxTT sApTpSbQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWbxp-0000000FQlv-0NY5; Wed, 24 Jul 2024 13:23:29 +0000 Date: Wed, 24 Jul 2024 06:23:29 -0700 From: Christoph Hellwig To: Michal Hocko Cc: Christoph Hellwig , Vlastimil Babka , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, virtualization@lists.linux.dev, hailong.liu@oppo.com, torvalds@linux-foundation.org Subject: Re: [PATCH RFC 5/5] non-mm: discourage the usage of __GFP_NOFAIL and encourage GFP_NOFAIL Message-ID: References: <20240724085544.299090-1-21cnbao@gmail.com> <20240724085544.299090-6-21cnbao@gmail.com> <68ee812b-3b96-4c8b-9a54-70d4742488bb@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: zjjpmppehjbxi3xyfyurco3yspbpmxso X-Rspamd-Queue-Id: 69B3940003 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721827412-605923 X-HE-Meta: U2FsdGVkX18iPTRCGnMmx7bthdr4j7/t2v9Gycev6ErX4jVdOm2+vzqBd/yED8h4O7y+t0qle511dqnQ8O4tzgLoGA+SC1FC9BjqM6kR0zlR58kCQMR5iH+o/9+zKnPudmNdDvXHx+y8aV3WmEvtffzOQxS1KPO5UGnp0+ZUO1P0/vMCmUjjvuPizWPXdjmMDMdTu/Dyaj+Tsvo79U1KyD1QC2eVofA0FHbuhGrmMsnXt8Tl61V9amr5svzDGvL18RvduoF+qhjGN6IzL+GBewh8TuOf6lcqm//MqSoND+GzVPsg8iop27cvqPQLDGsggqOnlbxI4Xvjru36N4Eca4KxlXJv/JoFa7qb3OBhJor9SGy9mxh8MGmRtjcBP6FcgdNelnrOk/BhtkFZVu/lztm9mmF9nT4RLIPiAXAeXUCdvlXafJdPOy+fjeeI32K3yy9wCdMtAdvmhwOiDQbdH731TaGXZVKFLcEDIZ3EA+X1HMTiotV41yKjEUiC0LP794nhl7I3PbaeUJ7QIlbJbiDl9EXGHPszXMhcwLMjrIynK1Suz7kCjABmwi9tMLDcW1h+BM3SA1NbuEVwSNLoSGHxgrl0byBYJuIzChiSkooCir4H4MMQZ2lPDiSuZbr6+AMs5EMUYKR+IBPtdaR8iG240EjtcUYNijJsac30hBrBR7zf4y2gtuIB+3bVrhOJ2lCWysrTCd4kExK1oCSqzArIkuSiC0aL0/m7CWjnL1IoiXXr/jjRbYwHrYXxC8D58BFts7dpBs27RD6dYulkGdnixNw9yERXK3pPCg++kwr0n8ocqBtv9XDoqvNeQQi/WhaH4cnRkQeWm3y7m8IGVsPss+JfX1mo8hVkGE3dWWJJhAYOQ0WOQEWHPoxBjtfMjUpMo/FtiKlqnn8UrT/9gqJUuen3kLAmY2yd5zTwAj3LufWia1wpgVibVGs6BwWlw8XbjBIjvsLgQFRDZ5c dV8WScTX 290exio4oM+zPatCTjPKRT3981z9Ys65BXiHcY6TAqzUAbwNvjC+a9oqfW6tBDMmB4cVTN69m4x9fPEOK1WSd8XXQVppzL3kgH9FMFwDzl9bbyoTuHePjayZbp5ZVyD1bnYza8ILKap5Wh/Le7GXn1zL21YqJi/Ej727+yELLdzzl3v8CJHnODq3ePZRvbaowRGho812/ObmzfsSGMJqxzzdRzcWV3vT6OyZfl/A27wJEqnj6p6YsF+CyXrIm+ihobA0aCjMEfUTTfGBCDTOrqQX05uBYKQHsNniqr3Kr3djkYoJauyGoPMCHxE6fRf6boTKGF3DuthcJd3TeFTRo11B8D037C6ZRplK4rDkJc0bf8GaUvjufbmDk5XvXSCw8jkhRmbjxXmkC1z/sRjNrHWGOFK+Cb7ID+X8Ocr2fs3OyDz/E/F8AYBIb0FKqiLG2UuzbQo19RoZfV2CmrrxXoAut8h0uB3/pTPvluq6DRYWg5K20hkkVjR9PjH0GXqDLog91cXTPNGNXFfqypU8k3tjk5bQsI+Ta8cwKdjIUtF4mP+hDF2KZVZ5aK4bBBgfze9RF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 24, 2024 at 03:21:13PM +0200, Michal Hocko wrote: > Scope API is tricky here. Exactly because the scope itself could have > opportunistic GFP_NOWAIT allocations. Really, where? That just sounds f**cked up as callers using any kind of nofail API can be broken by a caller higher in the stack. And that's totally independ of adding a NOFS/NOIO helper, so it'll need to be fixed. Adding more NOFS/NOIO wrappers while we're trying to kill the flag just is not helpful going forward.