From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F36FC3DA63 for ; Wed, 24 Jul 2024 12:27:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 108DE6B008A; Wed, 24 Jul 2024 08:27:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B8536B008C; Wed, 24 Jul 2024 08:27:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC2096B0093; Wed, 24 Jul 2024 08:27:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C87A86B008A for ; Wed, 24 Jul 2024 08:27:04 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4F0881608F7 for ; Wed, 24 Jul 2024 12:27:04 +0000 (UTC) X-FDA: 82374570768.05.C80B054 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf03.hostedemail.com (Postfix) with ESMTP id 5B3CC2000A for ; Wed, 24 Jul 2024 12:27:01 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=cttnMgDk; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721823974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YnOWQnJCnDZ9R7kbtMaSLi40u0ypeXbpg9JSRISHqBU=; b=Gzpw6yH5oagF7PSC9jrq0cu/X7hv6LbTy6G87vQwtz/NcuffizRPYmEql62VFiQhUDMFX5 SbHasPkaUj/JG5SFoWm1RSNNLyUo3w+Dbz/XZK772OTQywjobmr68HELyQo/XytNO+SuQb WhNdYcOlLbO7xJAzPHOmvfa7/Jdrb00= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721823974; a=rsa-sha256; cv=none; b=EielVfjtB3Dz6M2oSjd/nK4bTu1q0Hq/JZIMHErMsWAui9HcBAu95ktfFqR3CyQjp1igiR +yud0++rEDF2ntDhnNLN365bv7gqF3zNMTN7M7v2N3KBXj2fxqPgItKRLFEtM6Nl9C1dmH zCMOJ5yl7a62b1VFHubycYoQuv9eYYs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=cttnMgDk; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5a20de39cfbso6356178a12.1 for ; Wed, 24 Jul 2024 05:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721824020; x=1722428820; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=YnOWQnJCnDZ9R7kbtMaSLi40u0ypeXbpg9JSRISHqBU=; b=cttnMgDkC2OQ1HP03cK8Oz+qJrcg/iUYlbNVoXWLfJY3RrhEMMPd3G5sLw+AZvxutz YdkqoGI3/Z3nRwzu2fuG/fpEbEE9z36gLaUGu85ZNiEoSDq4edy8MYB6a53FHvEcA6YI BDUm7ENI2NLOwIFq2oeyk+OGfF6WWzaMy9G0VhYYi/D6EyhPTKfzX3lOoXpWqUA176X7 jaBEHH19rsAnC8sUEFJ/gQrp8PoQRMzbnQGbePfHdkVn68sh++iD1FtrtsPaVd5AZTcF Wx+MsekKmtKLt7auyRWC1r6Js4PpwOd0jF7mmh+A1izCVXp1c5yeIgjrxFvC0euA4jmD gmsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721824020; x=1722428820; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YnOWQnJCnDZ9R7kbtMaSLi40u0ypeXbpg9JSRISHqBU=; b=PyVtcsIbZ00aNV56I+Ml7T6c6uTlOae9ogLEDAh0bqU3B7i0sxTAnBDFh0/4q3O7oS O7qBdp4recjbegI6TktuG0WhgJtV5ZMmClSArE4r92/SGZLUtxFebWjcDkFNyM6x21X2 rqQ5ePOEO+Ag59eiTXmhSF0zAW4HjdWiafHJy3VL+/r8uOaPFuXiWqA4Hg97TEJHechV lq63/CYU3l/6dpeSogqbgSvI2Rp4QcFygVRIKcVmoIeXHUhqujZ6n2JM4fzHOAK2/RI1 RC2C8uVkAULRRlPaFIZTtH1zax9YRJGFkAiFtUNXlJs8o2Ysp49y4ovs8PmgppuWv8pC 5thQ== X-Forwarded-Encrypted: i=1; AJvYcCV8Y1odTAvqYrUVewJr0W07H1x/gqHLkOPu1DBDF5Tx9SkeXqbIyDGY1zXtVXDau9nJEHxlGxkkaBzrFX7OwpUyuig= X-Gm-Message-State: AOJu0YyAR8SIMvcsUNSoC5b+s7v8oZfOQWNn97LumMDs/BQbc+NDWWPq 3VL1TvyGCAOoX255rw9lU1UdyLxFXvHN7FScihtM1Z5/GWm/hs7llrpk/UEl1fw= X-Google-Smtp-Source: AGHT+IErzvWGrjhK+SdJWKIvPxdK2ns3jSTNcJAH7iuZnmq1XwyAmLDTO3x1ofIFEWqqgXTjATC41g== X-Received: by 2002:a05:6402:3482:b0:5a1:faf:e5ac with SMTP id 4fb4d7f45d1cf-5a3f089da81mr10768384a12.26.1721824019749; Wed, 24 Jul 2024 05:26:59 -0700 (PDT) Received: from localhost (109-81-94-157.rct.o2.cz. [109.81.94.157]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5a30c3f0673sm8803391a12.61.2024.07.24.05.26.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 05:26:59 -0700 (PDT) Date: Wed, 24 Jul 2024 14:26:58 +0200 From: Michal Hocko To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, hch@infradead.org, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev, hailong.liu@oppo.com, torvalds@linux-foundation.org, "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Maxime Coquelin Subject: Re: [PATCH RFC 1/5] vpda: try to fix the potential crash due to misusing __GFP_NOFAIL Message-ID: References: <20240724085544.299090-1-21cnbao@gmail.com> <20240724085544.299090-2-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240724085544.299090-2-21cnbao@gmail.com> X-Rspamd-Queue-Id: 5B3CC2000A X-Stat-Signature: c58iprtmku5ifagxwmfp84qb39u3r81c X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721824021-531584 X-HE-Meta: U2FsdGVkX19a920QAHUrRRcWoi+XWSQIv8Lb5WOyQS3/3qz56gBsysUG4CTkjJepsTWCmJhNC+reA50fTErkFBFB3GgDqh5fcWDZZ9Y+HyOys3O7uMdkccYo2LkQom/TDbdfk/foV92onDJQzwZC0vbW0abdJAufqLQYinKwQgiGmmbyVZPLQSg1i1Eq1/6HvsxFpkzDtkpgKkQYnFAccE3/lZjGAklhG+SFsqUKAz/HNwrtnM/GuvOvl6Rlb/6G1P7DqxlR6D8DOqzzEmxPNRxgbfRqFr/Ug/CFVtdNZE7mt6ayWqY2boDF6/T+HfedRvtq+Ca76vHqa0zvQxq1deYPdvbBu52sryj7RaBiG22hxaugfz1i96kAnMD8NPBg5SFpdbE53EPTk9mi9v8CLwR6qYpku0CakEqRrjtazjqEhedLcxUC8siV4+Vgg3S8KGVDKKXPWp8nBsngVc4vH+Zt68GDOgucj3SPBXaNz0cBBcLh79WFITa4tPcCaMG9OE/vslJ9DZwfkpxUR/umEcCzROp9L/NKEudWu/TzXk2GiuTIKRjd2xVgRBKbl7vjWxfY0xyPEYieIkqpuqxHcvbm/w73IpTsq8yLUneyCv2WWmVUDF1eIc5uNTfW9JpHcQA6zOm6Zob+UMZDA+1euj/jaRMla1WSuLS5Fk7nbMIYYKm7gclCoZSimBhvXm5jicFXnIrhnn5m5lheAiJ+RRJHxQMMN9p0elbbnn4IFfZ9htaoIMUJfSQNM6iGAduxkH/S5ciSvbEwWuMbRX36cIUPyyLKqOCHKc0m+/4uTbb+M+dwIDT7MB6Op0Xx++qFocQGx6qT7sf0uxjZVmn8VMU/3/lr1sDg1PW+aJDfQu9+5dSZBegJIp1Rnf8tQJnUofrPXv4FiJvB8yj3sa3uDVSyrazFAkpB2FxRjjBibBraHawljR5ELx6evxl4/IZ63MVBKvyDfAOJgeNeXcJ IpSQysQ4 oQ5uGTJch4pGvNmkU4uU14wXQzFPsST4Mw/+T6lgq/E9YwZTjfdCKgEiPP/qXYZNjoZLBO33UuuBxPAsICCUG7Aamgdtdo+c2AUeYaDAuhpuIYSyUJnha2XA68vUV4Uq3ilWNZRnHotBG9BBjJaN7BsZD8lkG2AjOzkSPp4H/lHsuLYPI7d2alEU5yl7qWbN57Ei6PoBNfoPZILnFjCFWCtRKcT6T3iQp3aLaJr2rkaX+AGCq8IQni+5ndgV/LsvcBHCRe4tSRG9jHcgejeWP57AVrur1edPN7wVNwlj7m+3ptnlvs276pAIX4uwhx1wG9mo/+L1V8c6rG94k0xMZXOWg598fOZrePVYHRFvVQu39hqVQMyC1/0Xjtm5hTa4wWuh5rj/GaNxEzq81fV65ga+y7AMgKoiyPAA+kJJWuxjLtMOiDWmqqNf//Ah0VHtvK/SRn3orwOu+p3adXe/kjOTC/wp1q5Eb7usYc4I7YgNK/2l01c/ec5FHEiRUH5nIoCIWCoQJdQeaiP67lYhJ06caTF64Gi4O8sIyFa4w9a1YuJQNkAv/cZh8CA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 24-07-24 20:55:40, Barry Song wrote: > From: Barry Song > > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > __GFP_NOFAIL without direct reclamation may just result in a busy > loop within non-sleepable contexts. > > static inline struct page * > __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > struct alloc_context *ac) > { > ... > /* > * Make sure that __GFP_NOFAIL request doesn't leak out and make sure > * we always retry > */ > if (gfp_mask & __GFP_NOFAIL) { > /* > * All existing users of the __GFP_NOFAIL are blockable, so warn > * of any new users that actually require GFP_NOWAIT > */ > if (WARN_ON_ONCE_GFP(!can_direct_reclaim, gfp_mask)) > goto fail; > ... > } > ... > fail: > warn_alloc(gfp_mask, ac->nodemask, > "page allocation failure: order:%u", order); > got_pg: > return page; > } > > Let's move the memory allocation out of the atomic context and use > the normal sleepable context to get pages. > > [RFC]: This has only been compile-tested; I'd prefer if the VDPA maintainers > handles it. > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Xuan Zhuo > Cc: "Eugenio Pérez" > Cc: Maxime Coquelin > Signed-off-by: Barry Song > --- > drivers/vdpa/vdpa_user/iova_domain.c | 24 ++++++++++++++++++++---- > 1 file changed, 20 insertions(+), 4 deletions(-) > > diff --git a/drivers/vdpa/vdpa_user/iova_domain.c b/drivers/vdpa/vdpa_user/iova_domain.c > index 791d38d6284c..eff700e5f7a2 100644 > --- a/drivers/vdpa/vdpa_user/iova_domain.c > +++ b/drivers/vdpa/vdpa_user/iova_domain.c > @@ -287,28 +287,44 @@ void vduse_domain_remove_user_bounce_pages(struct vduse_iova_domain *domain) > { > struct vduse_bounce_map *map; > unsigned long i, count; > + struct page **pages = NULL; > > write_lock(&domain->bounce_lock); > if (!domain->user_bounce_pages) > goto out; > - > count = domain->bounce_size >> PAGE_SHIFT; > + write_unlock(&domain->bounce_lock); > + > + pages = kmalloc_array(count, sizeof(*pages), GFP_KERNEL | __GFP_NOFAIL); > + for (i = 0; i < count; i++) > + pages[i] = alloc_page(GFP_KERNEL | __GFP_NOFAIL); AFAICS vduse_domain_release calls this function with spin_lock(&domain->iotlb_lock) so dropping &domain->bounce_lock is not sufficient. -- Michal Hocko SUSE Labs