From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 043A4C3DA63 for ; Wed, 24 Jul 2024 12:17:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 767506B0089; Wed, 24 Jul 2024 08:17:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F0FF6B008A; Wed, 24 Jul 2024 08:17:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5915F6B008C; Wed, 24 Jul 2024 08:17:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C8466B0089 for ; Wed, 24 Jul 2024 08:17:56 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B6249A05D5 for ; Wed, 24 Jul 2024 12:17:55 +0000 (UTC) X-FDA: 82374547710.20.03DB74D Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf29.hostedemail.com (Postfix) with ESMTP id A8C21120007 for ; Wed, 24 Jul 2024 12:17:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=eUFoFTsa; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721823427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AH6/60ilSqogotIa0Yn+76PK3sWEb69NY//2ZTuyhAE=; b=kK7tmkxSdaKyFlgjLkqfJPbXxIYgpaUs9sOTwliXWjZBNM1Vo3+OPsbmeB3uIbUC9zvFgV MZzw5+REGXlBb7RlTq+0PAmjvsJW0V+nAmeIO1wL1RIu4YUwbtbOpwFi2MB2fM5Ri4DPrE m+S7b3EZ/px4ZsNmA7SLmxxow08kEs0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721823427; a=rsa-sha256; cv=none; b=1TXk89hMUBpzDKa4lKZcoxuPhBhNgqqIPCdx7Me41giXeq9giEW7j9HR+HL96U2KJtozTt ifOh0XWHrxawbbUEsVMtbzgAhMJ4rGMujFhhDwAtz7GM/L9rCuUW6oqBMjuC35n2GS4tSy qiWfmPx9o/iHHYMd/N+TVSd9TpzD1OE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=eUFoFTsa; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a7a9e25008aso210465466b.0 for ; Wed, 24 Jul 2024 05:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721823472; x=1722428272; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AH6/60ilSqogotIa0Yn+76PK3sWEb69NY//2ZTuyhAE=; b=eUFoFTsaPHXnlhPu011w3JP9Rde8k1o8Ssp1GB2OGxBPnEnEUQBpa06V1H6TYlso+5 orZIAvKpzsmGNGzsTiwPcaTGJrdYtj1REfROEq1Adn2McozxGekVM99aiIcdma9d+Jzd mGRgDOG+RpWRLDaE0jHyfD/F9mk3IYfyeDxQhnnzKUZ1y8OQwjWyPiLdaY8wX15Du4B9 ikHTn+TtVV2xeH5GtG7ztodPPBwxufnZ2QKlivq1jSlSS+nplGmocB2dwOuRM+nT2Top zxeAANbaRiQMvSkuruL4rUmq4ZQe4yM7F5L+JyXzutEQyhet+5Oa1CzK+XOBP1qvVDRN NCrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721823472; x=1722428272; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AH6/60ilSqogotIa0Yn+76PK3sWEb69NY//2ZTuyhAE=; b=jWQqPWTLqWHEhQrnT6SCN0JHCWE0IhySXcqhF4nHkO2wn6P3kxDfsVMhY3fPyJJ7AB 7GqYAOYd/zRj/LwKXnoRFuegFf+1a8Xvqq05uwkkpyWaR1pbM+zoyMgR+7Llwrg0yDFi hE1rqLsEC7Ikdq8JGKWdde3w6dy135mC8InwCzT0t04/p26M+Hl5d30ksyRD4IZc/Auf y8Ce3o89C2/hiA1wP9497h38TS7g7EeWogfVmvwUB8P/apBZiR4U/rvwMEtcUvoZ4A+D LWtjcR2bTgg0q6XJOR11XitsE8wii+plkNRednVN0XwBRkC39bVLHLhWK19vkeOpHQkh S1AQ== X-Forwarded-Encrypted: i=1; AJvYcCVLt33fVHBe4aQiKkX8fH66IhgNIRUbvi2b62MY5M9F0qH4vct+eGiNc13YjSr6TrJeYMNoNnYsoANVQw5oEN6Pbrs= X-Gm-Message-State: AOJu0Yxkzg+GUTmz6VS1yUcyp9IM0kIwi2da+VtsDfiCRLPXc+pKIEWm hAjg2VOaR9VjEFkxAp2Z3GATkz9CRy+L4V+fhwzRdQMVnBD78250AY+ERRHaEFM= X-Google-Smtp-Source: AGHT+IHfYQ0bvxc2iNBQgy+rvJ4GtEtz1AIw7oKDKgMgcbTYPs7bQokdfT3snYcXpjGEyw6Qamqg0g== X-Received: by 2002:a17:907:6d06:b0:a7a:9144:e254 with SMTP id a640c23a62f3a-a7ab0d081c8mr141848366b.10.1721823472048; Wed, 24 Jul 2024 05:17:52 -0700 (PDT) Received: from localhost (109-81-94-157.rct.o2.cz. [109.81.94.157]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a3c786162sm647262166b.18.2024.07.24.05.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 05:17:51 -0700 (PDT) Date: Wed, 24 Jul 2024 14:17:50 +0200 From: Michal Hocko To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, hch@infradead.org, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev, hailong.liu@oppo.com, torvalds@linux-foundation.org Subject: Re: [PATCH RFC 5/5] non-mm: discourage the usage of __GFP_NOFAIL and encourage GFP_NOFAIL Message-ID: References: <20240724085544.299090-1-21cnbao@gmail.com> <20240724085544.299090-6-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240724085544.299090-6-21cnbao@gmail.com> X-Rspamd-Queue-Id: A8C21120007 X-Stat-Signature: xekmqkeeuqt6hjraypow5pjtpyskkfrq X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721823473-138218 X-HE-Meta: U2FsdGVkX1/KT5xfdI6osbiNv9xTJAm3FSC/cIKuda2lo8RbrOGQ8ZTfKU7knKMc8pB+qs3OdzMenGGOqlmu5qvB0dxQ7H0ZF1mV+iLWXGaRt33rve0D7yQdzITlPuU4995NBVER5V7J7dPc/cOZy/IUg8QJQFh6gizmxmhY3NjKh10r7BWj9ppMVgNtndeRY7iD/N42K1fXAO3eO6PbUdujke6omdW7+RMwFaO7zDPMIZvkRRepa/wTiPMOHO/2RrHsWV2kJz9xZRZz+whbxTmzc78MbWs19SyUe0H2DYfzlUpnWLTvztal0Nu5KEw18IM2zwxRH+l5/hf9iB4Qm5wj861h71k6Iqy9uLkCkbCct+eA4It9JFjSV8EBkZ4Sv5hBTfy0CmwarPiyn8iEo+oUZ45NiHluIsXtv2UxHV+Tsvtfx34dZnjCTJemX9bb5droBUTTI1VW0wAKqZmgLTnFKqiALEgNq4v22qKXaWx8h5agRwuIMHGDjJ1+CvZO74bYGos5wr1druvts4vC/EIS3FkgO/FpbkkIiYmJRyGgHexRhVCqgaZa4zgxVmdhDqrph2wczfbFc3Bj1KE2yoXG/8mVat2zxS7yiF84XxSFkmRjtSp+ak9GnATjWwFK8wp+A7C4toUqHrno6nKR4Y+nGqDtytigX1ljwAXSrGBRZsejLLOCOzbCr47yqzfKuMGqNVhwsOD5mRuTKw1PEAmuCMsYYQOoXUkgxIdRQjSvV1JCmkLaf8dasmUwalR7I+IqP93fvnaisv9ECV5elifc1o+8RpX0QSSep1OD3fyTATOn3T7qlkhgSpOD2fy1w/zp7iqnanSiCq88zBdoH+wsEITr8sH9YeBIRnyCG6s8wG0tJhCsWN8zW7tjMRwj3GDLmm2yAsU828SF4qA1BU0wplVJY+dKcu1GJJN+hxHno+1d6aZ/kziBRS4YGRGi2wQA0BFl8iZc7R5LyPy lNsZMBU0 h8DkvB6pa6zImi2ytLIHCN9Ox47seu34p1GCZpRtadp0IpMoRVQbd3EQHCrCHkUHyEd+SdlZCkyuL5mLDFhJ5usiul5Y7sc2rbd9rEKbFaUAgxJN9RbCsrzadXFsDtPwDua6KzDScM8wvm7Ia817r0HFPUF3Revd5fP+v0xZiyD8HgUHG1Qzl0TRcNv3JjXyFfsA1EG7K7k0aQID0ITsmjI1Mtk5b4/HoPLj/j7fPfORRTmkJRnHykO/UmpY1wUw7qza4gXxVONqhI3B7eq4AB26d/O1d0KLDzAYN5tik4oVLSLl0Y1lV642z90Gi7DiRA+XRfOWljEku+75IEfX3aBOl1Ca8V7NGs6Kx8iHznZkAh3yZhzpvG32zNi1R+1AnMrIqjuxUnitTnP5IMG0yPPGUVJVRkI5hfBLT5M7LsYqM5bKjTnpDSMjvik6anb8bQdju+SIwCB/+3oY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000068, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 24-07-24 20:55:44, Barry Song wrote: > From: Barry Song > > GFP_NOFAIL includes the meaning of block and direct reclamation, which > is essential for a true no-fail allocation. We are gradually starting > to enforce this block semantics to prevent the potential misuse of > __GFP_NOFAIL in atomic contexts in the future. > > A typical example of incorrect usage is in VDPA, where GFP_ATOMIC > and __GFP_NOFAIL are used together. Ohh, so you have done the migration. Please squash those two patches. Also if we want to preserve clean __GFP_NOFAIL for internal MM use then it should be moved away from include/linux/gfp_types.h. But is there any real use for that? -- Michal Hocko SUSE Labs