From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A52C3DA61 for ; Wed, 24 Jul 2024 12:12:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD0196B0096; Wed, 24 Jul 2024 08:12:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B80696B0099; Wed, 24 Jul 2024 08:12:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A490C6B009A; Wed, 24 Jul 2024 08:12:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 84F8F6B0096 for ; Wed, 24 Jul 2024 08:12:34 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 462A3C08CA for ; Wed, 24 Jul 2024 12:12:34 +0000 (UTC) X-FDA: 82374534228.15.95EEC94 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf21.hostedemail.com (Postfix) with ESMTP id 564821C002F for ; Wed, 24 Jul 2024 12:12:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=CFcKPrST; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721823113; a=rsa-sha256; cv=none; b=6rVAezTIy+1CYXUx6TINxa2Za/1eUdl7Eb/bneHJ7Y00TcEGhjL9J4RjLu81g2/Ztrbbwd 8SNfVv3d1n29Mgww8NRXC9PntjYR+YRZN4cSihX/8vF90IN9wgr2+ebyrlDRr8vpw8vp01 TM1tsXqohSj+0pIz4mG2vedwwJyu1ck= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=CFcKPrST; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721823113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ghJe96YJfLJ4KqIEOf8cCUZC/HL1XAAC6O7pos/y8DE=; b=p0ZLU2dcuMQfgmuNZDmo73QvgfCRv81ybz5f2UtlyD9qNMBTAZO7vLLbKoS/YdCxklkUJU M96+ocBWboaYq48P20RR2u4F4VTey9SgKIqEe8cQC0jEQ7NVM98yjgbP2g95H9xju/UJvn jdNL2Xc9NqnPQW3cc+vWWeoWvBcA2b4= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a7a8553db90so228119066b.2 for ; Wed, 24 Jul 2024 05:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721823151; x=1722427951; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ghJe96YJfLJ4KqIEOf8cCUZC/HL1XAAC6O7pos/y8DE=; b=CFcKPrSTlFAAycaPBV9SAv/bdwNWiIsxUXQLZIaKKW6BTnFs6+rvPBPO2LKSGIzDga En3ged3kspjc+l7qV+QC8Yym9cKNwDWkNGqMr8uDJqtqgOx7jwmzTsDmSZJK3OLyY3RZ UuWt18DHFOPwopcKn/r0BM7nv0/HCMc3SuNVj6+dRZtbuJX2WIjZ0Yv9kVUIoDdpbTnU SHrQ7kZKr0HHv3UUm4UdPF6c1h5G4AwkO2r0EH76tOQC9srDGOsA4pipZlT6M6JXFEWk 6KpsEkUpCCO7ztI7qb3sM8UnH7LQfAPuQJjNsJMs0nk5S906X4Lj9KCljvVdSo83GyX/ 1Fzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721823151; x=1722427951; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ghJe96YJfLJ4KqIEOf8cCUZC/HL1XAAC6O7pos/y8DE=; b=INWe1/zKCOedtuCob4T71TKDxI+nEfxwxM/js/a3zYWonXXjF1wbruLO4Cpf5J/dMv Rs9MUexzjxph69KHX/1sXNE7WONnmCfiFvAutCzS/1kkiry+vQveRcFhOeQspGbLxYGa NNMPF93Mwzw2QEE1lXSQz/fGRPfl9o1JjiMN4rdDVxZiTv/IhJYIsNGz5bP8/VZKwuX1 Hq9m8veUVkwwTjQKXY2brvnDllXpE/OJOs8zbR9KqnAvTSCpBTc/eFJXNOAyDfVfLQys xNttA9SsMuTq1enGK2iUVpblrKklwPT94WuyUur2J516gfF90XkGQIhNmnF7iGjTAlr6 O4tQ== X-Forwarded-Encrypted: i=1; AJvYcCVtq88Xa6L4mS1PY/yYWbI6290cFAo3pjqLCBbHceVJ5VKAjywSZV2aDrduwGMaS+CWK5QzGqBWZOGpcAgXOomXl4k= X-Gm-Message-State: AOJu0Yz9shlVJZJERPrYfb3VEcAaghsNgTruvgso5RM0frUfoHFzEKN1 cLRlxTa7UCCGDpUCj9aPD+Q/ZJ/uEl3lCzKEPyOdV9vqtg/iXbSMe5Ozn/eqII8= X-Google-Smtp-Source: AGHT+IErPb2sPBolZaki/APF7JGOMN7AOYwHQhoOiHJyA96Ir8YFs9PrTcbMZwJFV0d8bqL+SzDXgg== X-Received: by 2002:a17:907:7f24:b0:a7a:ab1a:2d64 with SMTP id a640c23a62f3a-a7ab10ef64amr138491766b.58.1721823149822; Wed, 24 Jul 2024 05:12:29 -0700 (PDT) Received: from localhost (109-81-94-157.rct.o2.cz. [109.81.94.157]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a4e7a13b5sm544627766b.47.2024.07.24.05.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 05:12:29 -0700 (PDT) Date: Wed, 24 Jul 2024 14:12:28 +0200 From: Michal Hocko To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, hch@infradead.org, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev, hailong.liu@oppo.com, torvalds@linux-foundation.org Subject: Re: [PATCH 4/5] mm: Introduce GFP_NOFAIL with the inclusion of __GFP_RECLAIM Message-ID: References: <20240724085544.299090-1-21cnbao@gmail.com> <20240724085544.299090-5-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240724085544.299090-5-21cnbao@gmail.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 564821C002F X-Stat-Signature: 1t1hdoguytdp5jzadjboh9q9mfqyscpi X-Rspam-User: X-HE-Tag: 1721823152-848291 X-HE-Meta: U2FsdGVkX1/2+hHI6sh6Y9qPvxK4fXq0FD9oAo2KT88PKkP0aaCyWDkC1Jvom1DZTmPbYRKwhMALe4ZzhO8EjP/u/VceXhvMnj5n7imRptthFTi9aCLxafZp5wNU4EyXieEepuwbyhe0L6QkUKejwMdjFvrq912YGN4JMCNlmAYsNWe5tJzvsGa22EK6KDOIkh6mHrrrGN7xD4+WSXM0jYEkQmLK3Mtqe4xgcE+YnedfeTtI0UzH4a78J/n2E3SpCgGcNkRJckaDkJtA7CJBcvWJhct2tMavMBWzjcm9b+dDvrQJSOfCixRCmsnA5SQ+cJgIvdVVPsU4nEjpW3W1ytU/Z9ggOlBnc9NTl9nMJD+ZuSIenfAGhhyceXg7LyhPsP5oFd86wDb/G9/ISF5G/uzHvEartVnOGDLmhcD8c15nFZvHKIViQ7rGvj0AedwDEq35Mc++DILk0ACW/UC29mvqMnp7YFgLg/CaCfH2H1FuIlL5ONZ+3l2dBH9B2cIf+WOntlQIXCQyF2xMcTUsIJATe03ErAo2LaR54dm6BgR8Lq0ujOQh8114MhjYZXsZU9KvfMeDpFfVzKjYpqjnbXkeIdDZTkoGc6zrL9dJWR2TVg3Z6ARCduHI0uy166SeF5vJXyyFVmSC4BiEXA8GAftjfwnQDMkQuu9ZbGiztHATG+dgprXiZAJXe0YU6K8GOvEA6pKOvgtFrGeYf62vV9+lO8b9d4I1yHP5SjSH+/yvatr6r3eJnKVu3ihYayJNwa/ZXYENzticPzc/ChaViZRxffJPyLF32kWNqJBj3wXG48xtvldUa5RSHIx9uk4jw6D0y6MBivpN8bjQmbC2tHDLpLG3P0oEWjg0nyX62gjqVt/4KZ951SZrK0/er4C8x8wmnI1JQX3OA4Q9inc7cDgC009/aI5ggJGBUG3gPtyo01zbjDYrGXJ/Voz4fAt7ZwqC07l+9ukKaSaBPLX HpTY9UrH qTGlnwclZKR0Gf7wrGFwN4SMKh81fp3P8WL9yE/ZctUm2cNPH+DihwfTQnfNOKlrq8CsRNPdoN46IEBp1sHcPUa+7/X5/+faDXasBb4Lt3RVdsWmH4SvcjxcOnS1Dlh4azehoFYSwatqNJwTGoWmP5SCyZsNMqE9xqktBCo3R98PfyPI2bTlnnQVCM+kZaneIxSPwfbN1z5EYSKBQYg1JqyKFroqBUFHLpLO3hnNgz0hJUAIleK2O5e8qQqZeLkVW79OvFRa4Lvl6G2N7J6weYQ5XVb9jN5q23dtQgkyZc1nmoueE9OzuVyp/6tpuboDQnOiGVE0pwngVhjc9TlzdMzuPcA3Z4OUY/M0+vl3rylaOsoUAjIySpxoNd782Jk9b6FHKoEI+lhb3dGNP3UPGjXcRDD7jkEMYHHRN1cskBXw9Jwc1oqYwwN+SpkXoqG2QveReFTnpOjjMuKTAahyFxl75rw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 24-07-24 20:55:43, Barry Song wrote: > From: Barry Song > > Introducing GFP_NOFAIL and gradually increasing enforcement to prevent > direct use of __GFP_NOFAIL which might be misused within non-sleepable > contexts with GFP_ATOMIC and GFP_NOWAIT. I do not think this makes sense without removing __GFP_NOFAIL and changing existing users because a new flag will very likely not be used and therefore it will not achieve the ultimate goal to remove a potential abuse. > Signed-off-by: Barry Song > --- > include/linux/gfp_types.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/gfp_types.h b/include/linux/gfp_types.h > index 0dad2c7914be..1666db74f25c 100644 > --- a/include/linux/gfp_types.h > +++ b/include/linux/gfp_types.h > @@ -339,6 +339,10 @@ enum { > * recurse into the FS layer with a short explanation why. All allocation > * requests will inherit GFP_NOFS implicitly. > * > + * %GFP_NOFAIL employs direct memory reclaim and continuously retries until > + * successful memory allocation. It should never be used in contexts where > + * sleeping is not allowed. > + * > * %GFP_USER is for userspace allocations that also need to be directly > * accessibly by the kernel or hardware. It is typically used by hardware > * for buffers that are mapped to userspace (e.g. graphics) that hardware > @@ -378,6 +382,7 @@ enum { > #define GFP_NOWAIT (__GFP_KSWAPD_RECLAIM | __GFP_NOWARN) > #define GFP_NOIO (__GFP_RECLAIM) > #define GFP_NOFS (__GFP_RECLAIM | __GFP_IO) > +#define GFP_NOFAIL (__GFP_RECLAIM | __GFP_NOFAIL) > #define GFP_USER (__GFP_RECLAIM | __GFP_IO | __GFP_FS | __GFP_HARDWALL) > #define GFP_DMA __GFP_DMA > #define GFP_DMA32 __GFP_DMA32 > -- > 2.34.1 -- Michal Hocko SUSE Labs