From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40924C3DA63 for ; Wed, 24 Jul 2024 13:21:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D4C56B0083; Wed, 24 Jul 2024 09:21:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 884686B0085; Wed, 24 Jul 2024 09:21:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74C396B0088; Wed, 24 Jul 2024 09:21:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 507CC6B0083 for ; Wed, 24 Jul 2024 09:21:18 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EF4F1A3F2B for ; Wed, 24 Jul 2024 13:21:17 +0000 (UTC) X-FDA: 82374707394.18.ABCB659 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf18.hostedemail.com (Postfix) with ESMTP id 0608F1C0027 for ; Wed, 24 Jul 2024 13:21:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Xp3HCw+B; spf=pass (imf18.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721827229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YNUPYZPUPF5IRuryyMfTcw97wY72+AFm6FhJO5pkfgM=; b=uk9MgyfvTLKkBpswuUF8o2hJOE7N5ciRS3bTiLOe/XM8t00d0imgWADdHGc5mSTMdhs1Te zn+Xm73MDv1kTOZXp6Rpv+FNg1v2jxQ7bv9yD8pUY6vIM1ceeCEjVoda9jneDHzGRl/9La ZN3eNcr47FCcQBSP8YWuJSg5MxmtsP0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721827229; a=rsa-sha256; cv=none; b=mlTZNUmwETJQTC0dTy2I3fjEs7Wh4iGnB5L+TuOIBfSxcGI37eFJwlPJ1YaRRg6k3Nx3Gu LB11pjC9MMo5sCOVnvFc5IUCSFKjMOeKxBETVIuCg8nMEF3Spr0Dy9Ve2kee+QURo2Omlh 9kkVm/fp0H7OXIP8D+wLJpj09JW7jeA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Xp3HCw+B; spf=pass (imf18.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a77ec5d3b0dso102302666b.0 for ; Wed, 24 Jul 2024 06:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721827274; x=1722432074; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YNUPYZPUPF5IRuryyMfTcw97wY72+AFm6FhJO5pkfgM=; b=Xp3HCw+BMt40J9Tdiuq/vGB93Nvve3lsZx75wDrXadCTsewdyB2ACaSHa3ZVCrr2dk Dj3TET9tun4kMEeUOm4npEqeF9pdatORvSDDH60a3NYFxbdU1tIv2Uv674E59uWgI4dc QdvuBlFCVuhTei5C2G3NLySs8Noon40LPmpYnJzpg7DQxTCZscEI+XDtGfolaG7+5xGf bob/jsZeOPMWExCxvm6Olws2ijYxc1FPqnNKciBnjaruHnE6x70IvRWTdZFvyVWA5Mvx NeFt9S+nPLz+GNWL87K4Kk29snzLMQsYzh2hVS7XxBEjOAs9vaafhLF4jde++hs/zSxV Kbnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721827274; x=1722432074; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YNUPYZPUPF5IRuryyMfTcw97wY72+AFm6FhJO5pkfgM=; b=m3J57dTVHO9H7WyY2BwLsnzsElP+WzFq/8x9WY5wSj+5q9XsC+Cjjtb662Itca5IbM C/GH59WWV4FrCBkJ6Evbi7sFPvkyvbajloDIft+Aqny0AHkY1S9hsC4Ve5qzQ+4Cp7yz /7EFAs2ufCRSCxO9clh7GHXPNlAowyRL4GQe/ZlnbTlTDfET1/c0wl7qHDXwgOnJYPVc UVszNi+r7Q0RdfIFnbdBjsXD1dQQqTIWRoc1yYq5ughicY46vOb+hd+KjGBr6wuIUab4 vzeyFVJy+6EkrdkavqmZxqenAtNHQXRCe6zi7CQtk19Omu9SMAvURBFXxcQV7A9UFJFJ EwiQ== X-Forwarded-Encrypted: i=1; AJvYcCWiEfSFo9lHp+rTmUa3N/43sMJ+l2X8tyJ9v20N4ikEyk/AYuwMySoUg4OD8hgtqv+D371fRQf4N6GBIxnmjMjbqGc= X-Gm-Message-State: AOJu0YyW0lTuxVXsdwaJAI+VLngpxcbYFqSOpoFb8c+o39CodD5To6ON wKXV8keksdOqPlpauypW4kiO3VMRGNPd7i7GfiRjtupJ11mRuBfCztyBGR1mU2k= X-Google-Smtp-Source: AGHT+IHOa18wtKZsfJu4ca/qsfjBm4+18JCliIzvAL038tAW2+zRsGw87m3n3V661dKG7nwo8bwhbQ== X-Received: by 2002:a17:907:d18:b0:a72:8c15:c73e with SMTP id a640c23a62f3a-a7a4c2a32famr843447466b.55.1721827274170; Wed, 24 Jul 2024 06:21:14 -0700 (PDT) Received: from localhost (109-81-94-157.rct.o2.cz. [109.81.94.157]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a92dddccdsm188399366b.79.2024.07.24.06.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 06:21:13 -0700 (PDT) Date: Wed, 24 Jul 2024 15:21:13 +0200 From: Michal Hocko To: Christoph Hellwig Cc: Vlastimil Babka , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, virtualization@lists.linux.dev, hailong.liu@oppo.com, torvalds@linux-foundation.org Subject: Re: [PATCH RFC 5/5] non-mm: discourage the usage of __GFP_NOFAIL and encourage GFP_NOFAIL Message-ID: References: <20240724085544.299090-1-21cnbao@gmail.com> <20240724085544.299090-6-21cnbao@gmail.com> <68ee812b-3b96-4c8b-9a54-70d4742488bb@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0608F1C0027 X-Stat-Signature: 9tq3zd9xkhpdrmpisbxq54pozuhwxwef X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721827275-912720 X-HE-Meta: U2FsdGVkX1/QhcZAhfhM/zkrqCg72x7s82zu8DH40nFDvn+j4yIIVjgPej/JJqchhATFBQT/642Qrhz2dLH624lefAvKqPp4RmV5K38RIqCkjida8Sd4MNbASpV0ocmZObUGXr5AIdWa5MONh0VotKsthfLdsulDXO9T/vOLaa3e3NgS83uTrCk5eJ4S+fRxxereYOkRImxFeJPSGEfYPEfQT/i61Pe9cUe4HTzCicLiL3t0tv1dOpsFuuqEG6EYvnT3WtNjfNalrsQYFoZ0W8DZNti+yf/KhWMBh0+Xl5BJxqhZTflih3Yc1/gVHkOuFarNZpYJNa/jcLuI+kq8W4uA+neHHk6AZWwLszByoQn233gd2OFTiWVUlAssIJYV2RtH6OUEkJ9BR2x9zj9+nrGV4/mOEbTnDt49Qz2wEhpnzQ/jOPC0GLFlOg3yyKXB7kusncRlXPSpf44zR4G804BLmz7cigS5eJWXxGXuPdSBjZpWwpnzb7QXXUC1kNY3Ayvj9o479IE8+NF3x8a5nXL79DqcXFC+6iinztAkbNzuKeFBR4oRrgEzojAcgkYslqD/nGgehlUItOnRFjnQ8vBmbCiQMndCpPYj5Ogh3MuMGrqdEdddCl44GmWCJh2zbf5P3LSly0cebeMuiatmzZyRG3EnTynljbe8zKOLCdGPEgUqQr8PNvqF6OHi1veu8NjjndMInlh7fN+thNwDbV3j/6Es2Z2FRWAV2m6CyHK7V85GGAknUGEQ46CqnB4ornQDgaE5OL1wjMWQ1n4atWb1gy1+aeZR3aYtoB/jKQSiO/1WIYmTTiwrDzLCCd6quxyTpYvZpFcKy6RTFCXKdpEUGiXkyfkg0watmc8IK6Qd+0NDD/bpiIU+2g8JNA3SoIc1z4UofQgQZoKtRtUIybB8Yspk47fFB2cPMSTgJ+9sxXzg9Qno9MeMug98nRpHOzNfVK1tnj89dU8W07K odfo/r2G ezGIE7HnbwrDZmJqa3bzOLltoyMhq7VEhPTNo5EHXUTgln6Z5AlJgAkiEyOAvlL5wIdrbNCt1ew+Cb1KtKbSngW97C9kHNFw8hCpNsUm+vnPyhfKP3M6ukshcFxCcfnXXJSW5gy6bBMGBnCtFlOmL4xSedbWSzl44Y7IjK8ZTo6eQaoJyWeRCdCWic94s2kuGDnWSKba6K5ZOE8rm4WCvi1FSz4mzJ5tsnqfqOGN9kntA6qDGK1NIB5YdBaJmICtii42yUgox3o92xvoQsz+DyjNPb28Ns/AKxN/wp2xi352HWFjGivCQmAxnFoREt3dDpRF9HvTYtMWafMJwmMr28yET5Npzrub/lUu2LnK37i4ImYNnXBZFV/tQKTLZVNnbbb/awQykzJLgxUx0MUVOT2xF4Zh/yJYlC87t3Ua9d6Sa0zQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 24-07-24 06:13:31, Christoph Hellwig wrote: > On Wed, Jul 24, 2024 at 11:53:49AM +0200, Vlastimil Babka wrote: > > GFP_KERNEL_NOFAIL which is GFP_KERNEL | __GFP_NOFAIL > > > > And probably also GFP_NOFS_NOFAIL and GFP_NOIO_NOFAIL (sigh). > > Let's not add these and force people to use the scope API which > we're trying to move to. I think we should be able to simply > have GFP_NOFAIL which includes GFP_KERNEL and no variant. Scope API is tricky here. Exactly because the scope itself could have opportunistic GFP_NOWAIT allocations. It just takes a library function to call from a scope that could become a risk because it doesn't know about potential scopes it can live in. -- Michal Hocko SUSE Labs