From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF37C3DA63 for ; Wed, 24 Jul 2024 13:13:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C048A6B0083; Wed, 24 Jul 2024 09:13:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB46A6B0085; Wed, 24 Jul 2024 09:13:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7CA76B0088; Wed, 24 Jul 2024 09:13:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 88C736B0083 for ; Wed, 24 Jul 2024 09:13:42 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 14AA7C0970 for ; Wed, 24 Jul 2024 13:13:42 +0000 (UTC) X-FDA: 82374688284.12.F20BBA6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id F3E8E1A002C for ; Wed, 24 Jul 2024 13:13:37 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=3vx96B+2; spf=none (imf19.hostedemail.com: domain of BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721826796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GrETT9VNYgf4d47jWkFIpN9IEwQQPLWYKreKr1WWr1Q=; b=IW9jXtI19KjBkko26bGcXCGqTGCTOPvtAvW3D1zGq/f9MNR0k//7FlctoAEyzX9syHk5PE FFrF9kwMDmtqxN3dMyq7M8Ieeeg//H7EIr9yoxhq8KHYGcIuO1xZCLkfarMFJ34s2ogoaH DFQfDrj25TK7hYUK0b18FerDmCJ3OOk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=3vx96B+2; spf=none (imf19.hostedemail.com: domain of BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721826796; a=rsa-sha256; cv=none; b=kyZR+KrFfaLR2uQmhliK8rK/zTfTtNHr7TuXuHd8rcriXtaRoXiQl/vNCqMHhDRx0+T0N8 MWsI4hmdWY48SmNbEa8d0cmJBscaQvjCVTj5Cuj1x9Wh8hGER/VLfvVmbXmt5ZLvCTLsy6 ILKtq2fRWklxp3m7Uze1TE0fBE6GRxc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GrETT9VNYgf4d47jWkFIpN9IEwQQPLWYKreKr1WWr1Q=; b=3vx96B+2AKbxghePVkvsvr85rD J61zwAd47IVwiRFL8jB+jlta7RDYg23P8V6O+496ZCq/3eJP1nSL7N0RNeSY4SKEQykkttvvkx0RQ 4lZeKtEcEohMLkRXch8halPBdQ2HBcdEUwLal3MAnUGfDrW+WSnvhZnnJTR4Kvlly4Rri1+8vsl7/ 3RmRzSZHw5Dl8LLj7lBnch0LMfcTv8T04rpsrx+DQS4tAn4bLZk1jX/YixdIneJg+lp8EmdgeKaev GSKP/tnB77i7DChCzSRA/qW1AjZ4dLX0h43JW7Q/qbvDQFpq+wuOyS6Av1MvV9I4Js57stgiVZQFk IKDGDCvw==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWboB-0000000FPaX-43uz; Wed, 24 Jul 2024 13:13:31 +0000 Date: Wed, 24 Jul 2024 06:13:31 -0700 From: Christoph Hellwig To: Vlastimil Babka Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, hch@infradead.org, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, virtualization@lists.linux.dev, hailong.liu@oppo.com, torvalds@linux-foundation.org Subject: Re: [PATCH RFC 5/5] non-mm: discourage the usage of __GFP_NOFAIL and encourage GFP_NOFAIL Message-ID: References: <20240724085544.299090-1-21cnbao@gmail.com> <20240724085544.299090-6-21cnbao@gmail.com> <68ee812b-3b96-4c8b-9a54-70d4742488bb@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68ee812b-3b96-4c8b-9a54-70d4742488bb@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: F3E8E1A002C X-Stat-Signature: ys9xojsg9ztcai5bmcasi1cbr658i8d4 X-HE-Tag: 1721826817-968892 X-HE-Meta: U2FsdGVkX1/IT8rn0jU9mk7wVJsLKu4x1A4Ri6uKOxZcR4Q31d7utySE0zFkUgMzpGQ16053aQ/de38WUUBuNdEB8F2XDNnfXnokBfgx/xYY1/l5wN/W3EN3g87zIBH7jEycZV9dr9coKkiIrN/gzTQSACrSfXKzNBbTPDMMWGMRqHbXkEqizVR7dNfue5vkZkZIJlY9UGPPkP6ybwO2GoyPPXVxAdXM4RG/NpPGCBgm/AxfbawBYsJrDrQnzHkKgFOnFrPNiGCC+OGMvoIIdbxVu7F5WL0yPBlARecACYJI8gk+lyLRzzKQPoLdyeIaNSVw4Xk2QncTT/3DlzhwOyvmDYUg0F96eduTKrdaQplUErJvXkhaz3fNSlCz6PG8UKilU5o8WtLbKgr3/lrWolKk2JaIuQDNfcry/dhUeE/k8TxC7M1nOPpbCfsVxS/pU8qEpAjNkrwCkHHZneFgKetpozrO5TyWOTrUB2UjQDDSwEeeHPWCQ+RXA4RLImb2oGuDity9q2+bZKXCQ+LrcmdWEaQ2EkXs6zpMXBCxqlCxxj/QQH+9/2ZcxcmtYJhm+uZ9Q6Pcs7I4HNEN+SemnHWO88e5ah/NcrBr5MG+HYyhrs/R3uPul2xO4SFeBGbfSymrCBXZqnk0mM0XjC4QhMOkBG3AZjgtTyPyarbXwovoUiuwOGX1uBGni4RTrEKfohvPZvkFrSHfqngjjftw1F8b/HLAe2gISOFn/8dKSYewcMef0vpO1pYrJ3QFs5EGhB438Sgj5rhax2rotu5zC9fDnvz9TtyFy0GGXzRGUYXX1NmpP1o/d+EiUEzqFebL/BK638pUc8V3NbvqA7+mu8BotOXHUzfNKCTr0rAwFOf6oQ1vakpaCPVfAxYBIVVgImjY9XOS2B6domOha/08kp6Oiq0Kszhl0O2BxztvcDHTyLTV9kqNciMxqtaL9LUmPVMY+Tt+Wkq/tkZZE/b TSMLLajp 0U/8KoB5nerdOgxFzMzCqT38fkdBBYYFAvx2oUCUsB7oDjvd66/IDQsnbnV6NfZg5xwbXfC/DjSeJnsHbZZy0R6X1pCDrrfoH2+dOuJvHHW5pi5kdCDayP1GK1ioNWH9wNGFfH/8PF47RgbpuHnugBSEZ9g/4QY8jltpfhkztCJ6ru1/HoyHZMxtsJS0TogpvmqJU7crY937W4+OnguaVx/md54jOQAwSvgSl3UmnNxQtfqhsgP4Ax0slZ7dvenVy4x39Hj4ikECiZUtZYZff+lrROxexhBQMc8ANFYYBWJl2VPICReSDXebAQcqzOZSuen/Hx8fDYsU2L8eLOp0hvZvrDP5nQy7FVRXr+5OJd+clx8b83BtQsof+Xm+w7vxuPW6teTwlxPipORZqrLbPe5rwMTxf4jtHuJzgBrgbb/iOYgMEFogxCUjDdadhTj58h89Nlr36cDgrYmephEHYPmBCO4ABNQNzXgkhob8W5nDGkodGhmoBm0gHS3lVKrDIKuBOLQvmY5TO1zg1gH0yx1Zg1WcBLcBE0eNs1Q2paWQ8yFINDCYfPc2k4bhAi+2Bwtk6trOsBaMMP88= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 24, 2024 at 11:53:49AM +0200, Vlastimil Babka wrote: > GFP_KERNEL_NOFAIL which is GFP_KERNEL | __GFP_NOFAIL > > And probably also GFP_NOFS_NOFAIL and GFP_NOIO_NOFAIL (sigh). Let's not add these and force people to use the scope API which we're trying to move to. I think we should be able to simply have GFP_NOFAIL which includes GFP_KERNEL and no variant.