From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F2CC3DA63 for ; Wed, 24 Jul 2024 13:14:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C525F6B0085; Wed, 24 Jul 2024 09:14:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C02D96B0088; Wed, 24 Jul 2024 09:14:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACAAC6B0089; Wed, 24 Jul 2024 09:14:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 827B26B0085 for ; Wed, 24 Jul 2024 09:14:08 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CB0D01C1812 for ; Wed, 24 Jul 2024 13:14:07 +0000 (UTC) X-FDA: 82374689334.05.D4A1CD7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id 254CD1A0013 for ; Wed, 24 Jul 2024 13:14:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=E2nEXqn+; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721826807; a=rsa-sha256; cv=none; b=htSQd/p3g8KFjgbziOMOa1MhDYajgCiMV3DucjwfueUFD/wGm5S6ziIP9Q1MJd9M3sqf/M 7T0IiaZM1LPrXAzX2G55HHOw9PeGp0hYcH3ljIJpZuSAJIXgH7LAvazfwFIc901E78osbf 79M+U6LjURdVE3RxiXw8cdNEJmCfmko= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=E2nEXqn+; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+577de27a8df23d97afd0+7640+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721826807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QYUAYKNVGiDZfrUKcYDM3BEMBDYiIsZnK62rgUn/E9Y=; b=qRSQ8bT4rnosKckw7fSh+l9St1Pjjhotod0nfNKLi5I/yJntXQyUCGQQV63B90nI17BI1v BSVXFEH2ie+JioPz38RTvTzOvo9HwOFezScpbrUwowLlfGa0+4Tw/SH5AkKG0+unvq7art 1Ce/IUOp4x8MccF56pfLEzrNILQLJH8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QYUAYKNVGiDZfrUKcYDM3BEMBDYiIsZnK62rgUn/E9Y=; b=E2nEXqn+bj0uv4LnxnwABC1Ta8 rJr2cVqK365oEXMhbVAs3b/64DmZ7Wp0SOqefL7ZCKS+PTcKRmM2r3hbNE8QAyrcS7Xsc160THB/O QYmVP8kM1bM2aGuhOFWw4WTi7Y91YlrhHjw77tEsZCSaPANFUUKOPyZFKsf5vp5peLmacTSKGA0C3 bfLHnaKAzp38B+3FF1fvQLZza037VQdddlh69v1k2ptcBk339tu8I1vzb1Ws596c7tvP/+Z7n6mWF HcCelRUsPPGoQFWGI+RlD/ZmKQG5f8rMvDHph1ZwhG7p1ykWDJWxw/RiLAw5zSCPGw1pKyBV/sJuC CM3fn/EA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWboi-0000000FPe5-3NvU; Wed, 24 Jul 2024 13:14:04 +0000 Date: Wed, 24 Jul 2024 06:14:04 -0700 From: Christoph Hellwig To: Barry Song <21cnbao@gmail.com> Cc: Vlastimil Babka , akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, hch@infradead.org, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, virtualization@lists.linux.dev, hailong.liu@oppo.com, torvalds@linux-foundation.org Subject: Re: [PATCH RFC 5/5] non-mm: discourage the usage of __GFP_NOFAIL and encourage GFP_NOFAIL Message-ID: References: <20240724085544.299090-1-21cnbao@gmail.com> <20240724085544.299090-6-21cnbao@gmail.com> <68ee812b-3b96-4c8b-9a54-70d4742488bb@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 254CD1A0013 X-Stat-Signature: 3jkcy61txwhufaszscdtkq6qwg87j1kd X-Rspam-User: X-HE-Tag: 1721826845-360548 X-HE-Meta: U2FsdGVkX1/FL6ELHTiTNdAcQGRckh18vVtuLBCLto4vtT/ysWnRxeEEcz1kOzVI1bnkH210B5M816aVwMTZpOJK/baNZkFmBa8soFzTdnRX/qo8a/UcUBerXMWrwEj3PODCsXKG6wzPoB5qm9vNtPYttkKOTSuOdKEFzDBgO3FG8KXK8mJcnUXj+wsQ1UCpW/wCgXEiZExe0T6CLxRgnwiZt/mmPI17CiRYDPd3BBwR3WnlAl4Ouy8A7IFElHrcIwNkOj69bugu9HEkdkzZ5onU7wuD8V6lMeffRPuxIBGSPkLa4dsW8wC9zDOYAdUCVvxiSQI2ECXoyUD3GI7T4u8b+8n8n4inWk9vnQA/CTort2pgji/gh6q/tSTp5uKSzuTxB4l0LdhTRiSTzB473soa+tNkU4VVQK9yipAaBHcPtkPA9R/mTcDoa/9AENhV6g1W0sUULWvR4R1ACSPNrh/WijGoAln3oFy46hJJHVKABGjTlHcEQhiJgX1UxMGvUHf4L683wQqYp6yeP2bZgJx/FiG9ca0Hiol+DfjFy2OvSkEk0pgQR6ry3wyRTAHQvqa24RuR+i32SBzh1d5eQGbevjCks8XNDOvaGiSjtA4A1ihN2KlqJ8YilS/NrmgTIk9dD87XxTw7ThbBKY9mZKAbvDYk9XblP+QgOOoPiGM1egmmE0iGpbuJeAFx+cQ24prTfzGXCJ9Nm5XpW0Rmtce4krDbWq3dPwtoifP8d3742jfgd/Yh2vXDtGm9SiHP4PTK9phwSrU5hHGyBi4DY6HMi3FEqblBp5ii5kowzAxJMBMdg30dRirhBoeDiuLkbNkOusi3fERYAoZJKXcqY09lZX06MbTFFc7kh+xh4vbVVVI0wpwqJFL/dkeW2i9BQteiKZFlDgTSTqNbLJdr07d8VS4xHifqzgqcjxMoObkvh4yX+ekUfv41tYqV7dBvQ72XpJGrJYeTtIt06Oz iMd3xsuP /vZ2mfZVpAfrdkjKkubF5jx1pZk8dZPOlLyBcCeGDMcR1pC/s4+OM8vx1CJwG1RJWFJf6A4io9KkcSLE5g6Ojn2tMdiOe3k/ur/PC1J/CLeKWPM1I3y6JLvkj9U4SzhpBCystFPSU0BirLOHEm/+xtbktdteKbYW9PJZly4hB6JxWxE5bBlsdeFpn5pPKfZpbeFIdyFRoWRd40RKfiIAbNDsI87tmnGy6d+UGc9VqGH/Xae+kTFMp8ubTgZjYNkm9ss6YZ5doQVpCL61QtID8Xe6wjgucq+49ndLY5YRQl29XL06HhMQlXAc8thTheQuA1Zn/vQ03UOie6+2LiaWOWHfKSdSgNATOkYDZK6qMFl9MckzI+YXO+Fkn6EsDEtg+/3+/kUEyRh8Tf09/gH3lkiRJX5YnCLjryJ2AWNEkheshlp2UhHjygxP/SYHhPovcek3duH97p54EYtkWirTHJKMHjEaKJll/MEn9/uPf1QYNWedh07Wi6sjpngg0DJsqv4X5zijzcXfO/bOJpvkw/zfev16zRpzHYwGf63Wu01xrVTpH8NeovEm6w24U58PC/SPi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 24, 2024 at 09:58:36PM +1200, Barry Song wrote: > This is true, but I assume this won't incur overhead at runtime since the > compiler resolves GFP_KERNEL | GFP_NOFAIL at compile-time. > Only readers might find some bits are duplicated OR twice? It's not really the overhead. Having a single main flag make it very easy to grep for and find abuses.