From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B1A7C3DA49 for ; Wed, 24 Jul 2024 00:16:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDE9E6B007B; Tue, 23 Jul 2024 20:16:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D67326B0082; Tue, 23 Jul 2024 20:16:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C08096B0083; Tue, 23 Jul 2024 20:16:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A148D6B007B for ; Tue, 23 Jul 2024 20:16:11 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4AA03160507 for ; Wed, 24 Jul 2024 00:16:11 +0000 (UTC) X-FDA: 82372728942.10.74B2B88 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 2DA0E140004 for ; Wed, 24 Jul 2024 00:16:07 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="B6s/WTDW"; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721780107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+13C47ZHmH1+/AbC2K1sE8rWUkwncoQ44bN8mj3d5O8=; b=1jq8hzeIG92HjJz2scGnM1l8DU0QLRvBHAH8jQfw7Icc52Xg+MQLUYf98b4Sqktsnxi4po q3FAZun3nZeptqgJg3rIQP0HhltqPa3JuRGCt0fBKE7KMXLTbwxaBFhqcoJbFFSf4H31Th UkgATAP77GkDZruy4b81mieNq2RPkwI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="B6s/WTDW"; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721780107; a=rsa-sha256; cv=none; b=RoHEPNxlVFTqvHFXmr1Z3UxJUtlUdlGo6YvOowEyYjmc17yoHfnKT+2bkQxfquZ0h3h3eO ukE82vKt0XkGUuSjdEcxHYoSWUJcYV2IWGaJfQYxZ6ysACj2ZHk8LakenqoCrzlQs1Vb/F 584+AXZh+OU8a61y+t+rZr4paya8aGI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+13C47ZHmH1+/AbC2K1sE8rWUkwncoQ44bN8mj3d5O8=; b=B6s/WTDWl83ZaD7yEFAS5kvS/j zeehTkADxlXDIhox/7Vr4pUxISf8qKbn7gjOKHBuw2Dj11UlM/o3qJVtERnlkp0O2mjc0klL2bKc5 hg7VrztKoOwoE9xHIGY1eMMXnDN1I6ygfSKrmSXGVL5VCMz9oIfCrKasAqDxgQHKgXKTXxhb3sxTK WPYgfQ2X54HsStH68nb99M8jELASZpcKwz86ijr9BxsrrBGkctkEzjaxyMR5+yksCwbm0ZJSymAp5 NAvwc9UYsogKL/RDaHpODA6TL8BXIaQHowLg/yBmn8IucoZH7J8So5wNsERvv99tuqYJCLJRjPF1y C0JgeUKA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWPfm-00000007Kfm-0ye4; Wed, 24 Jul 2024 00:16:02 +0000 Date: Wed, 24 Jul 2024 01:16:02 +0100 From: Matthew Wilcox To: Andrew Morton Cc: Mary Strodl , Christian Gmeiner , Christoph Hellwig , Mary Strodl , linux-kernel@vger.kernel.org, urezki@gmail.com, linux-mm@kvack.org, lee@kernel.org, andi.shyti@kernel.org, linux-i2c@vger.kernel.org, s.hauer@pengutronix.de Subject: Re: [PATCH 1/3] mm: vmalloc: export __vmalloc_node_range Message-ID: References: <20240718143103.82e33c556b2d1b6145ae43e0@linux-foundation.org> <20240718143924.43e22f68cf639b064a83f118@linux-foundation.org> <20240723170043.4f17a3d0b6280e57561ba1f5@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240723170043.4f17a3d0b6280e57561ba1f5@linux-foundation.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2DA0E140004 X-Stat-Signature: x74whmx589c9yeg8ddq6run19pipcnxx X-Rspam-User: X-HE-Tag: 1721780167-24346 X-HE-Meta: U2FsdGVkX19stwOjmuv8qSWIqz/+bDyzOP+EglGFfY1sJ9VB1MNhm6/Lzevl6znu/O78p+45IjO4E5dM0eGruRt6A5bGlofc/aLyfm3bCCFbVLTGrpVICGtyojekAvRs8KqgV9Uwxs2DggujtePyJZc/rG9oCXDq4Hu/96LzisMykLs9UIcp50nuXEcvehtOMbx46cjyxzZlXPag4tJBgUAuXje6VrvZxKz/9s23ZEGfGk3KSW+zAifw5pJWwDoDWklgopE5EAmc+Dp5XXd1lJNTN1fnpGy3T8fQg3E6SB9odJm1i7mpQKF7uMzmhGGC1mEURLZAHN5vi0WcWRg4z4apslHLP9CJxTteRVvHklyuC9ynyKc9F/ezwWrlrVkYqeP2T7pydahXafotjBLeT+Cv9wmjPjYBHKyFFrJVzr11fO7EajKFdu0eFFjh10Q9WWoINhvPyZ3AbOI3S7dqnuzEy/D0JwkrsX1a4eQJ0b9DwzTdxzO+jGbbQGAvYxMVtJFP6d/AF6sebeFkYgqELLnJ0zM1/eam7QgkU6oqcjxKBcCxzROxmBO/WAjlIwiE2NgAKZ+tJNcCVQ6YnJSA7G6kW1eF7G2/ImpDUTqFDiimINZWkDRrRh+rTgd1EHXoEdEDabBUK06DgN9dqu/x05gKFng6iYduL7O6yDCHpXwi02PmFwkHwu4C8PlNEyiwSu3slA/U5Rji0N0bfSgTyWQ6H5P51uxeX/bWPshXRhWZCju1419+KFIFPZBN/FL3ixXIiqV5MMEjYVBdEQIsMEL6Mk+ksJFgG+qJxCiU+T5fhNk6mOKtBAFaVCtHHoBpoWaaXKsK/zeuSn4sZ0MAuZE1H0/yOeoMTjJMIZOIeoU23QD6RRYN1/Av2MAGZmC1p8i6VE/LzPxPqg7RouxtuxDNRIiE1ubtXso2NkPpkTwyw93oWebHCdf9zZLNXTBajcPyLkCfaV9Q3dz8LTW wV8Y7UaV GYBSmsYNC2QBdbR7kDmkIvbXjg2vzNHwWBhTYZ1DYqENKCeMh8vSJedtp0Ql5QSVluZnqIP+NjuyziFL/po+B7P+U/jXjsDmwdSvgZ3CBqYv6UAD6QIXoydGZJ9yfsxgj0//4EQtAQUuNNE5ZVZcPspcIgn5RvsJ0u5CD29DD7M4tXxWV3ksgGH5Z7Png0oz6Yd90i2fNH9vsNnJ5nQpPa1qRrO9v2O6995ML/mYDS/zo6C9LdKQIiEVHLtWfMdSlwg+gBF0aUWHz4lWo5OjspJTd0OaKfkbeBxATpR//cDpTWYK+hdc4udcZ0tJJpatiBgEgU/Mtl3yFn3zRdP1UTS+KfTOhXoQc2Dm1MTOnXxwzG3TdEe8fNfXCnhnqVNKebo8rxWJ9lHAFDOah2pA2AV9g3J2nNLOxKZp7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 23, 2024 at 05:00:43PM -0700, Andrew Morton wrote: > On Fri, 19 Jul 2024 13:42:40 +0100 Matthew Wilcox wrote: > > > On Fri, Jul 19, 2024 at 07:58:40AM -0400, Mary Strodl wrote: > > > Maybe some of the stuff the driver does right now could be moved into > > > vmalloc? In other words, we could provide a different function that > > > allocates an executable page, copies memory into it, then marks it > > > read-only. Would that do better to alleviate concerns? > > > > No. We are not running arbitrary x86 code. That is a security > > nightmare. > > Sure, if such a thing were to be done we'd want it localized within the > driver rather than offered globally. > > But if there was some hack within the driver to do this, what problems > might that cause? What are the scenarios? That we're running arbitrary x86 code (provided by the manufacturer) inside the kernel where it can undermine every security guarantee we provide?