From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1232AC3DA7F for ; Fri, 2 Aug 2024 22:43:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95F0B6B007B; Fri, 2 Aug 2024 18:43:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90EA46B0083; Fri, 2 Aug 2024 18:43:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AEAF6B008C; Fri, 2 Aug 2024 18:43:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5CF3E6B007B for ; Fri, 2 Aug 2024 18:43:45 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 07DE1808D9 for ; Fri, 2 Aug 2024 22:43:44 +0000 (UTC) X-FDA: 82408784010.09.113AB32 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 01381A001B for ; Fri, 2 Aug 2024 22:43:41 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UfmZwU1S; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722638574; a=rsa-sha256; cv=none; b=mqbQ2c1rP69NC+agzeuVtwrHYvS1WLztinwvGTmNtkyFwVj+jFcdPHuD0PK9JShu3O6bP2 kPG+oHJ7ut7bC7XLStuDfjeIDeFqB4t29399Ec9lu+72kZJTsUXa9EZc3kRMjvZVNUwOEq jJvCJlfAQhSEwYxmnGsr/4YjajC/fKk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UfmZwU1S; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722638574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kWgeUNWYR4zhRqTU3LJS1HQO1SCauqzxtnFFVDzZSg8=; b=tv1KXNTIwnJtVikiskyv72MuDEn6EUheLSF1D6TU8SyCTSFpoTUNsdXLnKvKdQi9+IsqWd jHrr3xy6I9I+nqEhKOiL7OVtfWYWR50Eqo6GtPel7WBylZDtxTEV6IsMDEV9Bk70ucqqIc 5llfOcUiVJs4elzA2/Q/AU0doBemHjk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722638621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kWgeUNWYR4zhRqTU3LJS1HQO1SCauqzxtnFFVDzZSg8=; b=UfmZwU1SOxfdongsFtlR2kvEGPfDaJEWZbqAnovePNowD72ls5S6gZs3TB8o2cDfmdFZOq 4kjWiqJW2c6e996ab0kglJ5zfky+dPQtZb8WeBPWSsNBgEnl/zfmx1DAyQXeguX8GXtF6L rHvxizb1yFinoOLQbJLTCkr3iJTg2Z8= Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-nXVIwQrQMjCUDXJcZx9PPQ-1; Fri, 02 Aug 2024 18:43:40 -0400 X-MC-Unique: nXVIwQrQMjCUDXJcZx9PPQ-1 Received: by mail-yb1-f198.google.com with SMTP id 3f1490d57ef6-e03ab732455so2136387276.1 for ; Fri, 02 Aug 2024 15:43:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722638619; x=1723243419; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kWgeUNWYR4zhRqTU3LJS1HQO1SCauqzxtnFFVDzZSg8=; b=ukbqd3PfE6bkkVuXnlua2rYuPDBAuf4YsqjiVZWP5gXQsCMHytRZW9kNxKianTfqBe WTrYOGfmkkycUhdtk+Thlt4RH2b4gcStbhQ6I7CDKNuCkJUB+6+9wXh7FpADbJ8yC0/B 4Qqp79lhfhzpad1DO+kQ+rTbS6Cod2bK2VGZFVtgczGRNuxF9F8kYeHiX5hlj3kLOrbU Ab0nXlAKEfYpW48y4pleQqg583xno6o+MzdqW77lK5HP46TRIPxtTCixrKulW8nCD1YA NHssBpsrIMKB4B8ZUs5MtJA7xg1C2su1Gr41K/96OlY8v1mn72BAKPJtfdPSLjpnueMP zCmA== X-Gm-Message-State: AOJu0Yy+dClVsmNp0+wgHi6FCV0tXJHt77DlmAPMoVff2xqbXBY8r5JI aDSEP7VkIaZRLaSOC9ISHdiGTRcB4+7XHvs+DsAVEUvFkKNOt8qScqKpBmjdjGV77NbYkFx94qt KLUvB8SFa1mnmh7UC+sN1UATJM+cIUb5yptZtf9DiiZC49Xzt X-Received: by 2002:a25:86c5:0:b0:dff:323d:349d with SMTP id 3f1490d57ef6-e0bdddea5a9mr3315483276.0.1722638619437; Fri, 02 Aug 2024 15:43:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1AyUDUh3wVU2WkxCi0wv9ZHC79ULJiqW9SIWuRQFDWWk8xWZ+YB+mfabn7aU3YWxCJojoWg== X-Received: by 2002:a25:86c5:0:b0:dff:323d:349d with SMTP id 3f1490d57ef6-e0bdddea5a9mr3315469276.0.1722638619034; Fri, 02 Aug 2024 15:43:39 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a34f78b7a5sm123953885a.122.2024.08.02.15.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 15:43:38 -0700 (PDT) Date: Fri, 2 Aug 2024 18:43:35 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Jiang , Rik van Riel , Dave Hansen , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Matthew Wilcox , Rick P Edgecombe , Oscar Salvador , Mel Gorman , Andrew Morton , Borislav Petkov , Christophe Leroy , Huang Ying , "Kirill A . Shutemov" , "Aneesh Kumar K . V" , Dan Williams , Thomas Gleixner , Hugh Dickins , x86@kernel.org, Nicholas Piggin , Vlastimil Babka , Ingo Molnar Subject: Re: [PATCH v3 1/8] mm/dax: Dump start address in fault handler Message-ID: References: <20240715192142.3241557-1-peterx@redhat.com> <20240715192142.3241557-2-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 01381A001B X-Stat-Signature: nmfunkeo5uoqa3zrhexemsihrmkzwye6 X-Rspam-User: X-HE-Tag: 1722638621-205601 X-HE-Meta: U2FsdGVkX1+R7HI6pMTlkAGQyvrNgcNl+MDZMPA53qLMKJpg3fiC/M1HK6MveiUafN5TfMUllW5vIUn3lWpTBeS6pqeN75Y2y/Lx8g38RhureaQ4bVgbKWlfY/CY9wmo7oJfk4JLkEcc60YZbZSA3AVLHe2/0H8Ruy0vXDARNXXdt1zdijrYtwZTHi9A3TfDD9KkIpeypqce5an3p4zCh2jzpIE9mu/7yvNN2qeCQ3JaqrNzi2tzdlo/UD17TCKf92hPK94AH9lgxH6Cjhz7EMxF1OMk+PELOHSfjnT9VWkyafJI6HzxaCT3k1vFfYZb8LQfxwV8ilAbS+hCxNCpVt4cUT+k77oCQjIc0E8y1Px6rHdNRqmMuVyF1RCwB6UFikSBHu/L0YStrExbJJjm73C4mRy34izpOxaKubsYgj5EdYp9zsTTUHBSrFSmyo55/C+UEak858zIwGSPTZl9psSnM/ufX9KQMDKOLCYtaYDC6t3Bd85uVvnktuwvF9EjynZZR4LkGYbs19nuV/HKlWyleKK55OcRZ9JorPgXJeorlbpzMwYQ1dHfGL3cjQ5YWUKQQnI8Nn65gszAxvCnoNYfdQk/7UHf9aEeNVUpo26kSFsyOz+N1iewdGspgOICsCDM9R7yX6RXt7jnHLEGqjBoJgKDFVdlJDip+G7P4RyFITLjwrJkw1HyJ1xB1Ot5hxjmtLbnZbQWdF9pWUMkd8OuOpQmeKiE/TDVJWCamW5Yrm8DWCrCwzj6OCQ5jk9YJF8Rw2NVR1i4ND/IEFA56gD9jSMIrLbrWHSL82//RaQ/iYNPxkmKMxkS7I/La6bCJAmboChUMEEHVq/eDnFm3injWBS5x7p+ux4o9q/oF8P7GoiowAMr50xRhqRZXtRRSfd0r98nnikNX8J+gnHd4deJUptBCoqQHEw2ZRKgMETcg459laAcZ924zfY5GtqtOUxmHJ2HgKnI14aZf1Y 0nqAYJCh dAoLwemB0xam/SCwihC18ZXV5nQ7MRQVGqPPODYoeBFRqwMH41HlaAKgsb1UJ5N+0TUypzcjW2dgEaXzkLid/MQpfNldqYHJ4mDPnwD11gn8IZgzRAinmyigtrdhVpa+pzg4xXJAUNm6nNSK+XNLLRAOk1F6cIO/y9frJf4LXd5Nb2PUN5VWotORFH1/ZtZF8SAUkyuHO1nTqAcySm9tlOP1bi03vTuF+vuHW6c6Yv68iAzPOTT7cD32gtsjr5Pkec4+XEPUHat7v+Sb/hdQsPttj/SWGKc0m0Wz2aivMaZbtlXI1jYun9dEgvbDtmObHkuS1M/sf6uAiOFs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 31, 2024 at 02:04:38PM +0200, David Hildenbrand wrote: > On 15.07.24 21:21, Peter Xu wrote: > > Currently the dax fault handler dumps the vma range when dynamic debugging > > enabled. That's mostly not useful. Dump the (aligned) address instead > > with the order info. > > > > Signed-off-by: Peter Xu > > --- > > drivers/dax/device.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/dax/device.c b/drivers/dax/device.c > > index eb61598247a9..714174844ca5 100644 > > --- a/drivers/dax/device.c > > +++ b/drivers/dax/device.c > > @@ -235,9 +235,9 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, unsigned int order) > > int id; > > struct dev_dax *dev_dax = filp->private_data; > > - dev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) order:%d\n", current->comm, > > - (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", > > - vmf->vma->vm_start, vmf->vma->vm_end, order); > > + dev_dbg(&dev_dax->dev, "%s: op=%s addr=%#lx order=%d\n", current->comm, > > + (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", > > + vmf->address & ~((1UL << (order + PAGE_SHIFT)) - 1), order); > > id = dax_read_lock(); > > if (order == 0) > > Agreed, the address of the fault is better. Just wondering, would the > unmasked address be even better? Using the order we can figure out the > to-be-aligned address. >From my very limited dax experience on monitoring these faults and making sure huge mappings popped up correctly.. it's so far easier when we see address properly aligned with order info. But let me know if you still prefer that, I'm fine with making that calculation simpler. > > Acked-by: David Hildenbrand Thanks for taking a look! -- Peter Xu