From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22ABCC3DA5D for ; Fri, 19 Jul 2024 17:25:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DCB26B008C; Fri, 19 Jul 2024 13:25:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58D636B0092; Fri, 19 Jul 2024 13:25:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4541B6B0093; Fri, 19 Jul 2024 13:25:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 294A56B008C for ; Fri, 19 Jul 2024 13:25:19 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A5482120896 for ; Fri, 19 Jul 2024 17:25:18 +0000 (UTC) X-FDA: 82357178316.10.6D94B9B Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) by imf16.hostedemail.com (Postfix) with ESMTP id 26580180005 for ; Fri, 19 Jul 2024 17:25:15 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HPGxgh4W; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721409895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5pkR6DEf3Lxs0SOZWGvsdocjpD6jlthCnw0cI5XnXA8=; b=VkTpRF0F6bv6ttH4IWah5YhPAT64rMs2km7AEfl3wKTnUNJfEjUhTj8kADFNDoLEkHjSDM 4O5c7mWJk2qHnTcvjexUqJObkj9KgmAKsTWMkU/yRR0fcEPiXT5H4FjW85NoobNy/7z4Rv tIOs7Igd+NWdoFXMyulQEkNMXmC3sa4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HPGxgh4W; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721409895; a=rsa-sha256; cv=none; b=wghjUyEVdwfiRb9b+hSBU8zeSvsv3V9I4bBAFk90xhqFUri30j60pBhIO4GWKkW2ew5kuf IhiAYzx+pIKW+tTsY5REv8wqfvOpfEhGXj5FU/a9MaxXHuJ57cWYM7knssFiRt6nv2k+n/ fcileASjoeQbolStbUUnKYM34k7WYp0= X-Envelope-To: hannes@cmpxchg.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721409914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5pkR6DEf3Lxs0SOZWGvsdocjpD6jlthCnw0cI5XnXA8=; b=HPGxgh4WXhi970lJv9mLD2zgsEXk5Br5M5Qr9SoH6cgR9mEKImc7D2lKOL8uraoncWomzR c139mioxVqtRDBcZPqYznQD/OPMe9WnPzrOlNdfN533MXRmyrz/b91oqqSKg4Lu3RvvZrz 7XM8U+HqDkJdrORbI/OuKNDy7gQmgts= X-Envelope-To: wqu@suse.com X-Envelope-To: linux-btrfs@vger.kernel.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: shakeel.butt@linux.dev X-Envelope-To: muchun.song@linux.dev X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: mhocko@suse.com X-Envelope-To: vbabka@kernel.org Date: Fri, 19 Jul 2024 17:25:09 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Johannes Weiner Cc: Qu Wenruo , linux-btrfs@vger.kernel.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka Subject: Re: [PATCH v7 2/3] btrfs: always uses root memcgroup for filemap_add_folio() Message-ID: References: <6a9ba2c8e70c7b5c4316404612f281a031f847da.1721384771.git.wqu@suse.com> <20240719170206.GA3242034@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240719170206.GA3242034@cmpxchg.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 26580180005 X-Stat-Signature: hnoxyrpiwt9s3nf4ntsjdyex563ty8x3 X-HE-Tag: 1721409915-607118 X-HE-Meta: U2FsdGVkX18DafIsLj0Ts6gvyJ79ojBqzlzmiaJsaruYjpaliH19I+78hnnFKe5cw3zJ3eI7IOzx4W/O3V90UDoDUgcozYCoobizMI1BmO/EcMn/BmusizHxwXupy97J8HvxswilkIxzzIlAMC17sBbGVQ1cPZJjzxsoP0cHRWbFLcSabXk1vLl6Sa7ft1ndr+Gqu8LwRXbZHuZdf6UubR+o/ym4gtIvxWWquSEb4Frkvobnk8jGX++bt4LBymJgPMP4rbwOFCuM7HghbbbYWTlZacjrRn0mvGaMchbKuig40Z/dhs71UHnp9ftj2NcBLQoExdmBbx50dEP1bkZnUGiISJu/1b2XnQluaJ5/dZC8xjci6N/dIYSl/dSiTTgru0KGoOZXIMKhxQOCGp3qHT0EprUcDWH8ZJ8mp3svrbmJterYx2eq48qv7TKao26MFv+DzogOYmpBXTsD/B/xkF7GfgrWsWoQ2bznNYnls8AB9WDGIJTS3jNp19RFLfsQSya26omtKtVZt92/fWQoj5z9EF3QZymDz17bcM+2CbboBywAZyy+EH8cyaUppT4JQmHKZtJhnW3E1A41PubCFmHUBooXEdfZ9S+y1NPxvlO52tI4BS0pDdoVmGn7oW9xewzeQ392QlKGJkWGSFsrj2jUwwOGkd0JF7NOSVJ8n/m8fBY3zpfZUvhRl6sBM1/r3YH0LqJkZUCsX+lhrBQP8Xj5eQbA/2Kx4EIrM/W6sZv5yYfHHq90l3tJ4xHxOIKVFAplOJRcJ0GPofTOT+4SS6Z/FOS9iZhM7Phlu7K3T0vhzSW/67serBUAOJy5kGCTq2KejeJNThLobe8SYoVZBxLhHBWRWCZzWIdjAjEwP9SNEIbtuVUT0t4PPnc/fdgMfzsR16LN18RWi2vuDjvRNB8uT87kEIcYnwBZ8dbOsjQIPaeJirFizvWlBUeNG47ijIHnGsZkyvNVFSoVPH6 Ca4CjCCL mBirjpA3kTHmdvDuo/1hYT1Q5eeBhvUgbi/ncHC3W6SIbpxxJ7boVe3+TwlzVuuR/P7e0/R7QAXGNrH1SR+VrnvVuAJ2aL/ycJU6TDoBTYmPWxGdPBdeZY8eXt7xk4sBHHK4Q8DNUubMuHjGXElyFAGcKxBZfuQ7gnlSe7SixbQ4id4NVZ66vMbmGLJ5SmO0LfiBWJ9sPzJ5L9bTIoTdsJpTCMfrBBpNRCKrK/vALUA/aSmtJJJ2XHnnBcxIrU7xPgvGcc6gsZqNBqUi6xIp0q7hjuxeTSqhurcQqtOaRAcSe79Mw0syj1pP01CcCw5uJlXswjkwmOghc6F8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 01:02:06PM -0400, Johannes Weiner wrote: > On Fri, Jul 19, 2024 at 07:58:40PM +0930, Qu Wenruo wrote: > > [BACKGROUND] > > The function filemap_add_folio() charges the memory cgroup, > > as we assume all page caches are accessible by user space progresses > > thus needs the cgroup accounting. > > > > However btrfs is a special case, it has a very large metadata thanks to > > its support of data csum (by default it's 4 bytes per 4K data, and can > > be as large as 32 bytes per 4K data). > > This means btrfs has to go page cache for its metadata pages, to take > > advantage of both cache and reclaim ability of filemap. > > > > This has a tiny problem, that all btrfs metadata pages have to go through > > the memcgroup charge, even all those metadata pages are not > > accessible by the user space, and doing the charging can introduce some > > latency if there is a memory limits set. > > > > Btrfs currently uses __GFP_NOFAIL flag as a workaround for this cgroup > > charge situation so that metadata pages won't really be limited by > > memcgroup. > > > > [ENHANCEMENT] > > Instead of relying on __GFP_NOFAIL to avoid charge failure, use root > > memory cgroup to attach metadata pages. > > > > With root memory cgroup, we directly skip the charging part, and only > > rely on __GFP_NOFAIL for the real memory allocation part. > > > > Suggested-by: Michal Hocko > > Suggested-by: Vlastimil Babka (SUSE) > > Signed-off-by: Qu Wenruo > > --- > > fs/btrfs/extent_io.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > > index aa7f8148cd0d..cfeed7673009 100644 > > --- a/fs/btrfs/extent_io.c > > +++ b/fs/btrfs/extent_io.c > > @@ -2971,6 +2971,7 @@ static int attach_eb_folio_to_filemap(struct extent_buffer *eb, int i, > > > > struct btrfs_fs_info *fs_info = eb->fs_info; > > struct address_space *mapping = fs_info->btree_inode->i_mapping; > > + struct mem_cgroup *old_memcg; > > const unsigned long index = eb->start >> PAGE_SHIFT; > > struct folio *existing_folio = NULL; > > int ret; > > @@ -2981,8 +2982,17 @@ static int attach_eb_folio_to_filemap(struct extent_buffer *eb, int i, > > ASSERT(eb->folios[i]); > > > > retry: > > + /* > > + * Btree inode is a btrfs internal inode, and not exposed to any > > + * user. > > + * Furthermore we do not want any cgroup limits on this inode. > > + * So we always use root_mem_cgroup as our active memcg when attaching > > + * the folios. > > + */ > > + old_memcg = set_active_memcg(root_mem_cgroup); > > ret = filemap_add_folio(mapping, eb->folios[i], index + i, > > GFP_NOFS | __GFP_NOFAIL); > > + set_active_memcg(old_memcg); > > It looks correct. But it's going through all dance to set up > current->active_memcg, then have the charge path look that up, > css_get(), call try_charge() only to bail immediately, css_put(), then > update current->active_memcg again. All those branches are necessary > when we want to charge to a "real" other cgroup. But in this case, we > always know we're not charging, so it seems uncalled for. > > Wouldn't it be a lot simpler (and cheaper) to have a > filemap_add_folio_nocharge()? Time to restore GFP_NOACCOUNT? I think it might be useful for allocating objects which are shared across the entire system and/or unlikely will go away under the memory pressure.