From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293CCC3DA5D for ; Fri, 19 Jul 2024 11:58:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F1136B0088; Fri, 19 Jul 2024 07:58:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 354306B0089; Fri, 19 Jul 2024 07:58:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CD746B008C; Fri, 19 Jul 2024 07:58:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F01446B0088 for ; Fri, 19 Jul 2024 07:58:44 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9FBC8A064F for ; Fri, 19 Jul 2024 11:58:44 +0000 (UTC) X-FDA: 82356355368.02.7E9234F Received: from greygoose-centos7.csh.rit.edu (greygoose-centos7.csh.rit.edu [129.21.49.170]) by imf19.hostedemail.com (Postfix) with ESMTP id D12E21A001C for ; Fri, 19 Jul 2024 11:58:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=rit.edu (policy=quarantine); spf=none (imf19.hostedemail.com: domain of mstrodl@freedom.csh.rit.edu has no SPF policy when checking 129.21.49.170) smtp.mailfrom=mstrodl@freedom.csh.rit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721390282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RUkNIXP4ZZZQU7AmZzUNOsWOiYcu3bUy4EzOO8kC/7I=; b=NSjrqITcxHqB996cRvk4FzWNzemEvBc6Uv5IMnzcOeuFz303eaOQPlgTqpBZ2+gx9Zmafq 5UReO19ttnik+z78kGaMpcfixCEFoEmnTO7xoVJjARW2amEkPLIO4Nqffth+46mR2jISDg 6jKstL4d3gv5KLyLlW/XgxaWrztpHG4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721390282; a=rsa-sha256; cv=none; b=TwPjeVWiGaGydAJ70R4oVddlES81PduXpAjtiU8CSviNOhLDQFJkATksN7iN/Rh988U6TX 2Urygljll5JD4F0+cwLZX1wWshC2GggegAzT6sxTiqmpFmLlDgOyN0w61KE6E8Ez8f3fx2 ptzpzRvBAIiNRm6ZMnNEQS/Pbdn17Ok= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=rit.edu (policy=quarantine); spf=none (imf19.hostedemail.com: domain of mstrodl@freedom.csh.rit.edu has no SPF policy when checking 129.21.49.170) smtp.mailfrom=mstrodl@freedom.csh.rit.edu Received: from localhost (localhost [127.0.0.1]) by greygoose-centos7.csh.rit.edu (Postfix) with ESMTP id A2F9C40D7C9C; Fri, 19 Jul 2024 07:58:41 -0400 (EDT) X-Virus-Scanned: amavisd-new at csh.rit.edu Received: from greygoose-centos7.csh.rit.edu ([127.0.0.1]) by localhost (mail.csh.rit.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id c5mWgwAwWkWi; Fri, 19 Jul 2024 07:58:41 -0400 (EDT) Received: from freedom.csh.rit.edu (freedom.csh.rit.edu [129.21.49.182]) by greygoose-centos7.csh.rit.edu (Postfix) with ESMTPS id 3A44045735E9; Fri, 19 Jul 2024 07:58:41 -0400 (EDT) Date: Fri, 19 Jul 2024 07:58:40 -0400 From: Mary Strodl To: Christian Gmeiner Cc: Andrew Morton , Matthew Wilcox , Christoph Hellwig , Mary Strodl , linux-kernel@vger.kernel.org, urezki@gmail.com, linux-mm@kvack.org, lee@kernel.org, andi.shyti@kernel.org, linux-i2c@vger.kernel.org, s.hauer@pengutronix.de Subject: Re: [PATCH 1/3] mm: vmalloc: export __vmalloc_node_range Message-ID: References: <20240718143103.82e33c556b2d1b6145ae43e0@linux-foundation.org> <20240718143924.43e22f68cf639b064a83f118@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: m36td3xm7a1m64fss1sxaq97kso76bjo X-Rspamd-Queue-Id: D12E21A001C X-Rspamd-Server: rspam09 X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam: Yes X-HE-Tag: 1721390322-785612 X-HE-Meta: U2FsdGVkX1/TdN9XqxMY0DDY+mmzmdH7JxZ95856nddtNJj4FWPeI4HJGkyZkK10qYZVz0EOfc2V6TelSNQZpFm/3rJ0+L3bnduiWcK8ehkV5qmHvodkXbEZxE+wzAuv9VdMus9pBj6KNANbNYvhdVKIGPxFtPLUZcq7xG3jkjAwpnEcykFVSDqEEQqhusPuHwPnrs14O9x3t/Sjh7kZcdddiYhrhBM7ayuwwo3CiyTVa37xf2isgh8IMQsbWHVQgIZhZop9VfNU3i3zES3zZ+FzdgMYv8gPuKU+lkiwdhQXPoFsJDwb5o9V5P+B3IpU0TlRddTnja3h4qy3hkSxPE4ZHy4LBNzps3z2NI2ki55sv168UE+jN9OJdvQ6Fx4qH3IT2SE7tHUA9TvYuBnlQszoyFmWXNr0YiPlNesgqC+7RULqf9nokw0/wnTc3J1RDT16jibPYtnbDZCfntn1zmNNcH3atxV2Fh/Ko35nrKEpXF+W8qbzLg79TYMrMpFI8GpyPCWY6+h02purALoqw1kKg6lusITztS6j9nl9tSYP1Pr5hS9wSDOIbTouSpwIJVLdG9No8RlUNExrqcdzaGv5DMepqe5Oz1A89FCqvRYBnkbnyw4+cSbUKmByUVX7KFS6OsiGPYoO22JGjCSExF6Z8jR4PmGX2XTaPhnN1QPP+53iqOUESKEjjh8Ry9iJ6IICKwk/KHZDb4ZMJV7WIEEwOfjA9iMI6BZmIm8VYyGySHkCv2n0Dn+ERVMYvZmSWkhaYm78FJrvs2ic+PPhHJgXlYNkbbycknp3qSP6z0a7CNZ5wx77ssiJiMEWpsMGuGCkmpQ3dPuwj8dKk8ZfS/XPU9Shb4P9+r+9R9CrlTj1949iIhqbQi7zyiN720r/f4g7GLbO4UKP9XW+APiJOjA67p3MnPCTP9lgSzDqF+uz+xwSj2Su4V21Z/DpOz++mkdxz9bdgVllD0pBLU5 5kd5x5qB NQyg1RJ0sJMs7+tYEo2aibqSb3HHn2PsuKcYxtWQ/3eLwQ0e8x9s2JKDSFmplYEUJpval59jvCZKir/b/cJa30ae+/Jyyfdao7rixYcfXkERWxVFUDWLiEd3gj1nnQZQJKWmzHzMnCTC2A6dYFWC5evQKCWK/dntASAFvp3RpNfIlNsIPT4x4o2o0EYZTiLxDhGIIDOGmFxrBR+mn1y0W2UvjIPZU8xicaPUh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 08:41:04AM +0200, Christian Gmeiner wrote: > This wonderful interface is used in recent products from them too. > Adding support for it > in an upstream-able way could be still a benefit, as these products > are used in different > industrial environments running on Linux. Just seconding this. The hardware we have here (conga-TCA7) was released in 2021. As far as I know, congatec have been using this interface for a while and provided a pretty bad out-of-tree driver for it that needed a proprietary library in userspace to talk to devices instead of actually registering with the kernel facilities for i2c, watchdog, backlight, etc. I think it's valuable functionality to support, but it'll need to happen safely. Maybe some of the stuff the driver does right now could be moved into vmalloc? In other words, we could provide a different function that allocates an executable page, copies memory into it, then marks it read-only. Would that do better to alleviate concerns? Not sure what the restrictions on x86 are, but we could also start with a writable page, then mark it executable when we un-mark it writable. I think this is good discussion, thanks for sharing your thoughts everybody.