linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mary Strodl <mstrodl@freedom.csh.rit.edu>
To: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	Christoph Hellwig <hch@infradead.org>,
	Mary Strodl <mstrodl@csh.rit.edu>,
	linux-kernel@vger.kernel.org, urezki@gmail.com,
	linux-mm@kvack.org, lee@kernel.org, andi.shyti@kernel.org,
	linux-i2c@vger.kernel.org, s.hauer@pengutronix.de
Subject: Re: [PATCH 1/3] mm: vmalloc: export __vmalloc_node_range
Date: Fri, 19 Jul 2024 07:58:40 -0400	[thread overview]
Message-ID: <ZppU8FhsFd9cB-Fi@freedom.csh.rit.edu> (raw)
In-Reply-To: <CAH9NwWf_S-PyY5X_cJGSW-8YDk4-C0VvnPCX8iVuo0FhTqsy2Q@mail.gmail.com>

On Fri, Jul 19, 2024 at 08:41:04AM +0200, Christian Gmeiner wrote:
> This wonderful interface is used in recent products from them too.
> Adding support for it
> in an upstream-able way could be still a benefit, as these products
> are used in different
> industrial environments running on Linux.

Just seconding this. The hardware we have here (conga-TCA7) was
released in 2021. As far as I know, congatec have been using this
interface for a while and provided a pretty bad out-of-tree driver
for it that needed a proprietary library in userspace to talk to
devices instead of actually registering with the kernel facilities
for i2c, watchdog, backlight, etc.

I think it's valuable functionality to support, but it'll need to
happen safely.

Maybe some of the stuff the driver does right now could be moved into
vmalloc? In other words, we could provide a different function that
allocates an executable page, copies memory into it, then marks it
read-only. Would that do better to alleviate concerns?

Not sure what the restrictions on x86 are, but we could also start
with a writable page, then mark it executable when we un-mark it
writable.

I think this is good discussion, thanks for sharing your thoughts
everybody.


  reply	other threads:[~2024-07-19 11:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18  1:15 [PATCH 0/3] Add support for Congatec CGEB BIOS interface Mary Strodl
2024-07-18  1:15 ` [PATCH 1/3] mm: vmalloc: export __vmalloc_node_range Mary Strodl
2024-07-18  2:53   ` Andrew Morton
2024-07-18 12:29     ` Mary Strodl
2024-07-18  3:04   ` Christoph Hellwig
2024-07-18 12:40     ` Mary Strodl
2024-07-18 12:45       ` Matthew Wilcox
2024-07-18 12:49         ` Christoph Hellwig
2024-07-18 12:53           ` Matthew Wilcox
2024-07-18 13:20             ` Mary Strodl
2024-07-18 21:31               ` Andrew Morton
2024-07-18 21:35                 ` Matthew Wilcox
2024-07-18 21:39                   ` Andrew Morton
2024-07-19  6:41                     ` Christian Gmeiner
2024-07-19 11:58                       ` Mary Strodl [this message]
2024-07-19 12:42                         ` Matthew Wilcox
2024-07-24  0:00                           ` Andrew Morton
2024-07-24  0:16                             ` Matthew Wilcox
2024-07-24  1:36                               ` Christoph Hellwig
2024-07-19 19:59                         ` Rudolf Marek
2024-07-22 14:54                           ` Mary Strodl
2024-07-18  1:15 ` [PATCH 2/3] x86: Add basic support for the Congatec CGEB BIOS interface Mary Strodl
2024-07-18  3:56   ` kernel test robot
2024-07-18 14:01   ` kernel test robot
2024-07-18  1:15 ` [PATCH 3/3] i2c: Add Congatec CGEB I2C driver Mary Strodl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZppU8FhsFd9cB-Fi@freedom.csh.rit.edu \
    --to=mstrodl@freedom.csh.rit.edu \
    --cc=akpm@linux-foundation.org \
    --cc=andi.shyti@kernel.org \
    --cc=christian.gmeiner@gmail.com \
    --cc=hch@infradead.org \
    --cc=lee@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mstrodl@csh.rit.edu \
    --cc=s.hauer@pengutronix.de \
    --cc=urezki@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox