From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B022C3DA5D for ; Fri, 19 Jul 2024 14:13:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB3286B0082; Fri, 19 Jul 2024 10:13:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B63996B0083; Fri, 19 Jul 2024 10:13:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2AC46B0088; Fri, 19 Jul 2024 10:13:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 853196B0082 for ; Fri, 19 Jul 2024 10:13:41 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1544F40735 for ; Fri, 19 Jul 2024 14:13:41 +0000 (UTC) X-FDA: 82356695442.07.79DB247 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id D98B91C0021 for ; Fri, 19 Jul 2024 14:13:38 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YdHkaoHH; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721398397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c1FfwdGjf16WY/zV4TrA4eif3sm5aZVbLqK1u6/4CsU=; b=GF5CPt6lIYVwsL8glTHiqSdm0+2jIntgfyZLZyM8wD3pc9yFw0GPpQci4+MA8x45brzMG+ Can/wEQWs/PnWXx7yKcCNz7zISed5LyxK1nuF3qvKLiw22HzFIIRd58kBb82lC+q/tKxY4 Oc3dS8sa4s791k+DJ2CaSWPyr6Ze1DE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YdHkaoHH; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721398397; a=rsa-sha256; cv=none; b=eusvfgG0DXZUFw23RQUPCTwB7VMgWvngUh0ByhIkxwKfy2QHgofXGJSOwbhqHvhq4Xke0V GgZnAA5tpVZODef8HiDoWSllsXoEAL9UtuRoIwFA9NJZZqLDVmHw4zSF+lu1ic799/6qNd XRZpNnxkuX6ESetad71hKKY2LmXX1CI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721398418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c1FfwdGjf16WY/zV4TrA4eif3sm5aZVbLqK1u6/4CsU=; b=YdHkaoHHhM1PyliDf2Uh6r5nZwc87ZR8veDfRn6crHoan9PeA6XQFOadKGpda2dL/YhG4Q IuKZa4CXEUUzoTiR15EiBu2mW7hoUCtx8BgdrDP+kN4atMhN4kJWv6fxP0+MqmsPVQUSIv WkNwhyKR9sYyManYTjPBGAia1SQly20= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-LLjGa_G5NimOcQqH2A9ubw-1; Fri, 19 Jul 2024 10:13:36 -0400 X-MC-Unique: LLjGa_G5NimOcQqH2A9ubw-1 Received: by mail-yb1-f200.google.com with SMTP id 3f1490d57ef6-e05e9ffd2e4so453256276.2 for ; Fri, 19 Jul 2024 07:13:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721398416; x=1722003216; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c1FfwdGjf16WY/zV4TrA4eif3sm5aZVbLqK1u6/4CsU=; b=GohPJXk7Lu4zxz5kArRd0tIwrtqJ2t6SieBBKCstL376/e30Pl2dl1NFp2e8zVkJqQ UJXfJXUH2hVDRKvq0Uk+OSUA+SEg2hL9DQANFtvXpu1rJMO4f5d+vEyCjc9NGenmpMUL oCaO7vt0L2/9+gmIICY2Ol5sdmQWklcxaP1pBv53IPOCv16LOiA5Nw4zmSJthMjWnZIV yzVQPk3/QsVQY/6FzCpbfBs4L6hZRnG0lglgiM8pWpK3AukE6ZtvmiA7farxkAJ4rByv QQzZdpNZfh0C357z9eoFUwH1tqtOgs8JZTnJX7cymqPx/TBqqIoxw8sImp3snBxcYmgf 4WLw== X-Forwarded-Encrypted: i=1; AJvYcCWCNcA1S+NeTTwYV7n2zN21T0U8JQuQ8DeGRG6iY1RhLpByckVZaC8nkDVjrknAGU1Z0tsfIFuhvwm0UmV31oCp4tM= X-Gm-Message-State: AOJu0YxSc7say8BxwST5qLOXnxE/x856Yw5JLzh48bFMX0EyTaR2D3XM 3WqKTj4XTQkzpla/54i4fYd0WLD4wgWUEgOfUzLAbEik0ocYiqJJcuPVgfdH9cGYc2kGCiS4QPv jsy6/VZTVNvQeG1KpAl4OtqDDtnjuqLNOtoJW68dE5CC37wRL X-Received: by 2002:a05:6902:2488:b0:e05:900d:fd0 with SMTP id 3f1490d57ef6-e085eb77f95mr1256624276.7.1721398416257; Fri, 19 Jul 2024 07:13:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqRQqZhbEi7fVfXy/c4++jqj17huWfx4L8tNoYGCaGB3uCWrspRd8fVFYNS1OuD4m6+W7Trg== X-Received: by 2002:a05:6902:2488:b0:e05:900d:fd0 with SMTP id 3f1490d57ef6-e085eb77f95mr1256603276.7.1721398415823; Fri, 19 Jul 2024 07:13:35 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-44f9cdc3004sm7393421cf.80.2024.07.19.07.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jul 2024 07:13:35 -0700 (PDT) Date: Fri, 19 Jul 2024 10:13:33 -0400 From: Peter Xu To: David Hildenbrand Cc: Yan Zhao , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Alex Williamson , Jason Gunthorpe , Al Viro , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "Kirill A . Shutemov" , "x86@kernel.org" , "Tian, Kevin" , Pei Li , David Wang <00107082@163.com>, Bert Karwatzki , Sergey Senozhatsky Subject: Re: [PATCH] mm/x86/pat: Only untrack the pfn range if unmap region Message-ID: References: <1a0884cb-39ed-455e-a505-7c1b2a0e5225@redhat.com> MIME-Version: 1.0 In-Reply-To: <1a0884cb-39ed-455e-a505-7c1b2a0e5225@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D98B91C0021 X-Stat-Signature: 6fotut5o8nirrqnczk9hnt8t7adhjtp8 X-Rspam-User: X-HE-Tag: 1721398418-377427 X-HE-Meta: U2FsdGVkX18aoURvDnhwP7d3kpRJ6zlVETK177TZmyMensSbOojxqGyhWQn4CjfKZbF6x6QXdxSUG9lTYO6Jpr3WM2lRRLanbGzhrB9W3xV+6E6ezQbHdwUDTqX6ijr3XZVEp/iiMBj7V/GTVa1fhr8pIgUQli2mFlGWNRjpPz8ub8quAi/OREBNJ+hR8RjJQJ1AcoksTHdytAqegTskO2/O2ajPD1MmRLO78V7KlmF4jk7BPPlpx/pelJ67jEEdNlfy9Wszjhzc5+ZgxIu4kcY8IMHOwSAmtht9qBvwbeHKlrqCaq8LJT8Xih+QyFNOh8v7/9cuYvLR1a9siexGwr/35mjlE1QkBr5AwbiQUi52dohWhT1SrtrP/qxRXNL4M93r/jUnoc/wvxpRc3TkMNtEwPSfhw9o4yLbKkyfZpCEm5PtgWN+SbuXzAcUni5yj5CEkH6kHkUNVZ8QY+W5G7lxPINU5djNmPvta9+/d9cfxhXTJpFknRy2/Hxp/Mz6qCSco0bNGZ5qaePQBPslHu8ag2IR1X6dcqf7y2EU9tWY5B/reHnAE0w9kerSlGnJ1d0hHfuEoOEsf8RLmpLl/FFAF9bvUo4oP208mX5FQbcp/z3eKDM/sAiyoZQxKZuCKabrasESVrJ1SIOXgAK/LcdC2RA/TqTJERPqO0Il1mD8tstZYXTbsI2xAhbEu7X9r/T+SfN99NPQDAaWhyJyj/GVzaZ7g3sEXNayrjKskVDns0ppxamC+EMyCXWzfRoQX35L03dFnV2nhnpEX2k26Iy+84kklSJZDnFjWaPiBh0thVK8CatryQEawnNG+YktWcM1xvNUO7C4L8aGawFCJ9slCkjKL7+moxkHBsnJHXnUcmLo5QqBRCR49eb8Ap8w/l+vkNL5d2QsxhnN46eTpYYUobKDOiwJw1ByRz+ISH9Eb3HQ3xwc3D+Tn9GDyHBCsNw1pPbIxIMUsu/C3Oe zJOCgWYY uD3fsSvh5enlLZDMzUyYEfMZfAw5r+9lRapOgJignNddMyqr+pC0nvSuEAzILLPrY+/6SQzarO2ZIohVXCQjIOjfErwzAc+9DNzwutEuv1Kj03wkGrbYrixUTUYcD7OdQJbwhGvL4svTig+fkZDcWxjSKM1HquAHwD/K3TYUm3cZxUzECJzKil6VzbWpcapIFNa5GszzMHbrwukF/d+YU20lfgJCoAjT/aOXRaWi8AcAJ2a29+qT0vwXXDrHcgaXRGRwA11XlYWCVTfjSWh+X4IDkSK7ruBZ0Yu5sW8UCugCdp2YtEsNJTw6ikkjzyEDLvVLwdiWidxB8ZZf8V11AJwUVFCO3CdGXENSzxOxocSXK36biDdM66bXop4m/tmvItnHk7cQFTDaz5FfJMZ142JCogfm5JtA7QwgYiPznumq4kQuXDMX4rP5LJC13RH3MNaV3S4pFdzNhRZg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 10:28:09AM +0200, David Hildenbrand wrote: > On 19.07.24 01:18, Yan Zhao wrote: > > On Thu, Jul 18, 2024 at 10:03:01AM -0400, Peter Xu wrote: > > > On Thu, Jul 18, 2024 at 09:50:31AM +0800, Yan Zhao wrote: > > > > Ok. Then if we have two sets of pfns, then we can > > > > 1. Call remap_pfn_range() in mmap() for pfn set 1. > > > > > > I don't think this will work.. At least from the current implementation, > > > remap_pfn_range() will only reserve the memtype if the range covers the > > > whole vma. > > Hmm, by referring to pfn set 1 and pfn set 2, I mean that they're both > > covering the entire vma, but at different times. > > > > To make it more accurately: > > > > Consider this hypothetical scenario (not the same as what's implemented in > > vfio-pci, but seems plausible): > > > > Suppose we have a vma covering only one page, then > > (1) Initially, the vma is mapped to pfn1, with remap_pfn_range(). > > (2) Subsequently, unmap_single_vma() is invoked to unmap the entire VMA. > > (3) The driver then maps the entire vma to pfn2 in fault handler > > > > Given this context, my questions are: > > 1. How can we reserve the memory type for pfn2? Should we call > > track_pfn_remap() in mmap() in advance? > > 2. How do we untrack the memory type for pfn1 and pfn2, considering they > > belong to the same VMA but mutual exclusively and not concurrently? > > Do we really have to support such changing PFNs in a VMA? Are there existing > use cases that would rely on that? I share the same question with David. I don't think we support that, and I don't know whether we should, either. Such flexibility already will break with current PAT design. See: untrack_pfn: if (!paddr && !size) { if (get_pat_info(vma, &paddr, NULL)) return; size = vma->vm_end - vma->vm_start; } free_pfn_range(paddr, size); <---- assumes PFNs to be continuous So untrack_pfn() already assumed the pfn being continuous. I think it means pfns cannot be randomly faulted in, but determined when mmap(). Thanks, -- Peter Xu