From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3998C3DA5D for ; Fri, 19 Jul 2024 07:53:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5ADD76B0082; Fri, 19 Jul 2024 03:53:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55DD26B0089; Fri, 19 Jul 2024 03:53:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 427276B0092; Fri, 19 Jul 2024 03:53:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 236F36B0082 for ; Fri, 19 Jul 2024 03:53:52 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C8FB51603C5 for ; Fri, 19 Jul 2024 07:53:51 +0000 (UTC) X-FDA: 82355738262.05.26F0244 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id 104F640009 for ; Fri, 19 Jul 2024 07:53:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uoSyD7b0; spf=none (imf07.hostedemail.com: domain of BATV+49c0b86eadc47be72e61+7635+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+49c0b86eadc47be72e61+7635+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721375589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zjb/NC2mmfv35h68iR0K0+yC5mgO/9mZxEw5GutsJSo=; b=2EH2TTjD1m8S+KNNbc04k7R1XRY9dqP/YiyW4HcpJJmPZRUGbwSm9wkxcNJ60VhmHJ8PnI bFNaavLkecIjBOKvB4S51oGAaZlTqx21B+WYaO7LVDyNqt8Dp/6z142mF0ggvCtV/ZAvYO BevdCCqbnnXQMv0a+1jx5sWvobcWJ3A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721375589; a=rsa-sha256; cv=none; b=om7tyC0MUCZE3WbyMMcokO791Qn/9odT9DSj3s0/MzF9cyr6TAPlGUju7A/uWA14plkLIS XNzVvNLtSwJ8ymwsZxbwV7JehtnSq7RGVPl9GqCTTSuE4V13wnaFPbh9H2USl33lX7ouyR Wv1HnxqjX0t6qXJe0l0LHc4z9HVX67w= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uoSyD7b0; spf=none (imf07.hostedemail.com: domain of BATV+49c0b86eadc47be72e61+7635+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+49c0b86eadc47be72e61+7635+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zjb/NC2mmfv35h68iR0K0+yC5mgO/9mZxEw5GutsJSo=; b=uoSyD7b0vh+5bO6n3QQvQn4PA+ U0lNx2fbIWkvD0XnXM0Z7uVOn2T0loTzIU4BFA3NPKNUjzpF52zXb1d1aB2NJQrmVbBzgg+bTHgiZ nu+EqXBVirXoHvVidtX8TWJh9pwJs/5Mo7bdRxfCJXDYqPVp32qNDBSB9JQdBBV5mJz7bhyZdwsBT ksgWjJJ/E8DjhS7e6Nh5thu7gkTRLpGrpOwAp5iCx1m712PC6YiLH7Sx98uoV7PZ83M4sWJRbV7SG FAKH0yhgwHB9EuQgBEe0GbrXTR+H/MOFHAjKpLRUD7YymhPD17G4H5NBI2VePt/1PMzW1xYJDSuI9 CphGKqMA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUiQw-00000001y4U-4Bwz; Fri, 19 Jul 2024 07:53:43 +0000 Date: Fri, 19 Jul 2024 00:53:42 -0700 From: Christoph Hellwig To: Barry Song <21cnbao@gmail.com> Cc: Christoph Hellwig , Michal Hocko , akpm@linux-foundation.org, linux-mm@kvack.org, Barry Song , Uladzislau Rezki , Lorenzo Stoakes , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 104F640009 X-Stat-Signature: 5qxpnb6ztbdx9fk4eqgxzgtqhuk1sbjx X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721375629-236456 X-HE-Meta: U2FsdGVkX18T+4CABCfMNy7wTIqAyOFr5oCqdRNoVHPY+9McFdzrBbmtyiyQdsCkc8eNBKFseErkGrY4FJHm5mn8eiyjx+xKrE3+YZwGDgelndDAIUfZ1j1cgTu0gBMXc5acomRxmFeOq6G5eJtObBRnPwNms+8r8RgPk7loFRQ1Jl0R8AJ6xwdvqEoXS/o2PXc4jrJZHYw9GXeEhN4JMZySDo9Ph0wnfuT0Ldp9nDNEqsNZ/6ttXQVzw3hnp3L5p8FV8kp2jQvSP3jQwh3HVRbQPnwMEOl7GV10jrn8gPltUItZ4+N2GQuizaay7ic91u97EEGkLcJacRkutTuDQKG9FWAgwIBwk3N6o0Bf2CjvV/3Gtc3aNc0EnFWxUh4E/frVj/aONB5zsNGOs0FsUdOGp/SKP9qIzQ8vseKUigiw+hVGL4IBQr9AYI0KBLNe6xKx9KDY4bEVWTOAIV4iS1p8rjAvcfAgnw++lxINb2mOJSjJEj4uw94B+Ln64oy49Id+PBDil1y3l1vU+S9Yaor+IzNNqpn0qoAzB36SDjHVqm5of6O4Zp6kxBRpgK8nkLNj1cBn18XEfaEwyaj68UKhTWGxTaZr+WgnFCZyNvLfO8zkHi5YqRe9EX409F+WTm72DqrXMWzVs0isK0dX2GidFOGYvtMjh/PUY3wCXgE3GjJkXzhC/bQpu6ZJG5IfvfDsiQscfnqEcFTnn0UyxL+/LnZ8Ulh+Lt/0IQXfnyyt4rQ93N3Kg4Cis4WBlFMnYCr/PM9rEfEtrg4r9ZVMgzHbvArsw8SdMYO4hTodk+paBXck6wBlkXYVh1vk6txc1LnTaHd5xQuLduO4i2f9yXmI9JuOAYq+w2hr0UIX4vVh+29F6l+XdNSwxSiUa15u3E2FguNs/U8rN1yq4/FZWt2xBC+BRS0+rbqy2Uw9+M4MyxXHqUKAFSB6vL8wLxp334OJp+83JrdTy3ZkSHC xK12MBnJ JSD0UDBN0b/i/nYWlD6F1Lb//rK0HtyO5PcwbFnSEQK3U5utNCRa57O+ofU/y0/3lOR2WykqPZxPovCK4mKzV7d7wdFuUAgGTN4SZDDQmRqXBz1r0bdcC0bo3Es8XbRpX0I1SoihLNDS2Le8kWlZr0+htzFomBLkVIfUFFztM269x+Rm2dFWTr5ijyDDJMECQWcC/t6XXtI4iVWLdvhOuudaQPyXPyiNCJDFYJoIKty6wSpuuFF15574TTS79TiRgA2lmIF1Fmtyw91FNlvBQ1yNRA/D69CNvfQDjA27EWSAK9q6EGiD16ClyPxi3npddaE1qbb1ysdS+KvVJ6MYDMyzhvO1y9uEGYcr3fj+WAon1lp76+ynhJqUikyVG5SPeLb82KBiVKQ/lDN1jI22THl3LVqDdXBtoi1R5gRoI/GS7p/2KgWP2HLo+2jcrn6SJKqwxfrGCW1FFH4B4U6g/KVMcND1ShrVvtLnv6UU/fOrjCecZcw6mNNDO0Lkt/Bjubc8IPhg2qC0YOeVniyoFfXNC6sstjwF4YtKqHvqae8BCRalKATIp3xwxUqhEDvmZ+iCi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 07:43:38PM +1200, Barry Song wrote: > I doubt this is going to work as users can use a variant to save gfp_flags. > On the other hand, isn't it necessarily a bug of vdpa, why can't it be mm? > > if mm disallows GFP_NOFAIL, there must be a doc to say that; if it allows, > we should never return NULL. Yeah. Maybe the right answer is to have separate _nofail variants that don't take any flags and make GFP_NOFAIL an entirely mm-private internal flags that is rejected by all external interfaces. That should also really help with auditing the users.