From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1916C3DA59 for ; Fri, 19 Jul 2024 07:37:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2CD86B0082; Fri, 19 Jul 2024 03:37:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDCAB6B0083; Fri, 19 Jul 2024 03:37:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7EB76B0088; Fri, 19 Jul 2024 03:37:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A51A06B0082 for ; Fri, 19 Jul 2024 03:37:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 14DF01204B8 for ; Fri, 19 Jul 2024 07:37:49 +0000 (UTC) X-FDA: 82355697858.19.EC69773 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id 0062E40005 for ; Fri, 19 Jul 2024 07:37:43 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1yVuJ7uU; spf=none (imf07.hostedemail.com: domain of BATV+49c0b86eadc47be72e61+7635+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+49c0b86eadc47be72e61+7635+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721374646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MLYCYuCYloh5BTxZlLhpoPZZujbRYtJ1MM4522b7GoU=; b=K+A/sxtNlQGPy6YCQUB2hnXgUieV/xkjfyD6dfQ5YeOKeogloTz8uCRKMeRrkUy0hnVuh6 WvAzWQzvrf3kxM5yVaFLfI8mIWbNZDFr9T/9lo/4Zj6eu14isUcbELsZlZcF9JSUQtFJ4h UlvZPFUadB4IdlXqmmtoA4dJgELvFjY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1yVuJ7uU; spf=none (imf07.hostedemail.com: domain of BATV+49c0b86eadc47be72e61+7635+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+49c0b86eadc47be72e61+7635+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721374646; a=rsa-sha256; cv=none; b=gJP8PZpgNLUsoPoB6/i1Xvw++7K2z9n4DdvGwovdXTzVEGHNQfPB7gRi6CUHyWMhWlSalQ BWHm5ZkbkMlFhD2PlBCe1uFr9iqt0KTudGZ0N0mEoTreSQEq4dbFvs0+Nzyo2YS2/kYTun dmvb7oHpqpDrtdgV+M6NMLWsds9B7Tc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MLYCYuCYloh5BTxZlLhpoPZZujbRYtJ1MM4522b7GoU=; b=1yVuJ7uUjRAya+W3xvObNlyJlV /X/+5Bg5E91HJ97W0Sh2B+3zDxeM9nHLvGDk1m+3mYFvfLpuyioZG4CHWQ0ijJ8vrP1ZJq2rOfLsw VME8My9e876hS4rcY87I9ZwLHlQbcO1KoqNZBuWpL7tO0sL+wt4Ec+3/PW3kjXJhLlfCt1lp0kmoJ d36YIgYG6YDIGeJ3eDWlQytXlJxj4NA13RDuq9AA4p1hYCAUJfBDyJKpyTJHMFEETf+hAVXQsV0fe DBt1STy8/jatsxEqOWPJGlQ48vIwtYvspKO8Xp6gnRrs6GgD709xSFm3WqOkIR5G0aCOwE2cv+Mk/ mJYvP0IQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUiBQ-00000001w38-0BC3; Fri, 19 Jul 2024 07:37:40 +0000 Date: Fri, 19 Jul 2024 00:37:40 -0700 From: Christoph Hellwig To: Michal Hocko Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, Barry Song , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0062E40005 X-Stat-Signature: rwsg54zw4ncinwrutmz5wyoe9u7wx5np X-HE-Tag: 1721374663-768064 X-HE-Meta: U2FsdGVkX18W8EGRRsQq+qGiGo3Nq4CnYkfDwp6eg43a4wRXZRLfKRJi8zO+in8bRc0L09XczSsk/yfIwsgunENis06T8GHzfrBrZRu8I6IJF5dvVd3vDAKHoZQhtJJCUCsvbmCY+1IEbW5sQM3+a3XTBhlpKBP0HqvdcOC1TPtpj570tsBUODEhOoG87GeK40aKl0CmZ4zIoHJcwL8JEr38gIgSZ/zrS1yRhbO0NuLgO7GgAV87whgdL6u5U4HC0/7vMOESysemN4qhrwzt85Wzh5MATRt1a+N+t+/CbMUFRIPL4OLnjNe5rHEydB+k8ofAN8+myF/4v9mlsdZlb/GTrm6gqkho4xwCfRSJUNR3s7NThAArQaiiXlX17CNxig0xBUsXyX3PFNzeEeA9WQQ1cgwsgT6Pzei1X6/JPIKIQEcZz3K2JoOkvo9fMPqIGJ7a0f3HI94FuzwlL5ZNc5lBQhZpUB6zXDTrihpGCgG/2XkS38OV3REM/8Ota2I32rb6ooktyyi8B0paMYnmxfTI81bDLDdA2ZRBGWvjRJW+e0EKmnkEouxwQ6Zz3i4guttwLSh9+Yyo4rXl/6pXcy2+i8WCKzyxYVaBuThike7WCWqDSEiifPG9Uw6ZCoaqFfPcaMvEjVnPOCc6FevvfBYacv0PSbUoWUyBui19Sc02aTD33IWC5mMoywdLK672OgRcG95AQr0R4KjsIr9lqmqS78P5DVU7KwJwdbBZMyaWJNWY/79OGXRT30OlDECzC/Ut7LRUbDlBEzc+TfIriLBPRS1PFwZWtQA7n/pWkFUx0Z//GA/Dh95/VieCqDv4BLDb9VFHyDFETYwDQlqtpKa735Jl0wT0Irr7/ufHX1e6Pwse9b5LqHG8PnOtv3tJ7+q0xzn5wji5cK/x7Jz+Mf5ziESj3kwjlth7ichwEP1avJE627DClKGrGkjtwCkpvMO8sEsUpVbS79KqRc/ +NqRfOV+ lBviVeHUk0C1S9yc9dwNYQYTf+C4KadHxkR5UHxfI2eeSr83ML0W3QVuJhu8uoD2igSlP3OdoglvrUw+jTfR9f2jL1Tv0b991C1pETb2U7BGhm8AnNqRKkfHRO6E8rJLal+FwSjsESAu71179YZxj0e7r9pjRHG5lpMmxHmOqmT8r32vdFsrYEQwdNaYkyrMqjiAsy9gkzzvlwxHezTe0EwZVRidxXnz//PYSSWZjuZ0I8g6XnVCUSSEcaimk5qwxaNAbXn1xbsFTLoiRX6IBRE02/i+F/yCd53B4QAe+Ae9PtG+XJsKE/gcLyNEJSywxKvzg4/M6b9rVzFD2S/6tGS4EFBlUR86ewHRedHEKTtPHDOpV5H35aLhvb9xPPLh0fboQheTk4RQPAOuGe/8ZRW0RzGV5yFBYCVluxs/aGrfDYL0eqn6Xq5Qe2i6AP2q/VPHQ2aZXAiZ3abyZVoaBE1fq/kWwKDmHOscXX0GIVq3kEIDsIK1tlZp72S22BI8wX9hkKo3xp/MDEl2wKwTO00bekcfLaOD1dMKmwCah51bmn6tsJxhcNP/Xz30Xo2CKueLsPPW7HfpZ1T4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 09:02:01AM +0200, Michal Hocko wrote: > > Additionally, at least drivers/vdpa/vdpa_user/iova_domain.c is > > incorrect with GFP_ATOMIC > > | __GFP_NOFAIL. > > This is broken! Please bring this up with the maintainer of the code. No the only issue in this vdpa mess :( But I wonder if we should have a macro/BUILD_BUG_ON magic to catch totally obvious bugs like this.