From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 653BAC3DA59 for ; Fri, 19 Jul 2024 07:02:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD4BF6B0088; Fri, 19 Jul 2024 03:02:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A84CD6B0089; Fri, 19 Jul 2024 03:02:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94C786B008C; Fri, 19 Jul 2024 03:02:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 76D4B6B0088 for ; Fri, 19 Jul 2024 03:02:07 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 257DB40496 for ; Fri, 19 Jul 2024 07:02:07 +0000 (UTC) X-FDA: 82355607894.13.AC1425B Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf21.hostedemail.com (Postfix) with ESMTP id 0F81B1C0029 for ; Fri, 19 Jul 2024 07:02:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=E8UUZGUx; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721372483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wTnPh9oLF3EKrWClYsEV57fgiHqe0fHCwiQZPQ0YpjM=; b=x/xfwMrO5PyZt6HUXVuPlcR3F4Btsc15ESQ/75onPRRIyNROcuIo9IRNrl+3P1drTTVEbH O5+LQdh1DLzdvaZCJZQKkG2vnBAVtWSXG9LUbK4CVlNR2lt/fRHy/4TlyVFpbRy+lAMYrY /cJkPux+q5BvZwLtTcW9F5UKhIPBEvw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721372483; a=rsa-sha256; cv=none; b=QoLvciu4rB6yyVNMSYaZcnalUgeXvNZSOgWP8bO/eVVSHhL5DJf1LoO0dfV7suf8OLeBWK ebJBov12XkMDoe0AzQTYDE6r3yWEpk2l95VHQLlh0ai2FPbzNWnJVqiKUU2gdMNG2nXKv8 6LXsjClKKyPMhDzINFDjLOfLlkIEimU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=E8UUZGUx; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4265b7514fcso6323535e9.1 for ; Fri, 19 Jul 2024 00:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721372523; x=1721977323; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wTnPh9oLF3EKrWClYsEV57fgiHqe0fHCwiQZPQ0YpjM=; b=E8UUZGUxmAODlpdQvEdr7g9WpYkbRO63jz2m0UdEXrA55L4dK0iX+siefHqOz+k/9u JYzL9IBD7GlVb57m8O8o/2QKhJRMq7THYXVD5pcDH/lVUpdhz1jY1HNlPjnVqNEhvbVf //iBQDygi3WNEfXJ/puxQjBT0u8U36jXgY8xNX9I3Y341Jll0onxKD6p/0kVBaWcdZx9 s5gXSkkiNHfX8Koma6DQj+x3WKZAk5eo5+t1RBih4lFbKuhK6TTYP2TH95UyiGgY2LFh NXDUI9tZGFITvJAdAI3BuIvpH20hXe5KCl0BS31vUh69l2iUeochfMEvstiF4LjVoK1i HH6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721372523; x=1721977323; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wTnPh9oLF3EKrWClYsEV57fgiHqe0fHCwiQZPQ0YpjM=; b=ZziMNIPfTJxE50tvdXCV79Z8+MOBh0D07rdbKS9CSJpV4L/6uoCMnwA6k14nOv6JWQ ciUGb4QMypEdCTYM7kVPoYtvWHTC+a1/6xZabMmlfpNhpeHusPqQ8t7oHNsXwtFmh67A zX2hs7zvCk4YKVPrPRpFZ7i2scZSOsv5VhRJMJEgjDimpnB384jic+qDqdGZzaa1iIQu DCf73vlV5NqatWaNjlXyryuqrxIpiV1jLAox9ioLCK5nHHpTeRDOVCNla2ZylIAAL2bZ 3vZOLOjjNKqrMz12V8LNbATjZ59KAI4+4qggG/RiQ+8gaiOFKJUxYLNwJEtdg6SZVyLB J9QQ== X-Forwarded-Encrypted: i=1; AJvYcCVEsCBzkw0dhDshhMv2hQY6ZKujXAFGfq/bDdbfFDixTrBSoxUFS10gheAN+DhBCUsaTB4MBeih/fTugLhhUKgFPRc= X-Gm-Message-State: AOJu0Yx1Mcq27eGbcBTtZNgLWztBCHwncOi2Fy+7sHI5oVlWMa9c26ln nYfJVJ/XikYRb4xkfYnSdwV8L+1Lic+d2cX5amBi3aSU4mH6yGltQez84+qrwT8= X-Google-Smtp-Source: AGHT+IEZWDchb/vC+XGQyLFIfpj4sWM3b1pV8nI8ufoR88iEkLcv9up/exDiu/rz9/1uCJgYevEbFQ== X-Received: by 2002:a5d:4802:0:b0:35f:314a:229c with SMTP id ffacd0b85a97d-368743e8701mr918254f8f.28.1721372523474; Fri, 19 Jul 2024 00:02:03 -0700 (PDT) Received: from localhost (109-81-94-157.rct.o2.cz. [109.81.94.157]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36878811899sm748816f8f.116.2024.07.19.00.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jul 2024 00:02:03 -0700 (PDT) Date: Fri, 19 Jul 2024 09:02:01 +0200 From: Michal Hocko To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Barry Song , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0F81B1C0029 X-Stat-Signature: js1no55tha8ywmkmhq67p4xc14u4tcfm X-HE-Tag: 1721372524-487854 X-HE-Meta: U2FsdGVkX18YAfxmiTBTYRdwyrwRpujFuFleKgDf860jCRJ366Y0CVlG6oFBQ7jk7u4MZ34Ib3+LES/mQ1d6/Pn/Drq2i7y/slJBpITcxEmjkWYitwL/EMOgwmwfeG6WOuFKPNeEqy6thmKMgufdbxu/qBp3MzFQfbpbr2G+G8TSMzD6+Uwfh5qWNHWKC3sbSYkNzNrw4jPQ0o17/eQZgwu2LuKiYsgB60KyVhPKTi0bjHWI1JfFchPIJj9kI0BWieKJy5Th2qVuZd/DQfZcQ5LQi0aD5lwpIgMkfB6ItiRA0ZuBIp4MaXg4DwYQ5ZU6jzwWF3eJ+wo1tg2GBzZpQHavEXuyGMUVNIFpJ5ILUU5zapUK6RbQS08my4z4axAxNhsUSA36sTVO3xSu0yt14/BhZPsRr5mIg3BbIRyu82ecbegT0LMgHSL+vQe4DrsjrErqNYFZlVlR7RV7l3xg14f0ifsuLbq/vG1bUuGdAs33px4YQIRRisKGNhY7iIwQ0ZVqdKrtiL1sTQjM+7zbAuirdiYWAeFdVbC/i/21l8Nn5nE7OfWQ5QRws90/qitW1n58XTMNoO/Ce+5KbCjI2yOpAF8Pds/hSNVWOE6g8apIRWLraYkTTXdpLqtHX9DLXnYMTF4R/k98IgUcq/yDzam8PP0iAkqboHJ+wbQUGnJGEWkA+3/pCjnnhjJoSQbvXDjagLbhpw9fk5AtbUa5x4nMnHVPnJZ12HIpaZz8LEwYTebbwaZ8Xwx7oqBGJbFkXhcxDZ64Oq9XkJrg1nibqpOwj9wZeOWEC2BHFzylaXKdfc8PzGHoynEWmj90hhzKhSmSWn3+boRpYvNtS5Ng2yW3oaKVMS6Ps9+BYJT9pQtOufyjWTsNEyTn0BpUX0YdFQhN9V6L2gQBL38MLYpykHWggSsvlpGt11Z0pD1IjVh1djwPbVd274t+3OVxMc0wRzxyru2PbD3oaToSbiE Ue9aKYvl PAEMXAZR8Bj8xlm9A+OlHIcYz2RTf1iysGlapBlBpQBad+jrH0UhlPPGrfWIYFRuxy39BLqq1WaNIy/y/C9c9vskZx22JYmaK14OYD7OfDaOtDiuiAM96MWo7MH5u2q3W4svSIC+xipUYeMNIVw39It7spPMdlf0WDE/JvCZ/oPIDfi7yg9eqWZGUjBEUCTlOk3c5Z4b9urkRJKzTwqwSQ0ZXYWKtQvTTVdAW24NcdX13OTSvLOhydJEo56UdxfVz2OoY6SZjbgfDRn51dgS914+D/A8N2GQRDGFqHOdWbQJ9eKICnZrm8Cjafz8ri6liOW4mARM+KjLP2EP5KDn8FFH34UEUZuMs+LJHCtXATQLxTQ3PI00eoCW6pACMKEL2CQJ6+QUVS6zHTyUU4o4Vz7Zq6cMoVdGIWvdMCXAitQc59LpRx3am2pdExN5/z97Rr9xU5Hu/4TjQWwrTuGPJqD+AnLTmSCVXxQDdWkJ9K5mIrHY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 19-07-24 12:35:55, Barry Song wrote: > On Thu, Jul 18, 2024 at 8:50 PM Michal Hocko wrote: [...] > > Yes, those shouldn't really fail. NOWAIT|NOFAIL was something that > > should never happen and I really hope it doesn't. Others should really > > retry but it's been some time since I've checked the last time. > > > I assume allocations directly using alloc_pages() might not respect GFP_NOFAIL > and violate the semantics of GFP_NOFAIL. What do you mean? > Additionally, at least drivers/vdpa/vdpa_user/iova_domain.c is > incorrect with GFP_ATOMIC > | __GFP_NOFAIL. This is broken! Please bring this up with the maintainer of the code. [...] > GFP_NOFAIL things need to be fixed. Let me investigate further. Thanks! -- Michal Hocko SUSE Labs