From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B5EC41513 for ; Thu, 18 Jul 2024 11:45:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F19E56B0099; Thu, 18 Jul 2024 07:45:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC9AD6B009C; Thu, 18 Jul 2024 07:45:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB8246B009E; Thu, 18 Jul 2024 07:45:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BD5826B0099 for ; Thu, 18 Jul 2024 07:45:24 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 64FD6141A1C for ; Thu, 18 Jul 2024 11:45:24 +0000 (UTC) X-FDA: 82352692968.17.65554BF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 446841A0026 for ; Thu, 18 Jul 2024 11:45:21 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hAZWFU+5; spf=pass (imf19.hostedemail.com: domain of dakr@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721303068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gARO8cy+TaHyMsls9YZlKFe+qvl8Wy3laxdo8eLc+yo=; b=u24s926O7tKsSo6fvqgj9fHNrS0c5J/augMfFV2rc9007/1adFAmhF2GAzyQM+Esg7Nc7P SQT5CYJ36aup8ZtltFmdrhgYi4sE/9rO2OnS7COTy/Ox7zRyKsy3Gtmq4z2gPgP4eEAyp4 jybPRGRrVGN4Bu9jAiZWjx6a3r4S6Bs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hAZWFU+5; spf=pass (imf19.hostedemail.com: domain of dakr@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721303068; a=rsa-sha256; cv=none; b=8HrWZlfa7IthHAm6L74SyTT7MQv+W2sP+AJgiorhf1OrIdx7NHWVscAHQBKj8oz4VTXicv N6CzZTG5rNJoUVUZ4TB4O6Aal3hndOMbbPBvKnSGBE48Vrgry7HsDT40HhUihLbLx3tP11 pgDt/YScg1iLn8CCZoZ7qVq7JTp4vk8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6DDE5CE1A4E; Thu, 18 Jul 2024 11:45:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B72AAC116B1; Thu, 18 Jul 2024 11:45:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721303118; bh=6dDkmxqvJY8h61QecQ5gJGkM7Qx9fiJB6j7R5iGc7TU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hAZWFU+5O9a3urAw6D6eH506PIDqNsVSfC9vYYllWtzOOOipRvFCyQRAmfO3RGLzR EapBZ+yFliVUUQJ6ypC1xJaCoEZ8hM4Z4bgdB6k2uQ6DbEKK02beSf5xaiscmqMLb9 3qaSOftrgSs7pPf0y18DxDE5Ls9I3d2qFyOuXgrWgVwwj50HTN4Ew5dwiks8sfxo+J E8+4Zvtf/d7SGJIkVXRyIGz7/wNXnvyWmecRkBAi5DVpOzEujLToxcSGrGbjavlWlc wwdSu/oTKdBqNeaW4XURZg6IfXMOmKHULCMH1pAk9kh4KDv0LgQlW2CBuMcFQCS57x 3boscUjlhGk3Q== Date: Thu, 18 Jul 2024 13:45:11 +0200 From: Danilo Krummrich To: Christoph Hellwig Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, urezki@gmail.com, kees@kernel.org, ojeda@kernel.org, wedsonaf@gmail.com, mhocko@kernel.org, mpe@ellerman.id.au, chandan.babu@oracle.com, christian.koenig@amd.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH 2/2] mm: kvmalloc: align kvrealloc() with krealloc() Message-ID: References: <20240717222427.2211-1-dakr@kernel.org> <20240717222427.2211-3-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 446841A0026 X-Stat-Signature: u5db376u6uz5kawifpgmki4qn3tptatx X-Rspam-User: X-HE-Tag: 1721303121-9851 X-HE-Meta: U2FsdGVkX185yn2w32v0CEx5LcbGbDNh+7MQPWaXgLkErr3hY3wTHi+MYh4WJzQRZGu63YkK+Sou8EeBQ9yAJmp5NtDMbvQWClyrfh0WWxbqFHLwZ2KKw6bsPeiI+c9uwLbym+hLICluyGSYoDjD19ezn7yEblclsmfu4EK6HLxoQOyTb8QR4tuFDO8o4y+LEmo7VSZt02Ha7mrJH4lPhjqOQ/gBmd0Aiw1OIWmFeSqaeYLivkV64vgj6tYq0tBMsvTjG+Ji08Bz75OQ3rCLZVAiQ2472WLFawvDNWZ4nVWhdk0mdXpaMp7yM9Lfs7S1UkhU9RuVDhafpdwYHcOjYmOQAVhO6XnGtacnl5m36+X3Ri+uwgR2ZKdqtS/G3liva7MTvdk6pSlnLUgykPMMNhTmDfV2KpEiVjqVB5sRPGo0sZ/JvxWLuhgEEasrgtbXLIxXko+6+uHxEnB/3BtodB6nDNARqljWaurIe04E45thzq8ty6F0YKXCJgbaoOXx1r+WHRmoNV0cmXynWXs1j+r21C76JrcUzv7BmzwSz7lneNvRBJpLGQqRYBdPkm+X84hzhHiJgn3yESurUjRS4QDtrYnIG6MRE+p1YDZhdluv18D9PJoynXNT2r+STuVyGAZrBE0eGr/ZdRcYoCOuWYUfo6dumsF7dStOYsTF/hXUnPyDIVk8XV6e4oVktj8eLBKFnZQhiJy1HBuirKsinfSGIZsQji+MzIS7s98ziDvBMK5Kkq5hqfJJPHRZKc2QW6+ehvjCy6dTU0o+VTmHyWJeH4hvxjJlgPrrEiGkEzj6NjRJXxjUgKh6E1RxpyypZKQEP1kkb+dGlMN9RHajkJ3yJzWX2x7rGchBA7VqSv7F0KpULSzHzg4sdE2LpQbe1vY1AP4uInDungBtz3NUdhvjUgj3kqfR11d9n0f4S+4DR/BFziJgHyb1lBDE0eqNLpctVo4Hu9X8DaPDswt k89v8OeI gCMHwOECZaZjUydj679Y4FlDrrgDHZUKwRaDhikfggSJKUVfPrC33HjIVqikQ78J81zbN6kiT5w0qNLQi0mqqshV1jaJg5cUgsW/tucPy+I2rHWDH1Lco5bPkV6Mz+2ngivXmdzlx7iKNPfCd9n20HcDgUkhbbRaMQhDBCVFOstDTjrdpGvmuTHlFGoHeNpA5o5PahA7UC0vHGWQFZuuN+Whx6c1cngdD0XD3WZVjbC7CHqpErvUoOT0cGOUOYODzAjVu8ZKiLQu3amQjkeEpVsXudxt0YYj07E7f X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 08:19:26PM -0700, Christoph Hellwig wrote: > > +extern void *kvrealloc_noprof(const void *p, size_t size, gfp_t flags) __realloc_size(2); > > Please drop the extern while you're at it and move the __realloc_size > attribute to a separate line. Will do. > > > +static gfp_t to_kmalloc_flags(gfp_t flags, size_t size) > > +{ > > + if (size > PAGE_SIZE) { > > + flags |= __GFP_NOWARN; > > + > > + if (!(flags & __GFP_RETRY_MAYFAIL)) > > + flags |= __GFP_NORETRY; > > + > > + /* nofail semantic is implemented by the vmalloc fallback */ > > + flags &= ~__GFP_NOFAIL; > > + } > > + > > + return flags; > > The name for this function sounds a bit odd. Maybe kmalloc_gfp_adjust > instead? Also the comment explaining these flags tweaks should move > from the caller to this function. kmalloc_gfp_adjust() sounds good to me. I will rename it and move the comment up.