From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4C0DC3DA60 for ; Thu, 18 Jul 2024 08:10:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 791ED6B0085; Thu, 18 Jul 2024 04:10:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7696B6B0088; Thu, 18 Jul 2024 04:10:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 631186B0089; Thu, 18 Jul 2024 04:10:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4539F6B0085 for ; Thu, 18 Jul 2024 04:10:34 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C4693A0DED for ; Thu, 18 Jul 2024 08:10:33 +0000 (UTC) X-FDA: 82352151546.10.98F5D6F Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf27.hostedemail.com (Postfix) with ESMTP id BFE6840028 for ; Thu, 18 Jul 2024 08:10:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=J7st9h+4; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721290192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=76dnrtuWhzYwHnyFzkGb7MBr43hvYawhckJH3fPSFL0=; b=IUlZuvU0I6qi3yUm8Z7JIvIfFFqon9dhhyRA9zNM6uZi0QRZQBIuElep0egKHSczCODl7U znmemN65MOf4NNyDvibBg3NAVCojaBQ7OSAM+gTEc7qRu35zLnFCnqtGKtVZBJHizsOBty BwEUYVBvBDtgIS1GH8GNHGwcGCdN6Vo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721290192; a=rsa-sha256; cv=none; b=fUIsfYxp4mTpr3eaqyANIQVXwNEZOZUo3UtkvX+PTcRbmxg5rHb3sPLdzRRO+g3bW2DKMR POecrwEahT/l+5+Ef1qr2tOk/SCePIbHpE10RtbzXKvWBMTIUSBE6F51cqVRYAX40hpiav 2b8eVxZLIVNQckof3AE9VkqeT01Oy7w= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=J7st9h+4; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a79f9a72a99so303494866b.0 for ; Thu, 18 Jul 2024 01:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721290230; x=1721895030; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=76dnrtuWhzYwHnyFzkGb7MBr43hvYawhckJH3fPSFL0=; b=J7st9h+4CZtVfDQgECnnYT76RnhA4QeuoLCUDwa9FW84S4fI/baYvXkE9J7bPYqX6L qD8tlXoYdqZGUH3lNP6yfvH/V3/z8nS/X2EX0GO+Opbvj0U6TqNdmOwpcUtnMu0+cG6N /3UG93BoGRgYAoh45MW5WNwGSs+pioIgRL9+X6TIqn8bTNSNJGmVKl/VpnQCNcc5J0Hj 1bTrWcP/pLM8enYX1BaNZiG4ILc+OWEsTdWtlI31nBDB6ZwEzY+eQ1umbcXx/iqLopni ttlxG3lj3K07q1LtViBLd8gfqV4P4KiKfPVXbZgLWOR2rJBBYw4zI9yO0e9yT2IHj1Os g90g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721290230; x=1721895030; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=76dnrtuWhzYwHnyFzkGb7MBr43hvYawhckJH3fPSFL0=; b=Iz8urO5qDxRHHHZ/9/E2JZk1JKfjyUu1jl2yYqxyLe+bHWl0tGn0gRMDDiAup4wXjY rNvop+8GUOZN0AvahzDBMop3lFwNF6/LhOhlFOvt0UMQ/sE5OBR8dDCa3lP00+RKqBTx TKCiWnQu7mUbq9e1J/gC6KtIOlyf8k1QAY6xdIogsYx8IXlTOlHZb1MDnXBvlR8NhRAc Sencg54tlSRhAJ7JLbVQjm7b3oyeLkxPsjJz3S0IhOgWMUgunSicop6UCETnCiLlSGvp N6S5ulzna1odXvvEgmlmLHG2EKdUdtQao/0Yb5keZuIdVoXHM39thdfNBMuM9BJRwIj8 Q8wQ== X-Forwarded-Encrypted: i=1; AJvYcCUst1xUWO97fmgWgXb5MSU1Oz1HMQKSq2qAxNcnKiRGbEn10wvVLrgOZjuJaWfzKi/sHyMBuSzy15YQxuJTNPN/i4E= X-Gm-Message-State: AOJu0YyHT01SWB3zz31T4qIK0Fk52FoiLcpxJq7XxhwHfxD6ZK7CYHlb TGrVf34Q6JfUMGx6dipWYr+dQgIzkv3aeF1AoGTFwZCTij3UB68OippVURLAgTA= X-Google-Smtp-Source: AGHT+IHDGcsXV9BowhgEkzRV8IViMd8b0kzojmy2zxD9zUc2ioY5avjUdu6Qi9xyrE13MyeYrVTjHw== X-Received: by 2002:a17:907:3f1a:b0:a77:f5fc:cb61 with SMTP id a640c23a62f3a-a7a0eb8cb2emr283950266b.0.1721290222664; Thu, 18 Jul 2024 01:10:22 -0700 (PDT) Received: from localhost (109-81-94-157.rct.o2.cz. [109.81.94.157]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc5b7eeasm528664666b.71.2024.07.18.01.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jul 2024 01:10:21 -0700 (PDT) Date: Thu, 18 Jul 2024 10:10:21 +0200 From: Michal Hocko To: Qu Wenruo Cc: "Vlastimil Babka (SUSE)" , Qu Wenruo , linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Cgroups , Matthew Wilcox Subject: Re: [PATCH 0/2] mm: skip memcg for certain address space Message-ID: References: <8faa191c-a216-4da0-a92c-2456521dcf08@kernel.org> <9c0d7ce7-b17d-4d41-b98a-c50fd0c2c562@gmx.com> <9572fc2b-12b0-41a3-82dc-bb273bfdd51d@kernel.org> <304fdaa9-81d8-40ae-adde-d1e91b47b4c0@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: BFE6840028 X-Stat-Signature: aqkmsbpeyp3rxtmepnpepxh63tww9jdb X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721290231-170480 X-HE-Meta: U2FsdGVkX18EbPlPow9gFLiG7w9NwGst1SnApPJCEx5yZJZJ/zNHofrFSsp/rCA+BvdTP3rWpOY+mvLKaOFyDerebGtGJNeVrrselhIUbkUCj0sVNE1GfQnJwcHiLJzxb85uhNUC8pewJKzmpgw3Hg4rEqkqV0OZonvXmTaUJPiu2Xa8lArLXgBAkpCJ3SRVzjqgVTwZtwnAduFlktGk5hROiDYewAMtgdpBZspdiDqaZLkiwbvHmw4EsKRBYk8DFxEr6IGQkGu7fd4MRO4ojr44kXyzt66yEdHF4GWSB624YBNAC92nxnY3clOfFVKZTB/AW7y41AJCjDxLdUcLAp1K2ViRXnE5eQOm/lhmcqtwiWGkvQzL0HwEx43nBgpLU9YlBqFmwavyWU8Ke9iZHGFYqgFnGVjSGqjwpgXa0b+S3espR4DvGY+8LaNUhO+oPqapjDXJ9isWUzkrV14+jgyy4HHf5UFL0FcL7BaIT1tyvvo57Sz9twVp4SIlgvYtvhyXwlX0sU80mrweBti+C35P7n7FZIfvs3+aZPFfpia6Xizp0MIjZmHXIYce2zgAsv38sfwhSW3JWIc8fBzb53SHv+Tc4VwHDo/BollafqBplgXShHN5u7Xxbx8r1ZG27+33lyJ6miYUWNsRSadHutg3JQBQG1LC9Vxc9xhyNS9OSrfmDHcbOACItradAgtevmzypdITDD8QgQavML1rV30SGfHJE39IQEGpnrJPvThwt2GgLAqsiRWqQYK4RaQZg7eDhqx4az5Z0kT+SrE50hyOq1pR95/iY3zXOg3xI7YDuut+MtNVASkmkj5rbnpdf5hH+UwbFEqsFqkhGzcLdzrfYEXw5J0SjOFpoa5/TgNUEgejjgCmw8B6tPSStRs5O5uJ5Hb8IlPRy3bvI1/z8Dfmkqgtgx3glVv2+ajQws1UuKplAt4EZDswdLhW3mPWt1a+Pe1YXmeYmTnZj/m jr9pdC9j V4RWNnPSyJQHFzBtd/4S7E7CUpN4/1y45aSdh+IJWDTB9flgmRW7s45SyZEl0Zr9uxGVeNJJNc/kiT+qe0tBoaGqeOtsqbxzLgP7+l2wnjxx6x4hJR/3k+acxRDqIo7qXBS0VTzXAZZ5V8do6Da33vfzYXHbh2pmtuSQ9IPE51pD7Vneqp4WB5HjzFr+dWa3B2l90bR0AA+6pF9M1fKOPh5UjvZ4dcjkPp4wZl0LkNgzhXc+taV174MiCnptd+vt/K1fEkxtjdny9BzV4upsQrT+TCO0QTHB1cLlIRUJVYFoy1si3H5SyYNuGHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 18-07-24 10:09:31, Michal Hocko wrote: > On Thu 18-07-24 17:27:05, Qu Wenruo wrote: > > > > > > 在 2024/7/18 16:55, Michal Hocko 写道: > > > On Thu 18-07-24 09:17:42, Vlastimil Babka (SUSE) wrote: > > > > On 7/18/24 12:38 AM, Qu Wenruo wrote: > > > [...] > > > > > Does the folio order has anything related to the problem or just a > > > > > higher order makes it more possible? > > > > > > > > I didn't spot anything in the memcg charge path that would depend on the > > > > order directly, hm. Also what kernel version was showing these soft lockups? > > > > > > Correct. Order just defines the number of charges to be reclaimed. > > > Unlike the page allocator path we do not have any specific requirements > > > on the memory to be released. > > > > So I guess the higher folio order just brings more pressure to trigger the > > problem? > > It increases the reclaim target (in number of pages to reclaim). That > might contribute but we are cond_resched-ing in shrink_node_memcgs and > also down the path in shrink_lruvec etc. So higher target shouldn't > cause soft lockups unless we have a bug there - e.g. not triggering any > of those paths with empty LRUs and looping somewhere. Not sure about > MGLRU state of things TBH. > > > > > > And finally, even without the hang problem, does it make any sense to > > > > > skip all the possible memcg charge completely, either to reduce latency > > > > > or just to reduce GFP_NOFAIL usage, for those user inaccessible inodes? > > > > > > Let me just add to the pile of questions. Who does own this memory? > > > > A special inode inside btrfs, we call it btree_inode, which is not > > accessible out of the btrfs module, and its lifespan is the same as the > > mounted btrfs filesystem. > > But the memory charge is attributed to the caller unless you tell > otherwise. So if this is really an internal use and you use a shared > infrastructure which expects the current task to be owner of the charged > memory then you need to wrap the initialization into set_active_memcg > scope. hit send too quickly, meant to finish with ... and use root cgroup. -- Michal Hocko SUSE Labs